TIP: How to stop the annoying ns???.tmp firewall messages...

I recommended doing this in my opening post, so I figured I would post some working sample code for replacing

nsExec::Exec `$COMSPEC /C move /Y "C:\OLD\DIR\*.*" "C:\NEW\DIR"`

with Rename in a FindFirst/FindNext loop.

I created a simple macro to do the work, and included it in a sample script so you can play with it.

Page instfiles               ; show the log screen
ShowInstDetails show         ; show details on the log screen
OutFile "testmove.exe"

;↓↓↓ COPY everything between these two lines ↓↓↓
;usage: ${MoveFiles} "filespec" "source-directory" "destination-directory" $tmp1 $tmp2
; NOTE: $tmp1 and $tmp2 are temporary variables -- they get clobbered.
!macro MoveFiles filespec sourcedir destdir tmp1 tmp2
    FindFirst ${tmp1} ${tmp2} "${sourcedir}\${filespec}"
    ; ${tmp1} = FindFirst/FindNext search handle
    ; ${tmp2} = first filename that matches ${filespec} in ${sourcedir}
; loop:                    
    StrCmp ${tmp2} "" +4 ; "done" (${tmp2} == "", if no more matching files)
    Rename "${sourcedir}\${tmp2}" "${destdir}\${tmp2}"
    FindNext ${tmp1} ${tmp2} ; ${tmp2} = next file matching ${filespec} in ${sourcedir}
    Goto -3 ; "loop"
; done:
    FindClose ${tmp1}        ; finished with this search; close handle
!macroend
!define MoveFiles "!insertmacro MoveFiles"
;↑↑↑ COPY everything between these two lines ↑↑↑

Section Main
    DetailPrint "Moving files..."
    ${MoveFiles} "*.*" "C:\OLD\DIR" "C:\NEW\DIR" $0 $1
    DetailPrint `"Processing"...`
    Sleep 2000
    DetailPrint "Moving them back..."
    ${MoveFiles} "*.*" "C:\NEW\DIR" "C:\OLD\DIR" $0 $1
SectionEnd

So, if you include the macro in your script, you can replace the unnecessary nsExec DLL call with the following:

${MoveFiles} "*.*" "C:\OLD\DIR" "C:\NEW\DIR" $0 $1
; NOTE: $0 and $1 are temporary variables -- they get clobbered.

Not only is this cleaner (by staying in the native NSIS executable), it will result in one less ever-changing ns???.tmp warning from user firewalls.

Enjoy. -hea

<EDIT>
I got rid of the arbitrary register usage... Now the user simply specifies which two variables should be used as temporary variables. Since ${MoveFiles} would rarely be used more than a couple of times per script, the additional complexity of a function didn't seem to make sense.
</EDIT>

@John
I was about to post a revised macro when I saw your post about Push/Exch and BSD licensing...   So, I restructured it as a Function and put it in an include file along with the BSD license header. Please check out the results on drop.io.

@wraithdu
Notice I introduced the nasty [ RMDir /r ], so I had to add handling for dot and dot-dot after all.

I made a copy of the FirefoxPortable\App\firefox directory in my C:\temp and tested MoveFiles.nsh with the following script:

Page instfiles               ; show the log screen
ShowInstDetails show         ; show details on the log screen
OutFile "testmove.exe"

!include MoveFiles.nsh

Section Main
    StrCpy $0 0
    StrCpy $1 1
    StrCpy $2 2
    StrCpy $3 3
    StrCpy $4 4
    StrCpy $5 5
    CreateDirectory "C:\temp\firefox-NEW\firefox.exe"
    DetailPrint "Moving firefox.* with mode=DOS (like MOVE)..."
    ${MoveFiles} DOS "firefox.*" "C:\temp\firefox" "C:\temp\firefox-NEW"
    DetailPrint "Moving firefox.* with mode=FORCE (like MOVE/Y)..."
    ${MoveFiles} FORCE "firefox.*" "C:\temp\firefox" "C:\temp\firefox-NEW"
    DetailPrint "Moving all files and directories (mode=DIR+FORCE)..."
    ${MoveFiles} DIR+FORCE "*" "C:\temp\firefox" "C:\temp\firefox-NEW"
    DetailPrint " "
    DetailPrint `"Processing"...`
    Sleep 2000
    DetailPrint " "
    DetailPrint "Moving only the files back (mode=DOS)..."
    ${MoveFiles} DOS "*" "C:\temp\firefox-NEW" "C:\temp\firefox"
    Sleep 500
    DetailPrint " "
    DetailPrint "Moving the directories back (MODE=DIR)..."
    ${MoveFiles} DIR "*" "C:\temp\firefox-NEW" "C:\temp\firefox"
    DetailPrint "$0 $1 $2 $3 $4 $5" ; check stack handling of registers
    RMDir "C:\temp\firefox-NEW"
SectionEnd

and got this output (which is correct):

Create folder: C:\temp\firefox-NEW\firefox.exe
Moving firefox.* with mode=DOS (like MOVE)...
Moving firefox.* with mode=FORCE (like MOVE/Y)...
Moving all files and directories (mode=DIR+FORCE)...
Rename: C:\temp\firefox\AccessibleMarshal.dll->C:\temp\firefox-NEW\AccessibleMarshal.dll
Rename: C:\temp\firefox\browserconfig.properties->C:\temp\firefox-NEW\browserconfig.properties
Rename: C:\temp\firefox\chrome->C:\temp\firefox-NEW\chrome
Rename: C:\temp\firefox\components->C:\temp\firefox-NEW\components
Rename: C:\temp\firefox\defaults->C:\temp\firefox-NEW\defaults
Rename: C:\temp\firefox\dictionaries->C:\temp\firefox-NEW\dictionaries
Rename: C:\temp\firefox\extensions->C:\temp\firefox-NEW\extensions
Remove folder: C:\temp\firefox-NEW\firefox.exe\
Rename: C:\temp\firefox\firefox.exe->C:\temp\firefox-NEW\firefox.exe
Rename: C:\temp\firefox\freebl3.dll->C:\temp\firefox-NEW\freebl3.dll
Rename: C:\temp\firefox\greprefs->C:\temp\firefox-NEW\greprefs
Rename: C:\temp\firefox\install.log->C:\temp\firefox-NEW\install.log
Rename: C:\temp\firefox\js3250.dll->C:\temp\firefox-NEW\js3250.dll
Rename: C:\temp\firefox\LICENSE->C:\temp\firefox-NEW\LICENSE
Rename: C:\temp\firefox\nspr4.dll->C:\temp\firefox-NEW\nspr4.dll
Rename: C:\temp\firefox\nss3.dll->C:\temp\firefox-NEW\nss3.dll
Rename: C:\temp\firefox\nssckbi.dll->C:\temp\firefox-NEW\nssckbi.dll
Rename: C:\temp\firefox\old-homepage-default.properties->C:\temp\firefox-NEW\old-homepage-default.properties
Rename: C:\temp\firefox\plc4.dll->C:\temp\firefox-NEW\plc4.dll
Rename: C:\temp\firefox\plds4.dll->C:\temp\firefox-NEW\plds4.dll
Rename: C:\temp\firefox\plugins->C:\temp\firefox-NEW\plugins
Rename: C:\temp\firefox\README.txt->C:\temp\firefox-NEW\README.txt
Rename: C:\temp\firefox\res->C:\temp\firefox-NEW\res
Rename: C:\temp\firefox\searchplugins->C:\temp\firefox-NEW\searchplugins
Rename: C:\temp\firefox\smime3.dll->C:\temp\firefox-NEW\smime3.dll
Rename: C:\temp\firefox\softokn3.dll->C:\temp\firefox-NEW\softokn3.dll
Rename: C:\temp\firefox\ssl3.dll->C:\temp\firefox-NEW\ssl3.dll
Rename: C:\temp\firefox\uninstall->C:\temp\firefox-NEW\uninstall
Rename: C:\temp\firefox\updater.exe->C:\temp\firefox-NEW\updater.exe
Rename: C:\temp\firefox\updater.ini->C:\temp\firefox-NEW\updater.ini
Rename: C:\temp\firefox\xpcom.dll->C:\temp\firefox-NEW\xpcom.dll
Rename: C:\temp\firefox\xpcom_compat.dll->C:\temp\firefox-NEW\xpcom_compat.dll
Rename: C:\temp\firefox\xpcom_core.dll->C:\temp\firefox-NEW\xpcom_core.dll
Rename: C:\temp\firefox\xpicleanup.exe->C:\temp\firefox-NEW\xpicleanup.exe
Rename: C:\temp\firefox\xpistub.dll->C:\temp\firefox-NEW\xpistub.dll
 
"Processing"...
 
Moving only the files back (mode=DOS)...
Rename: C:\temp\firefox-NEW\AccessibleMarshal.dll->C:\temp\firefox\AccessibleMarshal.dll
Rename: C:\temp\firefox-NEW\browserconfig.properties->C:\temp\firefox\browserconfig.properties
Rename: C:\temp\firefox-NEW\firefox.exe->C:\temp\firefox\firefox.exe
Rename: C:\temp\firefox-NEW\freebl3.dll->C:\temp\firefox\freebl3.dll
Rename: C:\temp\firefox-NEW\install.log->C:\temp\firefox\install.log
Rename: C:\temp\firefox-NEW\js3250.dll->C:\temp\firefox\js3250.dll
Rename: C:\temp\firefox-NEW\LICENSE->C:\temp\firefox\LICENSE
Rename: C:\temp\firefox-NEW\nspr4.dll->C:\temp\firefox\nspr4.dll
Rename: C:\temp\firefox-NEW\nss3.dll->C:\temp\firefox\nss3.dll
Rename: C:\temp\firefox-NEW\nssckbi.dll->C:\temp\firefox\nssckbi.dll
Rename: C:\temp\firefox-NEW\old-homepage-default.properties->C:\temp\firefox\old-homepage-default.properties
Rename: C:\temp\firefox-NEW\plc4.dll->C:\temp\firefox\plc4.dll
Rename: C:\temp\firefox-NEW\plds4.dll->C:\temp\firefox\plds4.dll
Rename: C:\temp\firefox-NEW\README.txt->C:\temp\firefox\README.txt
Rename: C:\temp\firefox-NEW\smime3.dll->C:\temp\firefox\smime3.dll
Rename: C:\temp\firefox-NEW\softokn3.dll->C:\temp\firefox\softokn3.dll
Rename: C:\temp\firefox-NEW\ssl3.dll->C:\temp\firefox\ssl3.dll
Rename: C:\temp\firefox-NEW\updater.exe->C:\temp\firefox\updater.exe
Rename: C:\temp\firefox-NEW\updater.ini->C:\temp\firefox\updater.ini
Rename: C:\temp\firefox-NEW\xpcom.dll->C:\temp\firefox\xpcom.dll
Rename: C:\temp\firefox-NEW\xpcom_compat.dll->C:\temp\firefox\xpcom_compat.dll
Rename: C:\temp\firefox-NEW\xpcom_core.dll->C:\temp\firefox\xpcom_core.dll
Rename: C:\temp\firefox-NEW\xpicleanup.exe->C:\temp\firefox\xpicleanup.exe
Rename: C:\temp\firefox-NEW\xpistub.dll->C:\temp\firefox\xpistub.dll
 
Moving the directories back (MODE=DIR)...
Rename: C:\temp\firefox-NEW\chrome->C:\temp\firefox\chrome
Rename: C:\temp\firefox-NEW\components->C:\temp\firefox\components
Rename: C:\temp\firefox-NEW\defaults->C:\temp\firefox\defaults
Rename: C:\temp\firefox-NEW\dictionaries->C:\temp\firefox\dictionaries
Rename: C:\temp\firefox-NEW\extensions->C:\temp\firefox\extensions
Rename: C:\temp\firefox-NEW\greprefs->C:\temp\firefox\greprefs
Rename: C:\temp\firefox-NEW\plugins->C:\temp\firefox\plugins
Rename: C:\temp\firefox-NEW\res->C:\temp\firefox\res
Rename: C:\temp\firefox-NEW\searchplugins->C:\temp\firefox\searchplugins
Rename: C:\temp\firefox-NEW\uninstall->C:\temp\firefox\uninstall
0 1 2 3 4 5
Remove folder: C:\temp\firefox-NEW\
Completed

Let me know what you think. -hea

P.S. Now what about my other "TIP" posts.