You are here

[Fixed] Notepad ++ Portable (5.3.1)

9 posts / 0 new
Last post
Bart.S
Offline
Last seen: 1 month 2 weeks ago
Developer
Joined: 2008-07-23 07:56
[Fixed] Notepad ++ Portable (5.3.1)
  • Typo in Notepad++Portable.nsi, line 278: StrCpy $APPLANGUAGE "BRAZILILAN_PORTUGUESE"
    Yeah, I really love automatic language switching and the many many bugs (mostly comparing apples and oranges) Wink
  • If you use the Notepad++Portable.ini, Notepad++Portable won't run on Win 95,98,Me. IMHO, drop ansi-support completely or not. Actually, users who disabled the splash (for example) aren't supported.
  • $DEFAULTLOCATION ???. if not default location, user is on their own. Why? You use everywhere relative paths. So the user rename a folder and he's on his own. No more MoveSettings, UpdateLocations, SetLanguage ...
    I guess it would be better to remove the Ini-Settings completely than to leave the user alone.
  • PortableApps.comInstallerCustom.nsh, line 11, should be:
    Rename "$INSTDIR\Data\settings\plugins\NPPTextFX" "$INSTDIR\Data\settings\plugins\Config\tidy" ;preserve custom tidy settings
  • Why removing "App\Notepad++\plugins\ComparePlugin.dll" (PortableApps.comInstallerConfig.nsh, line 173)? After an upgrade you have to reinstall the ComparePlugin.
Chris Morgan
Chris Morgan's picture
Offline
Last seen: 8 years 11 months ago
Joined: 2007-04-15 21:08
Line 189

I also decided to get to the bottom of this issue with Notepad++ Portable 5.3.1!

		StrCmp $DEFAULTLOCATION "true" "" CheckRecoveryFiles ;=== if not default location, user is on their own

This looks suspicious. It should be going to MoveSettings. However, this shouldn't be the issue that we're looking for. Self: look harder!

I am a Christian and a developer and moderator here.

“A soft answer turns away wrath, but a harsh word stirs up anger.” – Proverbs 15:1

John T. Haller
John T. Haller's picture
Offline
Last seen: 1 hour 11 min ago
AdminDeveloperModeratorTranslator
Joined: 2005-11-28 22:21
Honestly

Bart.S, is it possible for you to make a bug report without adding snide comments and harping on issues that have already been debated and decided? I honestly don't care if you don't like one of the decisions that have been debated and decided. You were in the minority on those. You were actually the only one arguing your personal point of view. Everyone else disagreed and you were overruled. Let it go. If you're going to help, help.

The default location comment (which for those reading along is in the friggin code) is because if you're using an INI and moving things around, DefaultData won't be in a known location. We're not gonna add another INI option to find it. Advanced users just have to run it once before moving stuff around. Honestly, it's a comment in the code. And no, I'm not gonna add additional INI options to find DefaultData in a non-standard layout, it's unnecessary.

Sometimes, the impossible can become possible, if you're awesome!

Bart.S
Offline
Last seen: 1 month 2 weeks ago
Developer
Joined: 2008-07-23 07:56
Honestly,

John, read my report again, review your code, think (that's important) and then do whatever you want. Fix the bugs or not, I really don't care, but they are real (and Chris confirmed the $DEFAULTLOCATION bug)!
It seems to me that constructive criticism isn't welcome here, so I'll stop. No more bug reports by Bart.S!

Happy Easter! Smile

Zach Thibeau
Zach Thibeau's picture
Offline
Last seen: 1 year 7 months ago
Developer
Joined: 2006-05-26 12:08
your bug reports are fine but

your bug reports are fine but it looks like you are throwing too much sarcasm (at least by me that is what it is looking like) and it seems that you were doing it too much in your posts that's all, just lighten up on the sarcasm a little and this shouldn't happen.

your friendly neighbourhood moderator Zach Thibeau

John T. Haller
John T. Haller's picture
Offline
Last seen: 1 hour 11 min ago
AdminDeveloperModeratorTranslator
Joined: 2005-11-28 22:21
Big Difference

Did you see me write that the bug wasn't real or wouldn't be worked on? No. I said that the part about INI users being on their own about default settings would remain, as it should. If there were no bug, the subject of the post would have been changed.

Let's review. You've so sarcastically praised the bugginess of language switching (I can't count how many times now), you've sarcastically asked me to remove the INI and now you're accusing me of not thinking.

A bug report includes what was done, the actual result, the expected result, your system info, a code snippet if possible, etc. It doesn't include snide comments, or putting down developers, or bringing up unrelated stuff you don't like. If you are capable of dong that, great, please do. If not, please leave.

Sometimes, the impossible can become possible, if you're awesome!

Chris Morgan
Chris Morgan's picture
Offline
Last seen: 8 years 11 months ago
Joined: 2007-04-15 21:08
Also I didn't confirm the bug

What I said was that the command was going to the wrong place (skipping the moving of settings to the application directory). That wasn't what Bart.S was complaining about with that line.

You're completely right in your comments, John.

I am a Christian and a developer and moderator here.

“A soft answer turns away wrath, but a harsh word stirs up anger.” – Proverbs 15:1

Bart.S
Offline
Last seen: 1 month 2 weeks ago
Developer
Joined: 2008-07-23 07:56
Misunderstood

John, did you see me write remove the INI? No. I wrote there's a bug in that $DEFAULTLOCATION part. And with your code comment "if not default location, user is on their own" it looked like that's by design. I wrote removing the INI-Settings (Settingsdirectory and ProgramDirectory, subject of this point was/is locations) would be better than leaving users alone, that's all. No sarcasm!

JTHI said that the part about INI users being on their own about default settings would remain,

Alright, that's true and that's why I wrote my reply. It's obvious that even the advanced user, after running it once, is left alone. The settings won't be moved, adjusted, but they will be deleted everytime (in case &DEFAULTLOCATION=false). And that if you don't change the driveletter/pc too.
And when you look at the code, you'll see that immediately. So with that knowledge, your first comment is completely off-topic. John, you need arguments when discussing, no untrue statements and insults.

No offence John, really! And it wasn't my intention to put down developers. I appreciate all the work you guys do here. Just wanted to contribute.

Chris MorganAlso I didn't confirm the bug. What I said was that the command was going to the wrong place (skipping the moving of settings to the application directory).

Huh, I'm confused. "No more MoveSettings, UpdateLocations, SetLanguage ... " is the same as "skipping the moving of settings to the application directory". Skipping 100 lines of code, to be exactly.

Btw: Guys, don't read too much between the lines. Most users here aren't english natives, so you are often misinterpreting their intentions.

John T. Haller
John T. Haller's picture
Offline
Last seen: 1 hour 11 min ago
AdminDeveloperModeratorTranslator
Joined: 2005-11-28 22:21
Fixed in 5.4.2

- Brazilian Portuguese language switch fixed
- Use of INI doesn't disable switching to ANSI mode on Win9x
- Custom tidy settings properly preserved
- Compare plugin no longer removed (we'd followed the Notepad++ installer's lead on this but the plugin has been fixed since then)
- Use of INI now properly follows to MoveFiles and works with preserving settings
- Firewall message should no longer show on exit

Sometimes, the impossible can become possible, if you're awesome!

Log in or register to post comments