[Outdated] Eclipse Portable 3.5.1

I've been working in the IT business and I'd like to have working applications in any configuration. That's why my Portable Apps are installed in a folder with spaces in folder name. If an application doesn't handle this use case properly, it always shows rapidly

use single quotes outside, double inside.

Double quotes are fine within ExecWaits. I usually do something like this:

ExecWait `"$PROGRAMDIRECTORY\$PROGRAMEXECUTABLE" -vm "$JAVAPATH" $Parameters $ADDITIONALPARAMETERS`

Unless of course Eclipse doesn't like em. But ExecWait is fine with the above.

First of all, I want to compliment you. This is a very good release. Alas, I did find somethings, so let's cover them:

• Code Issues
• Meh issues (i.e. mostly just some styling)
• Quite offten, you have something along the lines of:

   . . . Code . . . .
  Goto Location
  (and immediately underneath)
  Location:

  You don't need to do that. You can, but you don't need to. See lines 106\108, 118, etc.

• You *shouldn't need* to actively define your variables as global. It happens automatically.
• You have launcher version as 3.5.1.0. Usually, the lancher version sorta follows John's. I think we're somewhere in 1.7. But, if you feel the numbering is correct in refering to the changes in the launcher, I won't argure with you
• You need to clear out the splash stuff. Use this code:
  

  newadvsplash::stop /WAIT

  after, TheEnd:

• You really should fix this . . .
• You have registry.nsh included, but I didn't see you use it anywhere. IF you use it, keep it in, else, remove it. You're added to the program more then it needs to be.

• Help.html
• Eclipses's homepage will be Portableapps.com\EclipsePortable. You can send it to that, not app\dev\EclipsePortable.
• Looks nice

• App
• DefaultData
• Why nothing in here?. I think you generate most of you settings yourself, which if that's the way you need to do it is fine.
• Appinfo
• If you're not using any ergistry settings, why are you exporting them in installer.ini? Otherwise, it looks fine.
• Don't need 24x24 icons in appicon

• Data being left
• Nope

All in all, a very good test. I'm very please at the way this has turned out. Fix those issues that were marked to be fixed, and consider the other ones. You don't have to change those, but you can if you would like.
Do that, post it, I'll give it the quick once over and I'll stamp it with my seal. (I has to make a seal? Hmm . . . .)

wemake sure JOhn KNOW THAT THIS IS READY!

I've filed a request that this be not released until we get the SVN issue sorted out in the Universal Launcher. There's too big a security liability with it at the moment. I'll get back to you on it when I get somewhere with it (step one: wait for John's first release of PAUL).