[Closed] Sumatra PDF: language switching broken?

Sumatra uses a completely esoteric settings format. It isn't a config, INI, XML or similar. So, it can't be done in PAL. And we can't reference it within the file. We can only do a replace. So, if you ever switch it within Sumatra, it will stay switched unless you happen to sync it up to the platform again manually. There is no other fix.

I'd suggest last closed. Rather than another custom launcher though, how about switching it to PAL as well? If you don't mind, that is.

EDIT: Hey, I went through and tested the effects of this patch Language by Language (rather than simply trusting the lists like I had at first), and I've updated the Patch accordingly.

OK,
So if started from the Platform the Language will be set with the "-lang ¿?" argument (Documented Here & Here) to match, if it's a Language which the Platform & Sumatra use different codes to identify (I based my list of Discrepancies on This [SumatraPDF] & This [PA.cPlatform]) it will fix it; and if a Language which SumatraPDF doesn't support is selected, or it is not launched from the Platform (or if the Platform is set not to ‘use this Language for all PortableApps’) it will not pass the -lang argument (meaning that SumatraPDF will simply remember what Language it was set to at the time of it's last exit.)

BTW: What is the preferred method of posting patches?
Do you like “Place the following in Source.File, between Lines X & Y”?
Or do you prefer .diff’s?
[.diff’s being like the following:]

--- X:/PortableApps/SumatraPDFPortable/Other/Source/SumatraPDFPortableU.nsi	Wed Apr 25 15:22:48 2012
+++ X:/PortableApps/SumatraPDFPortable/Other/Source/LangFix-SumatraPDFPortableU.nsi	Tue Oct 02 20:29:48 2012
@@ -208,13 +208,64 @@
 		WriteINIStr "$SETTINGSDIRECTORY\${NAME}Settings.ini" "${NAME}Settings" "LastDrive" "$CURRENTDRIVE"
 		WriteINIStr "$SETTINGSDIRECTORY\${NAME}Settings.ini" "${NAME}Settings" "LastPortableAppsRoot" "$strPortableAppsRoot"
 		
-	;GetCurrentLanguage
-		${ReadINIStrWithDefault} $0 "$SETTINGSDIRECTORY\${NAME}Settings.ini" "${NAME}Settings" "LastLanguage" "en"
-		ReadEnvStr $1 "PortableApps.comLocaleCode2"
-		StrCmp $1 "" LaunchNow ;If no env var, skip it
-		StrCmp $0 $1 LaunchNow ;If the same, skip it
-			${ReplaceInFile} "$PROGRAMDIRECTORY\sumatrapdfprefs.dat" 'UILanguage2:$0' 'UILanguage2:$1'
-			WriteINIStr "$SETTINGSDIRECTORY\${NAME}Settings.ini" "${NAME}Settings" "LastLanguage" "$1"
+	;SetCurrentLanguage
+		ReadEnvStr $0 "PortableApps.comLocaleglibc"
+		StrCmp $0 "" LaunchNow CheckForLocaleCodeDiscrepancies ;If no env var, skip it, else check for LocaleCode Discrepancies
+
+		;LocaleCode Discrepancy fixers
+	SetLangToBelarusian:	;This is in the list, so it's here, but it's not actually supported, however since it doesn't break anything I'd leave it for future use.
+		StrCpy $0 `by`
+		Goto SetLocale
+	SetLangToChineseSimple:
+		StrCpy $0 `cn`
+		Goto SetLocale
+	SetLangToChineseTraditional:
+		StrCpy $0 `tw`
+		Goto SetLocale
+	SetLangToCzech:
+		StrCpy $0 `cz`
+		Goto SetLocale
+	SetLangToDanish:
+		StrCpy $0 `dk`
+		Goto SetLocale
+	SetLangToEnglish:
+		StrCpy $0 `en` ;For both en_US & en_GB
+		Goto SetLocale
+	SetLangToKorean:
+		StrCpy $0 `kr`
+		Goto SetLocale
+	SetLangToMalay:	;Apparently Malay is also listed but not supported, Leaving it for future use.
+		StrCpy $0 `my`
+		Goto SetLocale
+	SetLangToNorwegian:
+		StrCpy $0 `no`
+		Goto SetLocale
+	SetLangToPortugueseBR:
+		StrCpy $0 `br` ;Portuguese is pt, Brasilian Portuguese is br
+		Goto SetLocale
+	SetLangToVietnamese:
+		StrCpy $0 `vn` ;Fix Vietnamese
+		Goto SetLocale
+
+	CheckForLocaleCodeDiscrepancies:
+		StrCmp $0 `be` SetLangToBelarusian ;Check for Belarusian
+		StrCmp $0 `zh_CN` SetLangToChineseSimple ;Check for SimpChinese
+		StrCmp $0 `zh_TW` SetLangToChineseTraditional ;Check for TradChinese
+		StrCmp $0 `cs` SetLangToCzech ;Check for Czech
+		StrCmp $0 `da` SetLangToDanish ;Check for Danish
+		StrCmp $0 `en_GB` SetLangToEnglish ;Check for EnglishGB
+		StrCmp $0 `en_US` SetLangToEnglish ;Check for EnglishUS
+		StrCmp $0 `ko` SetLangToKorean ;Check for Korean
+		StrCmp $0 `ms` SetLangToMalay ;Check for Malay
+		StrCmp $0 `nb` SetLangToNorwegian ;Check for Norwegian
+		StrCmp $0 `pt_BR` SetLangToPortugueseBR ;Check for PortugueseBR
+		StrCmp $0 `vi` SetLangToVietnamese ;Check for Vietnamese
+	;If the Platform is set to a language that SumatraPDF doesn't support, skip setting it (i.e. use what's still saved from last exit of SumatraPDF)
+		StrCmp $0 `lv` LaunchNow ;Latvian isn't supported
+		StrCmp $0 `lb` LaunchNow ;Luxembourgish isn't supported
+		StrCmp $0 `su` LaunchNow ;Luxembourgish isn't supported
+	SetLocale:
+		StrCpy $EXECSTRING `$EXECSTRING -lang $0`
 
 	LaunchNow:
 		ExecWait $EXECSTRING

P.S.: I chose Localeglibc because it had Portuguese (Portuguese [pt] & Brasilian [br/pt_BR] variants) & Chinese (Simple [cn/zh/zh_CN] & Traditional [tw/zh/zh_TW])separate, and already had Arabic [ar/ar-sa] & SpanishInternational [es/es-mx] as SumatraPDF requires them.

and with this Patch you no-longer need to have "LastLanguage=en" in the DefaultData\settings\SumatraPDFPortableSettings.ini.
(or do you not need that file at all any more?)