PicPick Portable portablization

I've started this thread to continue discussion on the portablization of PicPick, so as to keep the Outdated Apps thread clean. The following is an explanation in detail of everything occurring in the launcher.ini, Custom.nsh and installer.ini when I updated the package for 3.2.7.

PicPickPortable.ini

[Launch]
ProgramExecutable=picpick\picpick.exe
DirectoryMoveOK=yes
SupportsUNC=yes

This section has not been touched.

[Activate]
Registry=true

[RegistryValueBackUpDelete]
1="HKCU\SOFTWARE\Microsoft\Windows\CurrentVersion\Run\PicPick Start"

The addition of this section ensures that from this point on, if the user checks the "Run program at Startup" checkbox in the app's settings, that this setting does not affect the base computer. Of course, if this setting has previously been checked, the registry value may still be in the registry, but as we do not mess with pre-existing registry settings, we'll leave it be. It won't, however, affect the portable app, as it gets backed up.

[FilesMove]
picpick.ini=%PAL:AppDir%\picpick

[Language]
Base=%PortableApps.comLocaleName%
CheckIfExists=%PAL:AppDir%\picpick\language\%PAL:LanguageCustom%.ini
DefaultIfNotExists=English

These two sections have not been touched.

[LanguageStrings] 	
SimpChinese=Chinese Simplified	
TradChinese=Chinese Traditional
Farsi=Persian
Portuguese=Portuguese (Portugal)
PortugueseBR=Portuguese	
SerbianLatin=Serbian_Latin

In order to ensure all languages recognized by PAL & PAP are used automatically, all languages that are displayed differently in the app than in their Language:Base equivalent have been added in this section. This is necessary due to the way languages are handled in PAL. See here for those details.

[LanguageFile]
Type=INI
File=%PAL:DataDir%\picpick.ini
Section=Setting
Key=Language2

[FileWrite1]
Type=INI
File=%PAL:DataDir%\picpick.ini
Section=Setting
Key=Language2
Value=%PAL:LanguageCustom%

[FileWrite2]
Type=Replace
File=%PAL:DataDir%\picpick.ini
Find=%PAL:LastDrive%%PAL:LastPackagePartialDir%\
Replace=%PAL:Drive%%PAL:PackagePartialDir%\

[FileWrite3]
Type=Replace
File=%PAL:DataDir%\picpick.ini
Find=%PAL:LastPortableAppsBaseDir%\
Replace=%PAL:PortableAppsBaseDir%\

[FileWrite4]
Type=Replace
File=%PAL:DataDir%\picpick.ini
Find=%PAL:LastDrive%\
Replace=%PAL:Drive%\

With the exception of a change in N-numbers, these particular sections have been left untouched.

[FileWrite5]
Type=INI
File=%PAL:DataDir%\picpick.ini
Section=Setting
Key=CheckUpdate
Value=0

This section has been added to ensure that the checkupdate setting is off on every run of the app. This works in conjunction with the original setting in the same manner, as per DefaultData.

Finally, the following FileWrite section was deleted, as it is not necessary to write the value every launch. This value is auto-written by the app on install, as well as on upgrade.

 [FileWrite2]
Type=ConfigWrite
File=%PAL:DataDir%\picpick.ini
Entry='FirstRun='
Value=3260

Custom.nsh

${SegmentFile}
Var CustomFirstRunDone

This section sets the varialbe indicated, for use later in the file.

${SegmentPrePrimary}
	ReadINIStr $0 "$EXEDIR\Data\settings\PicPickPortableSettings.ini" "FirstRun" "Done"
	${If} $0 != true
		ClearErrors
		MessageBox MB_ICONINFORMATION|MB_OK "FOR PERSONAL(HOME) USE ONLY$\r$\n$\r$\nThis version is provided as freeware for only personal use. In this case, you are granted the right to use this program free of charge. Otherwise, you need to pay for a license for commercial use."
	StrCpy $CustomFirstRunDone false
	${Else}
		StrCpy $CustomFirstRunDone true
	${EndIf}
!macroend

The section does a number of things. First, it reads for the value of "FirstRun" in PicPickPortableSettings.ini. Next, If that value is not "true", and only then, It displays the MessageBox as required by the publisher, and sets the custom variable to "false".

Otherwise, if FirstRun is "true", it sets the custom variable to "true".

Note that this section happens prior to the app running.

${SegmentPost}
StrCmp  $CustomFirstRunDone "true" +2 0	
		WriteINIStr "$EXEDIR\Data\settings\PicPickPortableSettings.ini" "FirstRun" "Done" "true"
!macroend

This section compares the custom variable to "true". If they match, it does nothing. If, however, they do not, and the variable is then "false", It writes the "FirstRun" variable as "true" - meaning that the app has just been run for the first time, and the messagebox was displayed.

installer.ini

[Languages]
ENGLISH=true
BOSNIAN=true
BULGARIAN=true
CATALAN=true
CROATIAN=true
CZECH=true
DANISH=true
DUTCH=true
FARSI=true
FINNISH=true
FRENCH=true
GEORGIAN=true
GERMAN=true
GREEK=true
HEBREW=true
HUNGARIAN=true
INDONESIAN=true
ITALIAN=true
;JAPANESE=true
KOREAN=true
LITHUANIAN=true
POLISH=true
PORTUGUESE=true
PORTUGUESEBR=true
RUSSIAN=true
SERBIAN=true
SERBIANLATIN=true
SIMPCHINESE=true
SLOVAK=true
SLOVENIAN=true
SPANISH=true
SWEDISH=true
THAI=true
TRADCHINESE=true
TURKISH=true
UKRAINIAN=true
VIETNAMESE=true

This section ensures that the languages available in the installer are the same languages as in the app itself. This is to ensure that there is no confusion by users installing the app and having their preferred language available on install but not on running the app - They will either be available both times, or neither.

You'll note that I have excluded the PortableApps.comInstallerCustom.nsh. This is because, upon further discussion and testing, I've determined that the base app does exactly what that section was intended to do.

Unfortunately, it appears the app still shows the setting menu on first run after upgrade, no matter whether the firstrun value is 3270 or not.

[EDIT] Fixed launcher.INI language handling.