You are here

[Fixed] PA.c Installer 3.4 won't update PAF version

5 posts / 0 new
Last post
mwayne
Offline
Last seen: 14 hours 36 min ago
Developer
Joined: 2012-01-03 09:23
[Fixed] PA.c Installer 3.4 won't update PAF version

When switching from PAF 3.0 to 3.2 I noticed it changed the version in the appinfo.ini too. Now from 3.2/3.3 to 3.4 it won't change it. But it works from 3.0 to 3.4. It's because of line 482 in the InstallerWizard.nsi. I think the installer should always keep the PAF version accordingly to the one it's packaged with. Can we change it to $1 <="3.0" or just adding the missing versions.

Gord Caswell
Gord Caswell's picture
Offline
Last seen: 1 week 5 days ago
DeveloperModerator
Joined: 2008-07-24 18:46
>= 9.0 <= ${PORTABLEAPPS.COMFORMATVERSION}

What if we changed lines 478 to 482 inclusive (at least, until that block is no longer needed) to:

${If} $1 >= "0.90
${AndIf} $1 <=  ${PORTABLEAPPS.COMFORMATVERSION}

Possibly at the same time, what if we swapped lines 499 and 500? Move the version update out of that IF block entirely?

John T. Haller
John T. Haller's picture
Offline
Last seen: 1 hour 10 min ago
AdminDeveloperModeratorTranslator
Joined: 2005-11-28 22:21
No decimals

The comparison operators don't support decimals in NSIS IIRC. I'll just have to add the two missing ones for now.

Sometimes, the impossible can become possible, if you're awesome!

Bart.S
Offline
Last seen: 2 months 5 days ago
Developer
Joined: 2008-07-23 07:56
${VersionCompare}

How about ${VersionCompare}?

John T. Haller
John T. Haller's picture
Offline
Last seen: 1 hour 10 min ago
AdminDeveloperModeratorTranslator
Joined: 2005-11-28 22:21
Fixed in 3.4.1

This is fixed in 3.4.1. It's supposed to match the format version, not the installer version, and it's supposed to specifically upgrade certain things from certain versions. There were no issues with upgrades from 3.2 or 3.3, just that the version wasn't updated.

Sometimes, the impossible can become possible, if you're awesome!

Log in or register to post comments