GameSuite Portable Dev Test 1 (Testers Required)

I really like that.
Nice and easy games.
One thing though: In the readme, it says Kuhl instead of Kühl
And you could put Wraithdu in as Copyright holder too as he helped me a lot cleaning the code.

solo doesn´t start with the launcher, the other games do. Anyway, great work...

Good job, other than the error mentioned above everything looks great. You may want to find another name though. The name Game Suite, especially on this site, may imply to some users that it is another version of the PortableApps Suite that is specific to games. Maybe something like STGamePack (ST stands for Simon Tatham). or just GamePack or something like that. Or since the "About" for each game says "from Simon Tatham's Portable Puzzle Collection" maybe calling it PuzzleCollectionPortable would be good.

Where do you see the royalty info?

I have a package of this with a menu based off the NSIS menu (the one that links to help, compiled, etc) that I never posted though I can't recall why. If there is a royalties requirement, then it can't be considered OSI.

Where would I go to request this same program, but certain games in it? Like Tetris, Bejeweled, Collapse, Frogger, etc. Yea, I know those games are Open Source or anything but I do know that some of them have alternatives. Bricks is an alternative to Tetris, for example.

I found a few things you can fix in the source.

1. remove the StrRep.nsh include
2. remove the extra OutFile line
3. **Optional** remove the Page instfiles

If you do this, you'll have to change how you change the install button text -
a. add !include WinMessages.nsh
b. add these 2 lines to the top of your nsDialogs page function -

GetDlgItem $0 $HWNDPARENT 1 ; install button
SendMessage $0 ${WM_SETTEXT} 0 "STR:Start!" ; change text

You have to do it that way cause the InstallButtonText command doesn't seem to work if you don't have the instfiles page. If you remove that page, you can ignore the compiler warning.

4. fix the +4 ==> +3

I think you and Simeon had a great start on this little launcher, so I thought I'd give you a little bump ahead. I made the following changes -

1. renamed to GamePack (from your to-do list)
2. removed sleep times, as they are unnecessary and just slow the thing down, and changed the relative jumps to compensate
3. added a button to run the games while leaving the launcher open
4. removed the Cancel button, as it is now redundant
5. fixed the run code - you want to put the BM_GETSTATE in it's own register (or variable) instead of overwriting each game variable, because they hold the checkbox control's HWND (handle). If you overwrite it, you can't ever check its state again without restarting the launcher. Since I added the Run button, I had to change it.

If you paste this in a decent editor (N++ or SciTE) you can seem my comments. Feel free to use all/part/none of it as you see fit

;Copyright 2007 Simeon Kühl and Digitxp

;This software is OSI Certified Open Source Software.
;OSI Certified is a certification mark of the Open Source Initiative.

;This program is free software; you can redistribute it and/or
;modify it under the terms of the GNU General Public License
;as published by the Free Software Foundation; either version 2
;of the License, or (at your option) any later version.

;This program is distributed in the hope that it will be useful,
;but WITHOUT ANY WARRANTY; without even the implied warranty of
;MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
;GNU General Public License for more details.

;You should have received a copy of the GNU General Public License
;along with this program; if not, write to the Free Software
;Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.

!define APPNAME "GamePack"
!define VER "0.9.0.0"
!define WEBSITE "PortableApps.com/DevelopmentTest"
!define DEFAULTAPPDIR "Games"
!define NAME "GamePackPortable"
!define PORTABLEAPPNAME "GamePack Portable"

RequestExecutionLevel user
Icon "..\..\App\AppInfo\Appicon.ico"
;=== Program Details
Name "${PORTABLEAPPNAME}"
OutFile "..\..\${NAME}.exe"
Caption "${PORTABLEAPPNAME} | PortableApps.com"
BrandingText /TRIMRIGHT "${PORTABLEAPPNAME} v${VER}"
VIProductVersion "${VER}"
VIAddVersionKey ProductName "${NAME}"
VIAddVersionKey Comments "Allows a collection of games to be run from a removable drive. For additional details, visit ${WEBSITE}"
VIAddVersionKey CompanyName "PortableApps.com"
VIAddVersionKey LegalCopyright "Portableapps.com and Contributors"
VIAddVersionKey FileDescription "${PORTABLEAPPNAME}"
VIAddVersionKey FileVersion "${VER}"
VIAddVersionKey ProductVersion "${VER}"
VIAddVersionKey InternalName "${PORTABLEAPPNAME}"
VIAddVersionKey LegalTrademarks "PortableApps.com is a Trademark of Rare Ideas, LLC."
VIAddVersionKey OriginalFilename "${NAME}.exe"
CRCCheck On
WindowIcon On
AutoCloseWindow True
RequestExecutionLevel user

!include "nsDialogs.nsh"
!include "WinMessages.nsh"

Page custom nsDialogsPage ;nsDialogsPageLeave ; 

I suggest also downloading and including this help file in your package. Place it in the same directory as all the game executables, and the help options will appear in each game's help menu.

http://www.chiark.greenend.org.uk/~sgtatham/puzzles/puzzles.chm

Despite a few minor issues (mostly some control deals... but that's on the non-portable end), things are looking very good.

What other games would you add? It may be best to keep this specific pack limited to the games made by Simon Tatham. Also, as suggested above, add in the help files.

This is a great pack digitxp, thanks for setting it up, and great job on the multi-launcher Simeon.

I would suggest however, upgrading the multi-launcher to use the Modern-UI code, it will make it look better, and maybe use a radio button instead of a check box, it's not very likely that a user will want to open and run several games at once.

Here's the MUI2 coded version. Biggest difference is the UI is bigger, so more room for more games.

;Copyright 2007 Simeon Kühl and Digitxp

;This software is OSI Certified Open Source Software.
;OSI Certified is a certification mark of the Open Source Initiative.

;This program is free software; you can redistribute it and/or
;modify it under the terms of the GNU General Public License
;as published by the Free Software Foundation; either version 2
;of the License, or (at your option) any later version.

;This program is distributed in the hope that it will be useful,
;but WITHOUT ANY WARRANTY; without even the implied warranty of
;MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
;GNU General Public License for more details.

;You should have received a copy of the GNU General Public License
;along with this program; if not, write to the Free Software
;Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.

!define APPNAME "GamePack"
!define VER "0.9.2.0"
!define WEBSITE "PortableApps.com/DevelopmentTest"
!define DEFAULTAPPDIR "Games"
!define NAME "GamePackPortable"
!define PORTABLEAPPNAME "GamePack Portable"

SetDatablockOptimize on
SetCompress force
SetCompressor /SOLID /FINAL lzma

Icon "..\..\App\AppInfo\Appicon.ico"
;=== Program Details
Name "${PORTABLEAPPNAME}"
OutFile "..\..\${NAME}.exe"
Caption "${PORTABLEAPPNAME} | PortableApps.com"
BrandingText /TRIMRIGHT "${PORTABLEAPPNAME} v${VER}"
VIProductVersion "${VER}"
VIAddVersionKey ProductName "${NAME}"
VIAddVersionKey Comments "Allows a collection of games to be run from a removable drive. For additional details, visit ${WEBSITE}"
VIAddVersionKey CompanyName "PortableApps.com"
VIAddVersionKey LegalCopyright "Portableapps.com and Contributors"
VIAddVersionKey FileDescription "${PORTABLEAPPNAME}"
VIAddVersionKey FileVersion "${VER}"
VIAddVersionKey ProductVersion "${VER}"
VIAddVersionKey InternalName "${PORTABLEAPPNAME}"
VIAddVersionKey LegalTrademarks "PortableApps.com is a Trademark of Rare Ideas, LLC."
VIAddVersionKey OriginalFilename "${NAME}.exe"

RequestExecutionLevel user
CRCCheck On
WindowIcon On
AutoCloseWindow True
RequestExecutionLevel user
XPStyle on

!include MUI2.nsh
!include WinMessages.nsh

!define MUI_ICON "..\..\App\AppInfo\appicon.ico"

Page custom nsDialogsPage

!insertmacro MUI_LANGUAGE "English"

;custom page language strings
LangString PAGE_TITLE ${LANG_ENGLISH} "Welcome to GamePackPortable"
LangString PAGE_SUBTITLE ${LANG_ENGLISH} "Choose some games and click Run..."

;=== Variables
Var BlackBox
Var Bridges
Var Cube
Var Dominosa
Var Fifteen
Var Filling
Var Flip
Var Galaxies
Var Guess
Var Inertia
Var Lightup
Var Loopy
Var Map
Var Mines
Var Pegs
Var Sixteen
Var Slant
Var Solo
Var Tents
Var Twiddle
Var Unequal
Var Untangle

Var RunButton

Function nsDialogsPage
	!insertmacro MUI_HEADER_TEXT $(PAGE_TITLE) $(PAGE_SUBTITLE)
	
	GetDlgItem $0 $HWNDPARENT 2 ; cancel button
	SendMessage $0 ${WM_SETTEXT} 0 "STR:Close" ; change text
	GetDlgItem $0 $HWNDPARENT 1 ; install button
	EnableWindow $0 0 ; disable install button
	ShowWindow $0 ${SW_HIDE} ; hide install button
	
	nsDialogs::Create /NOUNLOAD 1018
	${NSD_CreateCheckbox} 0 10 20% 8u BlackBox
	Pop $BlackBox
	${NSD_CreateCheckbox} 0 30 20% 8u Bridges
	Pop $Bridges
	${NSD_CreateCheckbox} 0 50 20% 8u Cube
	Pop $Cube
	${NSD_CreateCheckbox} 0 70 20% 8u Dominosa
	Pop $Dominosa
	${NSD_CreateCheckbox} 0 90 20% 8u Fifteen
	Pop $Fifteen
	${NSD_CreateCheckbox} 0 110 20% 8u Filling
	Pop $Filling
	${NSD_CreateCheckbox} 0 130 20% 8u Flip
	Pop $Flip
	${NSD_CreateCheckbox} 0 150 20% 8u Galaxies
	Pop $Galaxies
	${NSD_CreateCheckbox} 0 170 20% 8u Guess
	Pop $Guess
	${NSD_CreateCheckbox} 0 190 20% 8u Inertia
	Pop $Inertia
	${NSD_CreateCheckbox} 110 10 20% 8u LightUp
	Pop $Lightup
	${NSD_CreateCheckbox} 110 30 20% 8u Loopy
	Pop $Loopy
	${NSD_CreateCheckbox} 110 50 20% 8u Map
	Pop $Map
	${NSD_CreateCheckbox} 110 70 20% 8u Mines
	Pop $Mines
	${NSD_CreateCheckbox} 110 90 20% 8u Pegs
	Pop $Pegs
	${NSD_CreateCheckbox} 110 110 20% 8u Sixteen
	Pop $Sixteen
	${NSD_CreateCheckbox} 110 130 20% 8u Slant
	Pop $Slant
	${NSD_CreateCheckbox} 110 150 20% 8u Solo
	Pop $Solo
	${NSD_CreateCheckbox} 110 170 20% 8u Tents
	Pop $Tents
	${NSD_CreateCheckbox} 110 190 20% 8u Twiddle
	Pop $Twiddle
	${NSD_CreateCheckbox} 220 10 20% 8u Unequal
	Pop $Unequal
	${NSD_CreateCheckbox} 220 30 20% 8u Untangle
	Pop $Untangle
	
	; *** Run button w/ notification
	${NSD_CreateButton} 387 205 60 14u "Run!"
	Pop $RunButton
	${NSD_OnClick} $RunButton nsRunProgs ; calls user function nsRunProgs when clicked
	${NSD_SetFocus} $RunButton ; sets focus to button
	
	nsDialogs::Show
FunctionEnd

Function nsRunProgs
	Pop $0
	SendMessage $BlackBox ${BM_GETSTATE} 0 0 $1
		StrCmp $1 "1" "" +2
		Exec "$EXEDIR\App\Games\BlackBox.exe"
	SendMessage $Bridges ${BM_GETSTATE} 0 0 $1
		StrCmp $1 "1" "" +2
		Exec "$EXEDIR\App\Games\Bridges.exe"
	SendMessage $Cube ${BM_GETSTATE} 0 0 $1
		StrCmp $1 "1" "" +2
		Exec "$EXEDIR\App\Games\Cube.exe"
	SendMessage $Dominosa ${BM_GETSTATE} 0 0 $1
		StrCmp $1 "1" "" +2
		Exec "$EXEDIR\App\Games\Dominosa.exe"
	SendMessage $Fifteen ${BM_GETSTATE} 0 0 $1
		StrCmp $1 "1" "" +2
		Exec "$EXEDIR\App\Games\Fifteen.exe"
	SendMessage $Filling ${BM_GETSTATE} 0 0 $1
		StrCmp $1 "1" "" +2
		Exec "$EXEDIR\App\Games\Filling.exe"
	SendMessage $Flip ${BM_GETSTATE} 0 0 $1
		StrCmp $1 "1" "" +2
		Exec "$EXEDIR\App\Games\Flip.exe"
	SendMessage $Galaxies ${BM_GETSTATE} 0 0 $1
		StrCmp $1 "1" "" +2
		Exec "$EXEDIR\App\Games\Galaxies.exe"
	SendMessage $Guess ${BM_GETSTATE} 0 0 $1
		StrCmp $1 "1" "" +2
		Exec "$EXEDIR\App\Games\Guess.exe"
	SendMessage $Inertia ${BM_GETSTATE} 0 0 $1
		StrCmp $1 "1" "" +2
		Exec "$EXEDIR\App\Games\Inertia.exe"
	SendMessage $LightUp ${BM_GETSTATE} 0 0 $1
		StrCmp $1 "1" "" +2
		Exec "$EXEDIR\App\Games\LightUp.exe"
	SendMessage $Loopy ${BM_GETSTATE} 0 0 $1
		StrCmp $1 "1" "" +2
		Exec "$EXEDIR\App\Games\Loopy.exe"
	SendMessage $Map ${BM_GETSTATE} 0 0 $1
		StrCmp $1 "1" "" +2
		Exec "$EXEDIR\App\Games\Map.exe"
	SendMessage $Mines ${BM_GETSTATE} 0 0 $1
		StrCmp $1 "1" "" +2
		Exec "$EXEDIR\App\Games\Mines.exe"
	SendMessage $Pegs ${BM_GETSTATE} 0 0 $1
		StrCmp $1 "1" "" +2
		Exec "$EXEDIR\App\Games\Pegs.exe"
	SendMessage $Sixteen ${BM_GETSTATE} 0 0 $1
		StrCmp $1 "1" "" +2
		Exec "$EXEDIR\App\Games\Sixteen.exe"
	SendMessage $Slant ${BM_GETSTATE} 0 0 $1
		StrCmp $1 "1" "" +2
		Exec "$EXEDIR\App\Games\Slant.exe"
	SendMessage $Solo ${BM_GETSTATE} 0 0 $1
		StrCmp $1 "1" "" +2
		Exec "$EXEDIR\App\Games\Solo.exe"
	SendMessage $Tents ${BM_GETSTATE} 0 0 $1
		StrCmp $1 "1" "" +2
		Exec "$EXEDIR\App\Games\Tents.exe"
	SendMessage $Twiddle ${BM_GETSTATE} 0 0 $1
		StrCmp $1 "1" "" +2
		Exec "$EXEDIR\App\Games\Twiddle.exe"
	SendMessage $Unequal ${BM_GETSTATE} 0 0 $1
		StrCmp $1 "1" "" +2
		Exec "$EXEDIR\App\Games\Unequal.exe"
	SendMessage $Untangle ${BM_GETSTATE} 0 0 $1
		StrCmp $1 "1" "" +2
		Exec "$EXEDIR\App\Games\Untangle.exe"
FunctionEnd

Section
SectionEnd

digitxp, you should really update this and get things ready to go, the scripts that wraithdu and mecki77 fixed up for you are great, it should be a simple update. Remember to give them credit too.

It can be compressed EXEs with UPX.