You are here

How do i submit some patch for Portable Firefox?

7 posts / 0 new
Last post
hobbyscripter
Offline
Last seen: 13 years 3 months ago
Joined: 2005-12-09 11:01
How do i submit some patch for Portable Firefox?

Hi,
i'd like to ask, "How do i submit some patch for Portable Firefox?". i've written some patch to fix the problem of Chinese BIG5 Character, a kind of NON-ASCII Character. i'd like to submit it. How do i do that? Thanks.

John T. Haller
John T. Haller's picture
Online
Last seen: 54 min 14 sec ago
AdminDeveloperModeratorTranslator
Joined: 2005-11-28 22:21
Development pages not up yet...

I haven't gotten the development section up yet within here, so post it within the Portable Firefox Support forum. Since it's just code, you should be able to post it within a forum message.

I'm looking forward to it. If it works as expected, I'll use it in the other launchers as well.

Regards,
John

Sometimes, the impossible can become possible, if you're awesome!

hobbyscripter
Offline
Last seen: 13 years 3 months ago
Joined: 2005-12-09 11:01
Looking forward to the Development Pages

Unforunately, my solution to the Chinese BIG5 Character uses NSIS Code as well as plugin. So, it will be inconvenient to put them in the forum message without attachment(C Compiler is needed). i'll just wait for the Development Pages. Thanks for your reply.

Regards,
Hobbyscripter

John T. Haller
John T. Haller's picture
Online
Last seen: 54 min 14 sec ago
AdminDeveloperModeratorTranslator
Joined: 2005-11-28 22:21
Email it

In that case, just email it to the contact address here and I'll get it from there.

(Future note to others, please don't send binaries/code unrequested. Just had to say it, because you know it'll happen.)

Sometimes, the impossible can become possible, if you're awesome!

hobbyscripter
Offline
Last seen: 13 years 3 months ago
Joined: 2005-12-09 11:01
[Patch] A new version Chinese BIG5 Support

Hi,
i have written a new version of the code.
Now no NSIS plugins needed, but only a library write by me.
And the limit of the string length that the library can convert is only limited to NSIS, how long the string that NSIS support and how long this library support.
And fix the problem with "GetParameters" Function (that the old version cause)

The patch file for PortableFirefox.nsi
***************************code*************************
31a32,35
> ;=== include the Dual Char Library (added by hobbyscripter)
> ; for the dual charactar support
> !include "DualChar.lib.nsh"
>
54a59
> Var PROFILEDIRECTORYFIREFOXFORMAT
67a73
> Var SKIPUSEFIREFOXFORMATPATH
121c127,129
ReadINIStr $0 "$INIPATH\${NAME}.ini" "${NAME}"

"SkipUseFirefoxFormatPath"
> StrCpy "$SKIPUSEFIREFOXFORMATPATH" $0
>
138a147
> StrCpy "$SKIPUSEFIREFOXFORMATPATH" "false"
222a232,242
>
> ;=== Chinese BIG5 Characters convert area (added by

hobbyscripter)
> StrCmp $SKIPUSEFIREFOXFORMATPATH "true"

UseOrginalPath 0
> Push $PROFILEDIRECTORY
> Call DualCharToSingleChar
> Pop $PROFILEDIRECTORYFIREFOXFORMAT
> Goto EndOfConvert
> UseOrginalPath:
> StrCpy $PROFILEDIRECTORYFIREFOXFORMAT

$PROFILEDIRECTORY
> EndOfConvert:
>
258c278
StrCpy $4 `

c:baseURL="jar:file:///$PROFILEDIRECTORYFIREFOXFORMAT/$5` ; edited

by hobbyscripter, for the Chinese BIG5 Characters support
262c282
StrCpy $4 `

c:baseURL="file:///$PROFILEDIRECTORYFIREFOXFORMAT/$5` ; edited by

hobbyscripter, for the Chinese BIG5 Characters support
293c313
StrCpy $4 `

NC:path="$PROFILEDIRECTORYFIREFOXFORMAT\$5` ;=== the adjusted

extension path ; edited by hobbyscripter, for the Chinese BIG5

Characters support
386a407,412
> ;=== Change $CMDLINE into Single Charactar (added by

Hobbyscripter)
> ; in order to fix the Dual Charactar Problem
> Push $CMDLINE
> Call DualCharToSingleChar
> Pop $CMDLINE
> ;=== Change $CMDLINE into Single Charactar End
413a440,446
> ;=== Recover $R0 into Dual Charactar (added by Hobbyscripter)
> ; in order not to change $CMDLINE.
> ; note: this function would only convert the words if there

exists escape charactar "%" in the string
> Push $R0
> Call SingleCharToDualChar
> Pop $R0
> ;=== Recover $R0 into Dual Charactar End
416a450,456
> ;=== Recover $CMDLINE into Dual Charactar (added by

Hobbyscripter)
> ; in order not to change $CMDLINE.
> ; note: this function would only convert the words if there

exists escape charactar "%" in the string
> Push $CMDLINE
> Call SingleCharToDualChar
> Pop $CMDLINE
> ;=== Recover $CMDLINE into Dual Charactar End
***************************/code*************************

Regards,
Hobbyscripter

PS. You can get Native patch.exe from

http://unxutils.sourceforge.net/

hobbyscripter
Offline
Last seen: 13 years 3 months ago
Joined: 2005-12-09 11:01
DualChar.lib.nsh

The code of the library i used(please save it as
"DualChar.lib.nsh"):

http://s61.yousendit.com/d.aspx?id=02WRT5O7OT7M23M3923B8YKW64

Rob Loach
Rob Loach's picture
Offline
Last seen: 14 years 1 month ago
Developer
Joined: 2005-12-09 17:29
Loading Plugins Dynamically

While we're on the discussion of patches to the NSIS code, I thought I'd just submit a small patch that would let you dynamically load plugins into NSIS.

I've noticed that a lot of these applications use the Advanced Splashscreen Plugin and have asked developers to manually add it to NSIS. By putting the plugin's DLL in the script's directory and calling:

!addplugindir ".\"

NSIS will look for alternative plugins in the script's directory. This will mean that developers won't have to manually add the splashscreen plugin into their NSIS installation. Just put the plugin's DLL into the script directory, and away we go. Enjoy!

Rob Loach [Website] [Projects] [Blog]

Topic locked