You are here

FirefoxPortable.ini + launcher bug

8 posts / 0 new
Last post
wraithdu
Offline
Last seen: 11 years 4 days ago
Developer
Joined: 2007-06-27 20:22
FirefoxPortable.ini + launcher bug

This has probably been around for a while. According to the launcher source, these three INI params are required -

"${APPNAME}Directory"
"ProfileDirectory"
"SettingsDirectory"

So try using this INI -

[FirefoxPortable]
FirefoxDirectory=App\firefox
ProfileDirectory=Data\profile
SettingsDirectory=Data\settings
# PluginsDirectory=Data\plugins
# FirefoxExecutable=firefox.exe
# AdditionalParameters=
# LocalHomepage=
DisableSplashScreen=true
# AllowMultipleInstances=false
# DisableIntelligentStart=false
# SkipChromeFix=false
# SkipCompregFix=false
# RunLocally=false

In this case, both the PluginsDirectory and FirefoxExecutable are set to blank by the launcher. This will make the launcher fail with an error. If you add the executable line, then the plugins directory will be empty and I'm sure something will go wrong.

The PluginsDirectory and FirefoxExecutable should probably be made required params as well.

John T. Haller
John T. Haller's picture
Online
Last seen: 18 min 13 sec ago
AdminDeveloperModeratorTranslator
Joined: 2005-11-28 22:21
not a bug

it's not a bug. all entries are required. always been that way.

Sometimes, the impossible can become possible, if you're awesome!

Bruce Pascoe
Offline
Last seen: 12 years 5 months ago
Joined: 2006-01-15 16:14
...

I still think it should be optional which entries to use. Shouldn't really be hard--the Windows .ini APIs all accept default values.

All-entries-required wreaks havoc thanks to custom path support, as well. Even when all I want to do is disable the splash, I have to fill out every entry, including the paths--meaning DefaultData (and possibly other PortableApps features) get disabled because the launcher thinks I'm using custom paths.

Shawn Faucher
Shawn Faucher's picture
Offline
Last seen: 14 years 10 months ago
Developer
Joined: 2007-10-23 22:14
Have to agree

I have to agree here. Maybe at one point in the past requiring ini entries made sense but as the spec is now it would be easy to use defaults for non-specified entries just as is done with no ini.

formerly rayven01

wraithdu
Offline
Last seen: 11 years 4 days ago
Developer
Joined: 2007-06-27 20:22
Huh, I was just going off

Huh, I was just going off the launcher source.

;=== Read the parameters from the INI file
ReadINIStr $0 "$INIPATH\${NAME}.ini" "${NAME}" "${APPNAME}Directory"
StrCpy $PROGRAMDIRECTORY "$EXEDIR\$0"
ReadINIStr $0 "$INIPATH\${NAME}.ini" "${NAME}" "ProfileDirectory"
StrCpy $PROFILEDIRECTORY "$EXEDIR\$0"
ReadINIStr $0 "$INIPATH\${NAME}.ini" "${NAME}" "SettingsDirectory"
StrCpy $SETTINGSDIRECTORY "$EXEDIR\$0"

;=== Check that the [b]above required parameters[/b] are present
IfErrors NoINI

If what you're saying is true, then if any INI parameters are missing the INI sould be skipped and the default values used.

haustin
Offline
Last seen: 12 years 9 months ago
Joined: 2007-09-19 17:59
Fix already proposed...

I described the problem and proposed a fix here.

Incidentally, the fix also allows for a global PortableApps.ini (for things like DisableSplashScreen).

-hea

wraithdu
Offline
Last seen: 11 years 4 days ago
Developer
Joined: 2007-06-27 20:22
I thought I remembered

I thought I remembered something like this problem mentioned before. But I couldn't remember exactly where, and I thought it only had to do with the "Live Firefox" mode of operation.

haustin
Offline
Last seen: 12 years 9 months ago
Joined: 2007-09-19 17:59
Probably my fault.

The original topic was about two minor copy-and-paste errors in the Mozilla scripts (one forced the default Data\settings regardless of INI config, the other only affected "people who have plugins in Data\Plugins and are running in live mode").

I followed up with the Code suggestion that addressed the problem you describe and updated my original post to reference it.

I guess the relevance of the latter got lost in the process. -hea

Log in or register to post comments