You are here

Needed space calculation

10 posts / 0 new
Last post
r.andom
r.andom's picture
Offline
Last seen: 13 years 5 months ago
Joined: 2007-11-12 15:11
Needed space calculation

I ran into this issue when trying to install the OpenOffice.org Portable 2.4.1 release. This issue affects not only OOoP but OOoP is the biggest application. So it's the first one where you run into this problem.

The installer calculates the needed space on the flash drive. If there isn't enough space there you can't go on with the installation (button is greyed out). But the calculation doesn't take into account if a previous release of OOoP (that will be overwritten) is installed on the drive in question. The difference between wrong and right calculation is about 250 MB(!) in this case. So it happened to me that the installer didn't allow me to install the new version.

I see two options to solve this issue:

1. The clean one: When calculating the needed space on the flash drive the installer has to check whether there is a previous version of the app and how much space it takes. This amount has to be subtracted from the needed space for the new version.

2. Not so clean but maybe easier: If the calculation (done as is) tells there isn't enough space offer a button to ignore this information and go on with the installation.

Simeon
Simeon's picture
Offline
Last seen: 7 years 3 months ago
DeveloperTranslator
Joined: 2006-09-25 15:15
I noticed that too

and posted it back then.

"What about Love?" - "Overrated. Biochemically no different than eating large quantities of chocolate." - Al Pacino in The Devils Advocate

r.andom
r.andom's picture
Offline
Last seen: 13 years 5 months ago
Joined: 2007-11-12 15:11
No solution yet

Thanks for the hint but there wasn't a solution yet.

John T. Haller
John T. Haller's picture
Offline
Last seen: 1 hour 28 min ago
AdminDeveloperModerator
Joined: 2005-11-28 22:21
Bug

It would appear to be a bug in the current PortableApps.com Installer. I thought this had made it into the last release. I'll double-check and post a test version of OO for folks to ensure it works as expected.

Sometimes, the impossible can become possible, if you're awesome!

MarkoMLM
MarkoMLM's picture
Offline
Last seen: 6 years 2 months ago
DeveloperTranslator
Joined: 2006-01-16 04:08
Please let me know if there is really a bug in the installer ...

... in order to get the fix in the next OpenOffice.org Portable release.
(The space calculation is the same as in 2.4 release without changes.)
A Rev2 could be done if this is needed.

Paid for Software more or less?
What You need is OSS!

Simeon
Simeon's picture
Offline
Last seen: 7 years 3 months ago
DeveloperTranslator
Joined: 2006-09-25 15:15
there is

2.4 had the same issue the current release has.

"What about Love?" - "Overrated. Biochemically no different than eating large quantities of chocolate." - Al Pacino in The Devils Advocate

John T. Haller
John T. Haller's picture
Offline
Last seen: 1 hour 28 min ago
AdminDeveloperModerator
Joined: 2005-11-28 22:21
Tomorrow

I'll have a fix for the installer for you tomorrow so we can get the next OpenOffice.org beta out.

Sometimes, the impossible can become possible, if you're awesome!

digitxp
digitxp's picture
Offline
Last seen: 10 years 4 months ago
Joined: 2007-11-03 18:33
Actually,

I checked the code and it seems only the data directory is subtracted.
Just simply change that code so that the whole $INSTDIR is subtracted.

Insert original signature here with Greasemonkey Script.

Chris Morgan
Chris Morgan's picture
Offline
Last seen: 6 years 7 months ago
Joined: 2007-04-15 21:08
I think you're wrong...

What it actually does in CheckInstallerError:
$3 contains the total drive's free space
$4 contains the size of $INSTDIR
$7 contains the "apparent" free space, accounting for an upgrade.

So:
$7 is set to $3 + $4 (that is, the space we would have on the drive if we remove the entire OpenOfficePortable directory)
Then it sets $4 to the size of $INSTDIR\Data
$7 has $4 removed from it (that is, we won't delete the Data directory, so take that space out of the free space count)

Thus:
The amount of free space that it [should] claim to have when upgrading is: Real free space + Old copy's space, except for Data directory.

This is correct. I'm not sure why it's working. (btw, my brother Ben just tried upgrading to ff3 and experienced the same issue at the same time as I was typing this!)

I am a Christian and a developer and moderator here.

“A soft answer turns away wrath, but a harsh word stirs up anger.” – Proverbs 15:1

John T. Haller
John T. Haller's picture
Offline
Last seen: 1 hour 28 min ago
AdminDeveloperModerator
Joined: 2005-11-28 22:21
Fixed

This has been fixed in 0.9.9.4. See here:
https://portableapps.com/node/14520

Sometimes, the impossible can become possible, if you're awesome!

Log in or register to post comments