You are here

AdditionalParameters not working in VLCPortable.nsi

6 posts / 0 new
Last post
rpmohn
Offline
Last seen: 13 years 4 months ago
Joined: 2008-04-11 14:54
AdditionalParameters not working in VLCPortable.nsi

The AdditionalParameters var set in VLCPortable.ini doesn't seem to work. I checked the VLCPortable.nsi file and the var is set, but never used. I believe it should be passed at the end of the $EXECSTRING (on lines 188 & 192 of my .nsi file). Haven't looked into how to compile .nsi files yet so could someone please fix and post?

Thanks! -Ross

rpmohn
Offline
Last seen: 13 years 4 months ago
Joined: 2008-04-11 14:54
OK, I compiled the fix for

OK, I compiled the fix for myself and it works! Please make this change in the next upgrade to VLC.

Thanks for the great PortableApps platform!

-Ross

Zach Thibeau
Zach Thibeau's picture
Offline
Last seen: 8 years 10 months ago
Developer
Joined: 2006-05-26 12:08
you actually enter the

you actually enter the additional parameters into vlcportable.ini in the additionalparameters part there. and then move the ini file to where the vlcportable.exe is located.

your friendly neighbourhood moderator Zach Thibeau

rpmohn
Offline
Last seen: 13 years 4 months ago
Joined: 2008-04-11 14:54
$Additional Parameters variable not used

Yes, except that it doesn't work in the current release because the $AdditionalParameters variable isn't passed to $EXECSTRING in the VLCPortable.nsi file! Here's the patch that fixes the problem. I hope it is included in the next release!

--- VLCPortable.000.nsi 2008-12-31 11:51:38.000000000 -0500
+++ VLCPortable.nsi     2008-12-30 10:50:16.000000000 -0500
@@ -185,11 +185,11 @@ Section "Main"
                StrCmp "'$0'" "''" "" LaunchProgramParameters
 
                ;=== No parameters
-               StrCpy $EXECSTRING `"$PROGRAMDIRECTORY\$PROGRAMEXECUTABLE" --vlm-conf "$SETTINGSDIRECTORY\vlcrc" --no-plugins-cache --config "$SETTINGSDIRECTORY\vlcrc"`
+               StrCpy $EXECSTRING `"$PROGRAMDIRECTORY\$PROGRAMEXECUTABLE" --vlm-conf "$SETTINGSDIRECTORY\vlcrc" --no-plugins-cache --config "$SETTINGSDIRECTORY\vlcrc" $ADDITIONALPARAMETERS`
                Goto AdjustSettings
 
        LaunchProgramParameters:
-               StrCpy $EXECSTRING `"$PROGRAMDIRECTORY\$PROGRAMEXECUTABLE" $0 --vlm-conf "$SETTINGSDIRECTORY\vlcrc" --no-plugins-cache --config "$SETTINGSDIRECTORY\vlcrc"`
+               StrCpy $EXECSTRING `"$PROGRAMDIRECTORY\$PROGRAMEXECUTABLE" $0 --vlm-conf "$SETTINGSDIRECTORY\vlcrc" --no-plugins-cache --config "$SETTINGSDIRECTORY\vlcrc" $ADDITIONALPARAMETERS`
        
        AdjustSettings:
                StrCmp $SECONDARYLAUNCH "true" LaunchAndClose

Cheers! -Ross

Morphinity
Offline
Last seen: 8 years 6 months ago
Joined: 2009-01-11 16:47
What's the problem with the NSIS compiler?

I've just made the changes to the code, but compliler doesn't seem to process the source. It doesn't know what to do with newadvsplash function. What is the right version of compiler for this case? Or the problem is with libs?

Bart.S
Offline
Last seen: 1 week 2 days ago
Developer
Joined: 2008-07-23 07:56
Plugins

You need some NSIS-Plugins to compile the code. (e.g. NewAdvSplash plugin).

Log in or register to post comments