You are here

Quoting Posts

27 posts / 0 new
Last post
John T. Haller
John T. Haller's picture
Online
Last seen: 21 min 59 sec ago
AdminDeveloperModeratorTranslator
Joined: 2005-11-28 22:21
Quoting Posts

RELOAD THIS PAGE TO ENSURE YOU GET THE UPDATED CSS FILE

I'm working on adding the ability to more easily quote what others have posted in the forums. It'll probably be implemented as an add-on allowing you to click a "Quote" button below a user's post. But appearance-wise, it'll look like:

John T. Haller I heard that a number of people like quotes in forums and things like that. Do you like the ability to do pretty quotes like this?

This is accomplished using the following code in the post:

<blockquote><cite>John T. Haller</cite> I heard that a number of people
like quotes in forums and things like that.  Do you like the ability to
do pretty quotes like this?</blockquote>

Thoughts?

PS - You may need to reload or wait to see the style as the CSS files are cached.

Zach Thibeau
Zach Thibeau's picture
Offline
Last seen: 1 year 6 months ago
Developer
Joined: 2006-05-26 12:08
looks cool?

looks cool?

your friendly neighbourhood moderator Zach Thibeau

John T. Haller
John T. Haller's picture
Online
Last seen: 21 min 59 sec ago
AdminDeveloperModeratorTranslator
Joined: 2005-11-28 22:21
cite

You forgot the CITE part to indicate who you're quoting

Sometimes, the impossible can become possible, if you're awesome!

Geek45
Geek45's picture
Offline
Last seen: 14 years 4 months ago
Joined: 2008-09-11 22:20
Geek45 This looks pretty

Geek45 This looks pretty cool.

!!

roamer
roamer's picture
Offline
Last seen: 14 years 5 months ago
Joined: 2007-02-21 16:01
I think

It would be a nice addition, expecially when a topic takes more than one page, or is just long. That way people remember what the reply is about.

OliverK> you don't live on a cow
IRC: It brings out the best in all of us...Especially when tired.

Steve Lamerton
Steve Lamerton's picture
Offline
Last seen: 10 years 7 months ago
Developer
Joined: 2005-12-10 15:22
I like!

roamer I agree, much easier!

Shame it doesnt show up in the preview though.

John T. Haller
John T. Haller's picture
Online
Last seen: 21 min 59 sec ago
AdminDeveloperModeratorTranslator
Joined: 2005-11-28 22:21
Reload

You may need to reload on the edit page itself once to be able to see it as the CSS is cached.

Sometimes, the impossible can become possible, if you're awesome!

reepicheep
Offline
Last seen: 11 years 10 months ago
Joined: 2008-04-29 11:32
Yup

John T. Haller ... Do you like the ability to do pretty quotes like this?

Definitely. When the reply chain gets long/deep it is difficult to work out exactly what new replies relate to. Using a quote feature would make clear what is going on.

John T. Haller
John T. Haller's picture
Online
Last seen: 21 min 59 sec ago
AdminDeveloperModeratorTranslator
Joined: 2005-11-28 22:21
Tweaked

I just tweaked the close quote to line up better, especially for quotes on a single line. You may need to reload to see it.

Sometimes, the impossible can become possible, if you're awesome!

BrianAll
Offline
Last seen: 5 years 10 months ago
Joined: 2008-02-13 13:44
Coool. :-)

Coool. Smile

John T. Haller...especially for quotes on a single line.

This looks nice, I think it's great to organise it like this. Not only does this clarify what one is talking about, it standardizes the formatting for a reply so it's easy to tell what the reply is. I've seen so many different ways of formatting a reply, from @Username to any array of strong, em, and code tags. This is really nice!

John T. Haller
John T. Haller's picture
Online
Last seen: 21 min 59 sec ago
AdminDeveloperModeratorTranslator
Joined: 2005-11-28 22:21
Yeah

Yeah, it was getting difficult in some threads and I wanted something standardized and easy. That's why I based it on the tags that it should be semantically (blockquote and cite). It's not quite there yet. I don't like the outline or background yet, though.

Sometimes, the impossible can become possible, if you're awesome!

Kevin Porter
Kevin Porter's picture
Offline
Last seen: 10 years 2 months ago
Developer
Joined: 2007-01-10 19:25
Good

Sounds like a good idea to me, and seems to work okay. Smile

"Programming today is a race between software engineers striving to build bigger and better idiot-proof programs, and the Universe trying to produce bigger and better idiots. So far, the Universe is winning." - Rick Cook

kai.inouye
kai.inouye's picture
Offline
Last seen: 12 years 5 months ago
Developer
Joined: 2008-02-03 20:12
Cool!

kai.inouyeC-o-o-l! Biggrin

José Pedro Arvela
Offline
Last seen: 5 years 4 months ago
Joined: 2007-07-10 07:29
Yay!

PTMblogger Nice, you followed my advice, and it is looking pretty sweet! I am sooooooo happy with this I might give you a help if you need. You know my email from my profile page (because you are the admin Biggrin )

I wish I had my pidgin logs so I could provide that day's quote Biggrin

Blue is everything.

Tim Clark
Tim Clark's picture
Offline
Last seen: 13 years 1 month ago
Joined: 2006-06-18 13:55
I think if you look thru this

I think if you look thru this whole topic and envision all the topics looking like this you will get an idea of how I feel about it.

John T. Haller Thoughts?

Tim

Things have got to get better, they can't get worse, or can they?

José Pedro Arvela
Offline
Last seen: 5 years 4 months ago
Joined: 2007-07-10 07:29
That is human nature

Tim, that is human nature, if someone doesn't have something, and even if that person doesn't want it, but didn't have it, and then they gave him that thing, he will want to use it.

IN this case people didn't have a method of posting quotes with several paragraphs (I still remember a post where i had to open and close some 3 or 4 cite tags Blum ). Now that people have it, they are crazy about it, and will want to use it. Luckily, they will only want to use it in here.

So this thread can be seen as a sandbox, that shows all most possible ways people will uses the blockquote tag, and this thread can actually allow John to troubleshoot in case it is needed.

EDIT: Also, one advice I give, is to use the src attribute in the cite element, so that the source is defined (there is no graphical change, but it is more correct).

Blue is everything.

Tim Clark
Tim Clark's picture
Offline
Last seen: 13 years 1 month ago
Joined: 2006-06-18 13:55
I think if you look thru this

ptmb Tim, that is human nature,...

Since I did not say how I feel about it I infer from your reply that you would not like like it if all topics started to look like this one Blum

Tim

Things have got to get better, they can't get worse, or can they?

José Pedro Arvela
Offline
Last seen: 5 years 4 months ago
Joined: 2007-07-10 07:29
What I meant...

What I meant is that, yes, it is annoying to see one thread with at least 1 blockquote on each comment, but what I meant is that people are trying it here, and will only use it abusively here.

Also, if you want, you can use the following CSS in firefox's addon stylish to make the blockquotes look normal:

@namespace url(http://www.w3.org/1999/xhtml);

@-moz-document domain("portableapps.com") {

blockquote {
background: none !important;
border: 0px solid !important;
margin: 12px 0 !important;
padding: 0 !important;
}

blockquote cite {
background: none !important;
font-size: 1em !important;
font-style: italic !important;
font-weight: normal !important;
padding: 0 !important;
}

blockquote p:first-child cite:first-child:after, blockquote cite:first-child:after {
content: " said: " open-quote !important;
}

blockquote p:last-child:after {
content: " " close-quote !important;
}

}

Some changes might be necessary while the blockquote styles are not final.

Blue is everything.

Ryan McCue
Ryan McCue's picture
Offline
Last seen: 14 years 7 months ago
Joined: 2006-01-06 21:27
Hmm.

John T. Haller I'm working on adding the ability to more easily quote what others have posted in the forums. It'll probably be implemented as an add-on allowing you to click a "Quote" button below a user's post.

I'd personally be in favour of being able to hit "reply", then select text and have an overlay with a quote button.

i.e. I hit reply. I select text. A small button overlay appears at the end of the selected text with a quote icon. I click this and it's automatically added to my post. I write a bit of a reply to this, then select some more text and repeat.

John T. Haller But appearance-wise, it'll look like:

John T. Haller I heard that a number of people like quotes in forums and things like that. Do you like the ability to do pretty quotes like this?

(Nested blockquotes don't look great, but they hardly ever do.) IMHO, the background and border should be scratched, and replaced with a thick left/right border. The quotation marks should be less noticable and more washed-out, as they are just visual guides, not actual content. The citation line should probably be styled differently too, perhaps as a right-aligned link to the user's profile, same text styling as the "Submitted by" line in normal comments. Something like:
"John T. Haller, ", where the ↩ links to the quoted comment.

John T. Haller This is accomplished using the following code in the post:

<blockquote><cite>John T. Haller</cite> I heard that a number of people
like quotes in forums and things like that.  Do you like the ability to
do pretty quotes like this?</blockquote>

That code looks OK, but I agree with ptmb that

ptmb [one should] use the src attribute in the cite element, so that the source is defined (there is no graphical change, but it is more correct).

</braindump>
And yes, this post looks awful, mostly because of the styling of the blockquotes.

"If you're not part of the solution, you're part of the precipitate."

José Pedro Arvela
Offline
Last seen: 5 years 4 months ago
Joined: 2007-07-10 07:29
Ryan McCue (Nested

Ryan McCue (Nested blockquotes don't look great, but they hardly ever do.) IMHO, the background and border should be scratched, and replaced with a thick left/right border. The quotation marks should be less noticeable and more washed-out, as they are just visual guides, not actual content.

I agree, actually, some CSS that might make them look better is replacing some of the properties, with the following ones:

blockquote {
background: transparent url(/sites/all/themes/portableapps2/images/close-quote.gif) no-repeat scroll right bottom;
border: 1px solid #EAEDF0;
border-left: 5px solid #EAEDF0;
padding: 0 32px 0 1em !important;
}
Ryan McCue The citation line should probably be styled differently too, perhaps as a right-aligned link to the user's profile, same text styling as the "Submitted by" line in normal comments.

Remember that sometimes not only users are quoted, so we should be sure that the styling is universal for any kind of quotes, like other places online, books, and so on.

I'd also like to inform that the current code for styling will make that all cite elements inside a blockquote are styled wrongly. For example:

User1 Then she said Hi!.

My advice for CSS3 capable browsers is to replace blockquote cite { ... } with blockquote p:first-child > cite:first-child, blockquote > cite:first-child { ... }.

In other browsers, some PHP or javascript to detect their capabilities and adding a special class to the first cite element is the ideal thing...

Regarding that a user may forget to provide a cite element, it would be a nice idea to provide some PHP to add a blank cite element when there is none on the beginning of the blockquote.

Also, in my opinion, when quoting other users on the forums, we should direct the scr attribute to the comment where they said that. For example:

<blockquote><cite src="https://portableapps.com/comment/reply/18069/111367#comment-111367">Ryan McCue</cite> (Nested blockquotes don't look great, but they hardly ever do.) IMHO, the background and border should be scratched, and replaced with a thick left/right border. The quotation marks should be less noticeable and more washed-out, as they are just visual guides, not actual content.</blockquote>

Blue is everything.

John T. Haller
John T. Haller's picture
Online
Last seen: 21 min 59 sec ago
AdminDeveloperModeratorTranslator
Joined: 2005-11-28 22:21
More of It

CITE should only really be used as we're intending and I don't think anyone has used it otherwise ever, really. It's not a tag people normally use in a forum. So I'm not gonna do a bunch of custom stuff around it. (Custom code we have to maintain ourselves = bad)

I answered the SRC attribute in my other post.

Sometimes, the impossible can become possible, if you're awesome!

José Pedro Arvela
Offline
Last seen: 5 years 4 months ago
Joined: 2007-07-10 07:29
Ok

I understand what you mean (although I'll be sad to have to use <em>""</em> for citations in blockquotes Blum ). So I wont be picky.

About the src attribute, I like the idea (but I'll still add the src attribute by myself while I can Biggrin ).

Blue is everything.

John T. Haller
John T. Haller's picture
Online
Last seen: 21 min 59 sec ago
AdminDeveloperModeratorTranslator
Joined: 2005-11-28 22:21
Some Of It

Yeah, I know, I wasn't yet done styling yet as I was just trying to get it to work first.

I see a few other forums use the simple borders on the sides, so we'll go with that. It looks much better. Especially with nested quotes.

I like the idea about styling the username like the Submitted by, so I've implemented that. I also added a colon after it to separate it with an :after tag, though I'm not sure I love it yet.

As for SRC that's more a part of the plugin and the quote plugin in Drupal does not do that by default though I can hack it to do so. I'll probably be hacking it to simplify it anyway as it, by default, uses a special filter and [quote] and other stuff and I'd rather not be married to it ongoing. By hacking it to use simple HTML tags, it'll just work even if we ditch it later. But since the SRC serves no purpose at all within current browsers, I think we're fine skipping it (no, I don't care if it's 'correct').

As far as linking back to the comment, it's pretty useless now as no one is gonna take the time to do it manually and when a user clicks quote at the moment, they're replying to the comment right above, so it's obvious what they're replying to. It's more for replying directly to certain bits. But it may serve a purpose in other instances... though it will unfortunately be manual, so maybe we should have a standardized style, maybe something like:

Ryan McCue (#)where the ↩ links to the quoted comment.

As for the whole selecting text and choosing what you're quoting, that's not gonna happen. Unless you want to write a custom Drupal module for it and support it for a minimum of a year.

Sometimes, the impossible can become possible, if you're awesome!

Tim Clark
Tim Clark's picture
Offline
Last seen: 13 years 1 month ago
Joined: 2006-06-18 13:55
As of 1:10pm CST 02/14/09

As of 1:10pm CST 02/14/09 I like the new implementation much better then the original. I could live with this Smile Thanks to Ryan for the idea.

John T. Haller I see a few other forums use the simple borders on the sides, so we'll go with that. It looks much better.

I note the date and time as I have no idea how this might look after the next implementation Wink

Tim

Things have got to get better, they can't get worse, or can they?

Tim Clark
Tim Clark's picture
Offline
Last seen: 13 years 1 month ago
Joined: 2006-06-18 13:55
As of 9:20pm CST 02/14/09

As of 9:20pm CST 02/14/09
I like it Less Sad

Something has changed, I think it's the big quote marks, but I'm not sure.

Tim

Things have got to get better, they can't get worse, or can they?

Tim Clark
Tim Clark's picture
Offline
Last seen: 13 years 1 month ago
Joined: 2006-06-18 13:55
As of 1:40pm CST 02/16/09

As of 1:40pm CST 02/19/09

I like it again, the big quote marks are once again gone Smile

Tim

Things have got to get better, they can't get worse, or can they?

Ryan McCue
Ryan McCue's picture
Offline
Last seen: 14 years 7 months ago
Joined: 2006-01-06 21:27
Sure.

John T. Haller (#) As for the whole selecting text and choosing what you're quoting, that's not gonna happen. Unless you want to write a custom Drupal module for it and support it for a minimum of a year.

I'm willing to do so and have plenty of time for it as well. I'll rewrite the quote plugin for you if you want too.

"If you're not part of the solution, you're part of the precipitate."

Log in or register to post comments