New: Capture2Text (Sep 26, 2023), Platform 26.2.1 (Sep 17, 2023)
450+ real apps (49GB), 1.1 billion downloads, Please donate.
Jack Haller, Advisor and Father of Our Founder, Has Passed Away
If I have Songbird installed locally, the portable version checks for crash reports and renames the folder to "Crash Reports-BackupBySongbirdPortable" (line 79).
The problem is that it gets left behind as it never renames it back to what it was on exit so it gets left behind.
I don't know how important these crash reports are and thus how serious this bug is.
Yes/no. The reports folder is renamed properly just not renamed back, so they aren't lost...I'll fix this for the next release.
The renamed Crash report folders still get left behind, although this time for a different reason:
It sets the variable CRASHREPORTSDIREXISTS to true if it finds a local Crash report folder. But in line 433 it says
StrCmp $CRASHREPORTSDIREXISTS "true" RemoveLocalFiles2
but I think it should be
StrCmp $CRASHREPORTSDIREXISTS "true" "" RemoveLocalFiles2
Thats because the StrCmp function is "str1 str2 jump_if_equal jump_if_not_equal" so it never removes the folder.
Nice work on it though!
I'm looking into it now.
***EDIT***
Thank you Simeon for pointing this out!
I have confirmed that this is a bug. I have fixed the code and will send John a revision. I will also post the link to the update shortly.
NOTE: This is NOT a critical bug, but one that needs to be fixed nonetheless. This will result in no data loss or configuration issues.
You can get Revision 2 here.
critical enough to warrant a revision?
I'd say no and just update the code for the next version...
That's what I was thinking, but I'll leave it up to John, it's fixed anyways, and I know how some people are about it. So the option is there if he decides to take it.
What do you guys think... worth doing a revision? We could post it just to get it out there. I know it's not critical, but it is a violation of the spec, so we should get it fixed up. I'm leaning toward revision, personally.
It's up to you John. You've got the revision and I've got the code updated on my end as well. The revision is out there should you want to go ahead with it.
This only happens if the existing PC has crash reports on it, correct? Otherwise, nothing happens?
Without a previous instance of the Crash Reports folder, there'll be no backup by Songbird, therefore no backup left behind by it. So this will only happen on PC's with instances of existing "Crash Reports" folders because of a local installation.
thats correct.
Visit the Community page
Join our forums
Follow us on BlueSky