You are here

Possible bug in PA Installer

5 posts / 0 new
Last post
beppegg
Offline
Last seen: 13 years 3 months ago
Joined: 2010-01-29 10:52
Possible bug in PA Installer

Hi all,

While I was working in portabilizing GrindStone, I've found a (possible) bug in the PA Installer: Grindstone installed itself in "%PROGRAMFILES%/Grindstone 2", and register its path in "HKLM\Software\Grindstone 2" (with spaces in the name). I've tried to use the option [CopyLocalFiles] section as following:

[CopyLocalFiles]
CopyLocalFiles=false
CopyFromRegPath=HKLM\Software\Grindstone 2
CopyFromRegKey=Install_Dir
CopyFromRegRemoveDirectories=0
CopyFromDirectory=%PROGRAMFILES%\GrindStone 2
CopyToDirectory=App\GrindStone 2

But generating the installer yields to the issue "{_If} expects 4 parameter, passed 5" in the line '{_If} $CopyFromRegPath = ""'. I suppose that's caused from the space between "Grindstone" and "2".

gluxon
gluxon's picture
Offline
Last seen: 3 years 10 months ago
Developer
Joined: 2008-06-21 19:26
Yeah, that's what seems to be

Yeah, that's what seems to be causing the problem.

Try putting quotes around "HKLM\Software\Grindstone 2".

Make sure CopyLocalFiles is true, or else it won't work at all.

Chris Morgan
Chris Morgan's picture
Offline
Last seen: 9 years 3 weeks ago
Joined: 2007-04-15 21:08
Yes

I found this bug and fixed it in my Installer repository, most of which will be going into the PortableApps.com Installer 1.0.1. (At that time the file was UTF-16LE and without a minor hg extension it detects that as binary, and I can't get it to apply online, so you don't get a diff.)

That this sort of problem had come back I found when my brother Jon went to build BPBible Portable 0.4.6 - one value in installer.ini which is normally "Multilingual" or "English" is in BPBible "With Resources", and that broke things, so I went through all the file and found a couple of others, including this one you're having trouble with.

I am a Christian and a developer and moderator here.

“A soft answer turns away wrath, but a harsh word stirs up anger.” – Proverbs 15:1

Simeon
Simeon's picture
Offline
Last seen: 9 years 9 months ago
DeveloperTranslator
Joined: 2006-09-25 15:15
1.0.1?

I think the latest version is 2.0.
Will there be 2 versions???

"What about Love?" - "Overrated. Biochemically no different than eating large quantities of chocolate." - Al Pacino in The Devils Advocate

Chris Morgan
Chris Morgan's picture
Offline
Last seen: 9 years 3 weeks ago
Joined: 2007-04-15 21:08
2.0.1

Sorry, I meant 2.0.1.

I am a Christian and a developer and moderator here.

“A soft answer turns away wrath, but a harsh word stirs up anger.” – Proverbs 15:1

Log in or register to post comments