You are here

[Won't Fix] PAL - If user updates from non-PAL portable app wo/Data\settings to PAL version, their data is wiped

7 posts / 0 new
Last post
The MAZZTer
The MAZZTer's picture
Offline
Last seen: 3 weeks 15 hours ago
Developer
Joined: 2006-11-17 15:31
[Won't Fix] PAL - If user updates from non-PAL portable app wo/Data\settings to PAL version, their data is wiped

Since PAL looks for Data\settings to determine whether or not to copy over the DefaultData, it can clobber existing data if that folder does not exist (because the old launcher did not use it).

In addition, if the user installs a PAL portable app and then sticks their own profile in without launching it, PAL will corrupt and/or wipe it with DefaultData.

I suggest a launcher INI entry be added for a directory/file to check for, instead of Data\settings, to determine if DefaultData needs to be copied. This would be whatever the author chose for the app's profile folder (Data\profile for Google Chrome Portable, Data\<APPNAMEPORTABLE> for others, maybe).

John T. Haller
John T. Haller's picture
Offline
Last seen: 3 hours 16 sec ago
AdminDeveloperModeratorTranslator
Joined: 2005-11-28 22:21
Second Bit

All apps that document the ability to copy your own settings in state that you must run the app at least once first (to setup the proper directory structures, etc), so that's not really a big deal.

The first bit can be worked around with some simple installer custom code to create Data\settings. Anytime you're upgrading an app from a custom launcher to PAL you're likely going to need custom code anyway, so I'm not sure if we really even need to worry about this bug.

Sometimes, the impossible can become possible, if you're awesome!

Chris Morgan
Chris Morgan's picture
Offline
Last seen: 7 years 1 month ago
Joined: 2007-04-15 21:08
Data\*.*

Seems to me it'd be better to check for ${FileExists} Data\*.*, which would then be checking that Data exists and is not empty.

I am a Christian and a developer and moderator here.

“A soft answer turns away wrath, but a harsh word stirs up anger.” – Proverbs 15:1

John T. Haller
John T. Haller's picture
Offline
Last seen: 3 hours 16 sec ago
AdminDeveloperModeratorTranslator
Joined: 2005-11-28 22:21
Installer Creates

The installer creates Data and will create an INI file within it if there is an EULA the user must agree to. Some installers (BPBible) place files within Data on install if the user optionally selects them.

Sometimes, the impossible can become possible, if you're awesome!

Chris Morgan
Chris Morgan's picture
Offline
Last seen: 7 years 1 month ago
Joined: 2007-04-15 21:08
Indeed

I was just analysing it before making the change and came across the PortableApps.comInstaller subdirectory which I had forgotten about. So I won't be changing it.

I am a Christian and a developer and moderator here.

“A soft answer turns away wrath, but a harsh word stirs up anger.” – Proverbs 15:1

The MAZZTer
The MAZZTer's picture
Offline
Last seen: 3 weeks 15 hours ago
Developer
Joined: 2006-11-17 15:31
Oh well. At least I think

Oh well. At least I think some mention should be made in the manual, I wiped out my work Chrome profile by accident. Sad My backup was old, but thank goodness for Chrome Sync.

Signature automatically removed for being too awesome.

John T. Haller
John T. Haller's picture
Offline
Last seen: 3 hours 16 sec ago
AdminDeveloperModeratorTranslator
Joined: 2005-11-28 22:21
Test?

Why would you be using a launcher and installer you are testing on your production copy of the app? Backups and test installs, my friend.

Sometimes, the impossible can become possible, if you're awesome!

Log in or register to post comments