You are here

[Fixed] Google Chrome launcher if jPortable installed

4 posts / 0 new
Last post
Karsonito
Offline
Last seen: 2 years 2 months ago
Joined: 2012-07-11 17:37
[Fixed] Google Chrome launcher if jPortable installed

The problem appears if Chrome Portable started with url in path + jPortable installed. In that case Chrome starting without Java plugin because $EXECSTRING is incorrect:
"chrome.exe" --user-data-dir="path\to\profile" --disk-cache-dir="path\to\Temp\GoogleChromePortable" -- http://goo.gl/ --extra-plugin-dir="path\to\CommonFiles\Java\bin\plugin2"

"-- http://goo.gl/" should follow last

I made a small patch:
--- GoogleChromePortable.nsi.bak 2012-02-17 17:36:40.000000000 +0200
+++ GoogleChromePortable.nsi.fix 2012-07-11 23:11:15.588451300 +0300
@@ -102,6 +102,7 @@
Var PROFILEDIRECTORY
Var SETTINGSDIRECTORY
Var ADDITIONALPARAMETERS
+Var URI
Var EXECSTRING
Var PROGRAMEXECUTABLE
!ifdef USEDEVSPLASH
@@ -653,10 +654,12 @@
StrCpy $1 ""
${EndIf}

+StrCpy $URI `$1 $0`
+
!ifdef CHROMESXSMODE
- StrCpy $EXECSTRING `"$PROGRAMDIRECTORY\$PROGRAMEXECUTABLE" --chrome-sxs --user-data-dir="$PROFILEDIRECTORY" $1 $0`
+ StrCpy $EXECSTRING `"$PROGRAMDIRECTORY\$PROGRAMEXECUTABLE" --chrome-sxs --user-data-dir="$PROFILEDIRECTORY"`
!else
- StrCpy $EXECSTRING `"$PROGRAMDIRECTORY\$PROGRAMEXECUTABLE" --user-data-dir="$PROFILEDIRECTORY" $1 $0`
+ StrCpy $EXECSTRING `"$PROGRAMDIRECTORY\$PROGRAMEXECUTABLE" --user-data-dir="$PROFILEDIRECTORY"`
!endif

${If} $UsePAMLanguage != "false"
@@ -701,6 +704,8 @@
StrCpy $EXECSTRING `$EXECSTRING $ADDITIONALPARAMETERS`
${EndIf}

+ StrCpy $EXECSTRING `$EXECSTRING $URI`
+
${If} $SECONDARYLAUNCH != "true"
${AndIf} $WAITFORPROGRAM == "true"
ExecWait $EXECSTRING

Please fix it in next release.

John T. Haller
John T. Haller's picture
Online
Last seen: 18 min 13 sec ago
AdminDeveloperModeratorTranslator
Joined: 2005-11-28 22:21
Fixed in Beta and Dev

I've fixed this in the 21.0.1180.41 Beta release. Could you please verify that it works as expected for you as well? And thank you for posting details of a fix! Smile

Update: It's fixed in the 22.0.1207.1 Dev release as well.

Sometimes, the impossible can become possible, if you're awesome!

Karsonito
Offline
Last seen: 2 years 2 months ago
Joined: 2012-07-11 17:37
All works fine! Thanks! BTW,

All works fine! Thanks!

BTW, may I ask you for correct KillProc plugin for NSIS?

John T. Haller
John T. Haller's picture
Online
Last seen: 18 min 13 sec ago
AdminDeveloperModeratorTranslator
Joined: 2005-11-28 22:21
Fixed in Stable

This is now fixed in stable as well with the 21.0.1180.60 release.

Sometimes, the impossible can become possible, if you're awesome!

Log in or register to post comments