You are here

Home » Forums » Support Forums » Office Apps Support

Error in the Sunbird Launcher ?

5 posts / 0 new
Topic locked
Last post
November 24, 2006 - 11:45pm
#1
tsyr2ko
Offline
Last seen: 15 years 1 month ago
Joined: 2006-11-24 23:21
Error in the Sunbird Launcher ?

I am looking in the SunbirdPortable.nsi and i think there is a problem in it.

At line 117, we have ReadEnvStr $APPDATAPATH "APPDATA"
And, after that, on line 198, there is something like this
IfFileExists "$APPDATA\Mozilla\Sunbird\*.*" CheckIfRunning

Assuming the syntax of ReadEnvStr
the Environment variable will be stored into $APPDATAPATH variable

So the line 198 (and some others near line 383) would be
IfFileExists "$APPDATAPATH\Mozilla\Sunbird\*.*" CheckIfRunning

No ?? Is this correct for you ??

Correct me if i'm wrong.

Top
November 25, 2006 - 2:17am
Ryan McCue
Ryan McCue's picture
Offline
Last seen: 12 years 7 months ago
Joined: 2006-01-06 21:27
Hmm

Sounds right.
----
Ryan McCue
Cube Games
Life is like a sewer. What you get out of it depends on what you put into it.
(Tom Lehrer)

"If you're not part of the solution, you're part of the precipitate."

Top
November 25, 2006 - 4:03am
(Reply to #2)
Steve Lamerton
Steve Lamerton's picture
Offline
Last seen: 8 years 8 months ago
Developer
Joined: 2005-12-10 15:22
Looks

like a bug to me.

EDIT: Although I think you can call $APPDATA straight off and it will give you the correct dir, so maybe the readenvstr line is unnecessary.

Yours

Steve Lamerton

The Liberta Project

Top
November 25, 2006 - 10:16am
(Reply to #3)
tsyr2ko
Offline
Last seen: 15 years 1 month ago
Joined: 2006-11-24 23:21
Right

Your right, there is a constant for $APPDATA, that's why the NSIS compiler
don't stop on errors.

It's not a important bug, just the ReadEnvStr line is obsolete

----
Sorry for my english, it's not my first language :/

--

Sorry for my english, it's not my first language :/

Top
November 26, 2006 - 12:21am
tsyr2ko
Offline
Last seen: 15 years 1 month ago
Joined: 2006-11-24 23:21
Another interrogation

I think it was not necessary to create a new topic for this, so i post here.

Into the CheckIfRunning label, it checks for multiple instances.

On line 207, a test with IfFileExists on file parent.lock is done
but , i think, not correctly implemented.

IfFileExists "$PROFILEDIRECTORY\parent.lock" "" WarnAnotherInstance
StrCpy $SECONDARYLAUNCH "true"
Goto RunProgram

If the file really exists, the jump would go to WarnAnotherInstance and not go to
on the bottom line.

For tests, i edit installer and delete the "" between file path and "WarnAnotherInstance"
and it works as it should be now.

--

Sorry for my english, it's not my first language :/

--

Sorry for my english, it's not my first language :/

Top
Topic locked