You are here

[Fixed] Legend of Edgar Save Game

11 posts / 0 new
Last post
PSkilton
PSkilton's picture
Offline
Last seen: 2 years 9 months ago
Joined: 2012-07-02 16:08
[Fixed] Legend of Edgar Save Game

Thanks for your work on The Legend of Edgar everybody! So far it is a very neat little platformer. I believe there is a bug with the saving game feature.

When I saved the game and return to the games main menu I am able to re-open the saved game, but if I close the app entirely and re-open to load the game it states "failed to load game." I have tried this with a new game save and got the same result.

I am running Windows 8.1.

Thanks!

All the best to you, John, on your recovery. Your work, along with all of the PA.c team is very appreciated.

Ken Herbert
Ken Herbert's picture
Offline
Last seen: 8 hours 2 min ago
DeveloperModerator
Joined: 2010-05-25 18:19
Thanks for the report

Thanks for the report, I'll check it out in a few hours when I get home from work.

Ken Herbert
Ken Herbert's picture
Offline
Last seen: 8 hours 2 min ago
DeveloperModerator
Joined: 2010-05-25 18:19
Horrible issue, but easily fixed

I had a spare couple of minutes at work and I found the issue and the fix for it, but unfortunately any savegames that you had are completely lost.

For some reason the command to move the savegame files is failing and is losing all of the saves in the process.

The incredibly easy fix for it is to open App\AppInfo\Launcher\TheLegendOfEdgarPortable.ini and switch lines 12 & 13 so the [FilesMove] section should look like this:

[FilesMove]
config=%PAL:AppDir%\Edgar
medals=%PAL:AppDir%\Edgar
pakdata=%PAL:AppDir%\Edgar
save*=%PAL:AppDir%\Edgar
saveheader=%PAL:AppDir%\Edgar

Note for John - It will be quicker for you to fix it on your end than it would be for me to do it and send it through and then you repackage again for the signatures etc. so I'll send an email with the required changes just to keep the system going.

The thing we have to wonder at is why this is an issue. I am assuming that for some reason PAL is moving onto the next command block instead of waiting and processing the wildcards for the savegame [FilesMove]. I'll try to make time to play with it in debug mode tonight to see if it is PAL that is falling down here or just a quirky race-condition in Edgar.

John T. Haller
John T. Haller's picture
Online
Last seen: 3 min 47 sec ago
AdminDeveloperModeratorTranslator
Joined: 2005-11-28 22:21
Gone?

Are the existing saves gone or just not being moved back and forth properly? save* should move saveheader as well, I think.

Sometimes, the impossible can become possible, if you're awesome!

Gord Caswell
Gord Caswell's picture
Offline
Last seen: 4 months 1 week ago
DeveloperModerator
Joined: 2008-07-24 18:46
Gone

The saveX files get deleted. After running with debug, it's obvious why:

FilesMove/PrePrimary (line 209.12.27.27): Matching files for P:\PortableApps\TheLegendOfEdgarPortable\App\Edgar\save* discovered, deleting P:\PortableApps\TheLegendOfEdgarPortable\Data\save*

The reason, of course, is that saveheader is moved first, and so matches the saveX criteria. There are two options to fix this.

  1. Keep the original order in FilesMove, and change * to ? [EDIT] As per the manual, ? matches a single character, so saveheader will never match it and cause failure, and there are only 10 save slots, starting with 0
  2. Remove the saveheader line, and keep save*, which covers the saveX files and the saveheader file.
Ken Herbert
Ken Herbert's picture
Offline
Last seen: 8 hours 2 min ago
DeveloperModerator
Joined: 2010-05-25 18:19
Thanks for the quick

Thanks for the quick diagnosis there, Gord. I've just gotten home from work and was about to look into it.

I'm inclined to go with more specific over less, so option 1 is my preference.

John T. Haller
John T. Haller's picture
Online
Last seen: 3 min 47 sec ago
AdminDeveloperModeratorTranslator
Joined: 2005-11-28 22:21
Two Digits?

Why have two lines when one would suffice? And can it be two digits instead of one for the save# files?

Sometimes, the impossible can become possible, if you're awesome!

Gord Caswell
Gord Caswell's picture
Offline
Last seen: 4 months 1 week ago
DeveloperModerator
Joined: 2008-07-24 18:46
single

My preference is for a single save* line as well.

As far as I can tell, the app only supports 10 saveslots, starting save0, so only a single digit is needed. If a second digit is needed as well, that'd complicate matters, as ? Is digit-specific. IE save? != save??

Ken Herbert
Ken Herbert's picture
Offline
Last seen: 8 hours 2 min ago
DeveloperModerator
Joined: 2010-05-25 18:19
Yeah, it only uses a single

Yeah, it only uses a single digit.

I was thinking more specific to limit the potential of breaking the base app in cases where other non-data files are added to the game later that also start with "save", but the likelihood of that happening (and me not noticing it) is slim-to-none anyway.

So save* it is then.

John T. Haller
John T. Haller's picture
Online
Last seen: 3 min 47 sec ago
AdminDeveloperModeratorTranslator
Joined: 2005-11-28 22:21
Fixed in Rev 2

This is fixed in The Legend of Edgar Portable 1.15-1 Rev 2. I did a quick-install 400K patch for platform users as well. Sorry about any inconvenience this bug caused.

Sometimes, the impossible can become possible, if you're awesome!

PSkilton
PSkilton's picture
Offline
Last seen: 2 years 9 months ago
Joined: 2012-07-02 16:08
Thanks!

Thanks for fixing this everybody! I didn't make too much progress in the game, so it's no problem Wink

Log in or register to post comments