You are here

[Fixed] Photofiltre and platform French-language handling

8 posts / 0 new
Last post
slolo
Offline
Last seen: 10 months 3 weeks ago
Joined: 2016-01-26 04:19
[Fixed] Photofiltre and platform French-language handling

Hello,

I am currently trying to get Photofiltre in french, so I have followed explanation on the app web page and change en to fr in PortableApps\PortableApps\PhotoFiltrePortable\Data\settings\PhotoFiltrePortableSettings.ini file (see below)

In file PortableApps\PortableApps\PhotoFiltrePortable\Data\settings\PhotoFiltrePortableSettings.ini:

[PhotoFiltrePortableSettings]
LastDrive=G:
LastDirectory=\PortableApps\PortableApps\PhotoFiltrePortable
Language=fr
[PortableApps.comLauncherLastRunEnvironment]
PAL:LastPortableAppsBaseDir=G:\

In file PortableApps\PhotoFiltrePortable\App\AppInfo\Launcher\PhotoFiltrePortable.ini:
[Language]
Base=%PortableApps.comLanguageCode%
CheckIfExists=%PAL:AppDir%\Photofiltre\Languages\Studio%PAL:LanguageCustom%
DefaultIfNotExists=en

The only way to get Photofiltre in french is to put DefaultIfNotExists=fr in PortableApps\PhotoFiltrePortable\App\AppInfo\Launcher\PhotoFiltrePortable.ini file

I tried with another language like spanish (es) but without success.

Anybody can confirm the behavior?

Thanks in advance and have a nice day.

[Edit: BUG tag added, title adjusted for bug tracker clarity - mod GC]

John T. Haller
John T. Haller's picture
Online
Last seen: 7 min 23 sec ago
AdminDeveloperModeratorTranslator
Joined: 2005-11-28 22:21
Working Here

It's working as expected here. Are you using this with the PortableApps.com Platform? If so, it should automatically switch to the language used by the platform. Are all the language files within PhotoFiltrePortable\App\PhotoFiltre\Languages?

Sometimes, the impossible can become possible, if you're awesome!

slolo
Offline
Last seen: 10 months 3 weeks ago
Joined: 2016-01-26 04:19
Hello,

Hello,

Thanks for your answer.
Yes, I am using it with PortableApps.com Platform (with language setting in French)

In folder PortableApps\PhotoFiltrePortable\App\PhotoFiltre\Languages I have folders named StudioXX (with XX corresponding to the language code) and inside these folders I have the corresponding .plg file (StudioXX.plg)

But there is no StudioFR folder and no StudioFR.plg file anywhere (probably because this software is written by a french guy)
I have switched PortableApps.com language to german and launched Photofiltre and it was in German.

I think the problem only occurs with French.

In custom.nsh file the french seems to be supported:
ReadEnvStr $0 PAL:LanguageCustom
${If} $0 == "fr"
Delete $EXEDIR\App\PhotoFiltre\Studio*.plg
Delete $EXEDIR\App\PhotoFiltre\PhotoFiltre7.htm
CopyFiles /SILENT "$EXEDIR\App\PhotoFiltre\Languages\help-fr\PhotoFiltre7.htm" "$EXEDIR\App\PhotoFiltre\"
Delete $EXEDIR\App\PhotoFiltre\PhotoMasque.htm
CopyFiles /SILENT "$EXEDIR\App\PhotoFiltre\Languages\help-fr\PhotoMasque.htm" "$EXEDIR\App\PhotoFiltre\"

But in my case, I always have the StudioEN.plg file copied in Photofiltre app folrder.
Any idea please?

slolo
Offline
Last seen: 10 months 3 weeks ago
Joined: 2016-01-26 04:19
Please, is there anyone can

Please, is there anyone can test with PortableApps Platform and French language in settings if Photofiltre is shown in french rather than english?

Thanks in advance and have a nice day.

Gord Caswell
Gord Caswell's picture
Offline
Last seen: 1 day 12 hours ago
DeveloperModerator
Joined: 2008-07-24 18:46
I can confirm, app-specific bug

I can confirm that the behaviour you mention occurs, only with French, and only when launched from the platform with "Use this language for all portable apps" checked. If you manually change the language in the file as noted in the instructions, and don't run from the platform, the language is changed as expected.

Please adjust the subject line of your original post by adding [BUG] at the beginning.
BUG tag added to original post.

As far as fixing the problem is concerned, The quick-fix is to do as you say and change DefaultIfNotExists from en to fr, however I don't think this is the correct way to handle, I think we'd be better off add a custom Pre segment to override the PAL:LanguageCustom Environment variable if the platform's language is French, and "always use" is set. Doing it in that segment would allow the existing FileWrite and custom PrePrimary to happen as expected.
See below for the fix. This can/should be added either in the next update or as a Revision.

John, or others, what're your thoughts?

${SegmentPre}
	ReadEnvStr $0 PortableApps.comLanguageCode
	ReadEnvStr $1 PAL:_IgnoreLanguage
	${If} $0 == "fr"
	${AndIf} $1 == false
		${SetEnvironmentVariable} PAL:LanguageCustom fr
	${EndIf}	
!macroend

[EDIT: Custom Pre section added. I have confirmed this fixes the bug.]

vf2nsr
vf2nsr's picture
Offline
Last seen: 6 years 1 month ago
Developer
Joined: 2010-02-13 17:10
FWIW

THink your fix is a good one Gord, no need ot fix entire platform at this point until we know if other affected.

“Be who you are and say what you feel because those who mind don't matter and those who matter don't mind.” Dr. Seuss

John T. Haller
John T. Haller's picture
Online
Last seen: 7 min 23 sec ago
AdminDeveloperModeratorTranslator
Joined: 2005-11-28 22:21
Fixed in 7.2.1 Rev 3

This is fixed in today's release. Thanks to Gord for the code.

Sometimes, the impossible can become possible, if you're awesome!

slolo
Offline
Last seen: 10 months 3 weeks ago
Joined: 2016-01-26 04:19
Thanks a lot for the fix.

Thanks a lot for the fix.
It works perfectly now.

Log in or register to post comments