You are here

[BUG] PAL does not support jdkPortable

5 posts / 0 new
Last post
Gord Caswell
Gord Caswell's picture
Offline
Last seen: 3 hours 29 min ago
DeveloperModerator
Joined: 2008-07-24 18:46
[BUG] PAL does not support jdkPortable

With the release of jdkPortable, support for the same has not yet been added to PAL. It is, however, on my todo list.

NB - Marked as a bug for tracking purposes.

Gord Caswell
Gord Caswell's picture
Offline
Last seen: 3 hours 29 min ago
DeveloperModerator
Joined: 2008-07-24 18:46
2 methods

There are essentially two methods for adding this to PAL.

  1. Support is added for jdkPortable alongside jPortable in Java.nsh, when searching for the JRE. This requires adding no extra Activate keys in launcher.ini.
  2. Support is added for jdkPortable alongside jPortable in Java.nsh, but is searched for in line with a new launcher.ini Activate key.

I'm personally leaning towards the second option, as it's possible users have both jPortable and jdkPortable installed, and unless jdkPortable was given priority over jPortable, there's the possibility jdkPortable would not be found by the launchers if jPortable exists.

John T. Haller
John T. Haller's picture
Offline
Last seen: 3 hours 48 min ago
AdminDeveloperModerator
Joined: 2005-11-28 22:21
1 and 2

I'm in favor of both. For the 1st instance, where an app needs a JRE, look for jPortable first and the JRE within jdkPortable second.

In the second instance, an app needs JDK not JRE, we should figure out how that works now with Netbeans and the like and add a key and logic just for that.

Sometimes, the impossible can become possible, if you're awesome!

Gord Caswell
Gord Caswell's picture
Offline
Last seen: 3 hours 29 min ago
DeveloperModerator
Joined: 2008-07-24 18:46
Agreed

Ok, so we're in agreement then.

Matt made a merge request a while back, and I'm incorporating much of his work.

Gord Caswell
Gord Caswell's picture
Offline
Last seen: 3 hours 29 min ago
DeveloperModerator
Joined: 2008-07-24 18:46
Support added

I've added support for jdkPortable to PAL.

Please test in a forked copy of the repository.

If others can confirm this works as intended, I'll push the changes to the official repository.

John, I'll contact you offline with a copy.

Log in or register to post comments