You are here

XAMPP Launcher 1.7 upgrade deletes all Xampp installation data

6 posts / 0 new
Last post
konilabs
Offline
Last seen: 6 years 1 month ago
Joined: 2018-09-17 06:40
XAMPP Launcher 1.7 upgrade deletes all Xampp installation data

Dear PortableApps team,

I upgraded XAMPP Control Panel app to version 1.7.0.0 this morning.
https://portableapps.com/apps/development/xampp

It deleted all data located inside P:\PortableApps\XAMPP\App\xampp during update.
This means that all my XAMPP installation was deleted automatically, and nothing arrived inside recycle bin.

OS : Windows 7 64 bit.

It looks like it is a major bug to me.
Please contact me if you need any other information.

John T. Haller
John T. Haller's picture
Offline
Last seen: 2 hours 43 min ago
AdminDeveloperModeratorTranslator
Joined: 2005-11-28 22:21
Specifically Preserved

The directories XAMPP\App\xampp and XAMPP\App\xampplite are specifically preserved by the installer via directives within installer.ini. I just upgraded a XAMPP install with the files within XAMPP\App\xampp and it upgraded without issue and preserved the files within. Any other directories within App will be deleted. Are there any files that were still running when you performed the upgrade? Was there anything within that would have locked the installer from renaming the App\xampp directory during upgrade?

Sometimes, the impossible can become possible, if you're awesome!

konilabs
Offline
Last seen: 6 years 1 month ago
Joined: 2018-09-17 06:40
After looking deeply inside P

After looking deeply inside P:\PortableApps\XAMPP\App\xampp\

There is still :
P:\PortableApps\XAMPP\App\xampp\apache\bin
P:\PortableApps\XAMPP\App\xampp\apache\modules
P:\PortableApps\XAMPP\App\xampp\php

So it looks like Apache service was still running during update.
I hope this helps.

John T. Haller
John T. Haller's picture
Offline
Last seen: 2 hours 43 min ago
AdminDeveloperModeratorTranslator
Joined: 2005-11-28 22:21
That Would Do It

That would be why. The PortableApps.com Installer assumes the user has shut down the app being upgraded. It doesn't yet have error handling around directory preserves. So, in your case, it moved the App\xampp directory (which failed because files were running and locking it), deletes the App directory (which fails on the individual files locked and the directories containing them but otherwise succeeds) and then moves the directory back into App (which fails as it doesn't exist). I'll need to build error handling on each move and figure out how to handle it as backing out without destorying the app wouldn't be possible in the current code flow.

For now, you'll need to restore from a recent backup. Sorry about this.

Sometimes, the impossible can become possible, if you're awesome!

konilabs
Offline
Last seen: 6 years 1 month ago
Joined: 2018-09-17 06:40
Thanks for your explanation.

Thanks for your explanation.
Do not worry, I managed to restore important data, but I was a little bit surprised Smile

Best regards,
Nicolas

John T. Haller
John T. Haller's picture
Offline
Last seen: 2 hours 43 min ago
AdminDeveloperModeratorTranslator
Joined: 2005-11-28 22:21
Installer Fix

I added a fix to the PA.c Installer to trap for this error and allow the end user to clear the lock. It's been released as PA.c Installer 3.5.11. This won't affect existing installers, of course, but it should help alleviate the issue for upgrades going forward.

Sometimes, the impossible can become possible, if you're awesome!

Log in or register to post comments