New: Capture2Text (Sep 26, 2023), Platform 26.2.1 (Sep 17, 2023)
450+ real apps (49GB), 1.1 billion downloads, Please donate.
Jack Haller, Advisor and Father of Our Founder, Has Passed Away
Hello. I want to make my portable app change ProgramExecutable based on the version of Windows. I tried to this in Custom.nsh:
${SegmentFile}
${SegmentInit}
${If} ${AtLeastWin110}
${SetEnvironmentVariablesPath} FullAppDir $AppDirectory\PolyMC
${Else}
${SetEnvironmentVariablesPath} FullAppDir $AppDirectory\Legacy
${EndIf}
!macroend
But it seems I can't use the environment variable in ProgramExecutable. Any idea how I'd accomplish this? Thanks.
At the moment the AtLeastWinX variables don't work for Windows 10 and 11 in the PA.c Launcher, so you'll need to use custom code. For an example of this, check out the custom code in the current calibre Portable launcher. Here's a simplified version that should work for your use case:
${SegmentFile}
${SegmentInit}
ReadRegStr $0 HKLM "Software\Microsoft\Windows NT\CurrentVersion" "CurrentBuild"
${If} $0 > 9999 ;Windows 10 or later
${SetEnvironmentVariablesPath} FullAppDir $AppDirectory\PolyMC
${Else}
${SetEnvironmentVariablesPath} FullAppDir $AppDirectory\Legacy
${EndIf}
!macroendHello. Thanks for the answer. Unfortunately, it would seem that I still can't use the FullAppDir variable in ProgramExecutable. It just tells me "App\%FullAppDir%\PolyMC.exe could not be found". So, environment variables don't seem to be expanded in ProgramExecutable. I get the same result if I try to put in a different variable, like %AppData% (for testing). Looking at calibre's custom code, it looks like it's renaming the included Calibre64 and Calibre32 directories to Calibre and launching from the Calibre directory. I did figure out a better solution, however. I can use StrCpy to change $ProgramExecutable in my code. However, if I change it in Init, it's read from config afterwards in Core.nsh. I had to change the variable in Pre. It's worth noting, however, that normally ProgramExecutable is checked to make sure it exists during Init, so I just set the config to the Win10 version of my application and changed it to Legacy if needed.
${SegmentFile}
${SegmentPre}
ReadRegStr $0 HKLM "Software\Microsoft\Windows NT\CurrentVersion" "CurrentBuild"
${If} $0 < 10000
StrCpy $ProgramExecutable "Legacy\PolyMC.exe"
${EndIf}
!macroend
Ah right. I forgot you were using it for ProgamExecutable. That variable doesn't support environment variables within the PA.c Launcher at present. Your alternative would be to move either the EXE or the directories the way I do in calibre. Here's an example with PolyMC always being the directory and moving the legacy vs modern to it depending on OS:
${SegmentFile}
${SegmentInit}
ReadRegStr $0 HKLM "Software\Microsoft\Windows NT\CurrentVersion" "CurrentBuild"
${If} $0 > 9999 ;Windows 10 or later
${If} ${FileExists} "$EXEDIR\App\PolyMC-Modern"
Rename "$EXEDIR\App\PolyMC" "$EXEDIR\App\PolyMC-Legacy"
Rename "$EXEDIR\App\PolyMC-Modern" "$EXEDIR\App\PolyMC"
${EndIf}
${Else}
${If} ${FileExists} "$EXEDIR\App\PolyMC-Legacy"
Rename "$EXEDIR\App\PolyMC" "$EXEDIR\App\PolyMC-Modern"
Rename "$EXEDIR\App\PolyMC-Legacy" "$EXEDIR\App\PolyMC"
${EndIf}
${EndIf}
!macroendAs I mentioned above, a better alternative is to change $ProgramExecutable in SegmentPre:
${SegmentFile}
${SegmentPre}
ReadRegStr $0 HKLM "Software\Microsoft\Windows NT\CurrentVersion" "CurrentBuild"
${If} $0 < 10000
StrCpy $ProgramExecutable "Legacy\PolyMC.exe"
${EndIf}
!macroend
(For some reason, < and " are escaped in that code block when using Markdown)
Edit: If you do it in Init instead of Pre, it's read from the INI afterwards. I have the "Modern" version defined in the INI, because PA Launcher also checks to make sure the path exists during Init.
Ah, right, sorry about that. Yes, this solution should work.
Visit the Community page
Join our forums
Follow us on BlueSky