New: Wise Duplicate Finder (Jan 23, 2023), Platform 23.1 (Jan 11, 2023)
450+ real apps (49GB), 1 billion downloads, Please donate.
if there something wrong with this code?? because its not poping up a msg box at all and im running xp, im not good with nsis yet so i though i might have messed up the if statement or something. GetWindowsVersion is a function i found in the manual.
Section "Main"
; Windows 2000 Fix
Call GetWindowsVersion
Pop $R0
!if "$R0" = "2000"
MessageBox MB_ICONEXCLAMATION|MB_OK "windows2k"
!endif
!if "$R0" = "XP"
MessageBox MB_ICONEXCLAMATION|MB_OK "windowsXP"
!endif
SectionEnd
I'm lower than a NSIS beginner, but I don't think variables go in quotes if you want to get their value.
Try:
!if $R0 = "2000"
You are using the script from Appendix C, #5 right?
dident work without quotes nither but i changed it a little now it works
Call GetWindowsVersion
Pop $R0
${If} "$R0" == "2000"
MessageBox MB_ICONEXCLAMATION|MB_OK "windows2k"
${EndIf}
${If} "$R0" == "XP"
MessageBox MB_ICONEXCLAMATION|MB_OK "windowsXP"
${EndIf}
In NSIS, if/endif works a bit differently. The !if/!ifdef/!endif/etc. commands are compile time commands. If the conditional is not true, then the code is not compiled into the exe. Since your variables are empty your !if statement is false, and you end up with a basically empty exe.
You can do this 2 ways -
Section "Main"
Call GetWindowsVersion
Pop $R0
StrCmp $R0 "2000" 0 +2
MessageBox MB_ICONEXCLAMATION|MB_OK "windows2k"
StrCmp $R0 "XP" 0 +2
MessageBox MB_ICONEXCLAMATION|MB_OK "windowsXP"
SectionEnd
or you can add '!include logiclib.nsh' at the top of your script and do
Section "Main"
Call GetWindowsVersion
Pop $R0
${if} $R0 == "2000"
MessageBox MB_ICONEXCLAMATION|MB_OK "windows2k"
${elseif} $R0 == "XP"
MessageBox MB_ICONEXCLAMATION|MB_OK "windowsXP"
${endif}
SectionEnd
i found the logic way in the manual so i used that but i think ill change it to your first example. Its not going to popup a box at all its acutaly going to replace files in GnuCash to fix an issue on win2k pc's
In that case you'll probably want to jump to labels instead of using relative jumps like my example (0 +2). Also note that using a relative jump to jump over a macro WILL NOT work (one of those little gotchas that isn't in the manual).
Visit the Community page
Join our forums