PortableApps.com Wins Big in the 2009 SourceForge Community Choice Awards and hits 100 million portable apps served!

AdditionalParameters not working in VLCPortable.nsi

Submitted by rpmohn on December 30, 2008 - 10:57am

The AdditionalParameters var set in VLCPortable.ini doesn't seem to work. I checked the VLCPortable.nsi file and the var is set, but never used. I believe it should be passed at the end of the $EXECSTRING (on lines 188 & 192 of my .nsi file). Haven't looked into how to compile .nsi files yet so could someone please fix and post?

Thanks! -Ross

( categories:

VLC Portable

)

OK, I compiled the fix for

rpmohn - December 31, 2008 - 9:36am

OK, I compiled the fix for myself and it works! Please make this change in the next upgrade to VLC.

Thanks for the great PortableApps platform!

-Ross

you actually enter the

Zach Thibeau (Homepage) - December 31, 2008 - 10:00am

you actually enter the additional parameters into vlcportable.ini in the additionalparameters part there. and then move the ini file to where the vlcportable.exe is located.

The day Microsoft produces something that doesn't suck is
probably the day they start producing vaccuum cleaners. (author unknown)

$Additional Parameters variable not used

rpmohn - December 31, 2008 - 11:59am

Yes, except that it doesn't work in the current release because the $AdditionalParameters variable isn't passed to $EXECSTRING in the VLCPortable.nsi file! Here's the patch that fixes the problem. I hope it is included in the next release!

--- VLCPortable.000.nsi 2008-12-31 11:51:38.000000000 -0500
+++ VLCPortable.nsi     2008-12-30 10:50:16.000000000 -0500
@@ -185,11 +185,11 @@ Section "Main"
                StrCmp "'$0'" "''" "" LaunchProgramParameters
 
                ;=== No parameters
-               StrCpy $EXECSTRING `"$PROGRAMDIRECTORY\$PROGRAMEXECUTABLE" --vlm-conf "$SETTINGSDIRECTORY\vlcrc" --no-plugins-cache --config "$SETTINGSDIRECTORY\vlcrc"`
+               StrCpy $EXECSTRING `"$PROGRAMDIRECTORY\$PROGRAMEXECUTABLE" --vlm-conf "$SETTINGSDIRECTORY\vlcrc" --no-plugins-cache --config "$SETTINGSDIRECTORY\vlcrc" $ADDITIONALPARAMETERS`
                Goto AdjustSettings
 
        LaunchProgramParameters:
-               StrCpy $EXECSTRING `"$PROGRAMDIRECTORY\$PROGRAMEXECUTABLE" $0 --vlm-conf "$SETTINGSDIRECTORY\vlcrc" --no-plugins-cache --config "$SETTINGSDIRECTORY\vlcrc"`
+               StrCpy $EXECSTRING `"$PROGRAMDIRECTORY\$PROGRAMEXECUTABLE" $0 --vlm-conf "$SETTINGSDIRECTORY\vlcrc" --no-plugins-cache --config "$SETTINGSDIRECTORY\vlcrc" $ADDITIONALPARAMETERS`
        
        AdjustSettings:
                StrCmp $SECONDARYLAUNCH "true" LaunchAndClose

Cheers! -Ross

What's the problem with the NSIS compiler?

Morphinity - January 12, 2009 - 5:38pm

I've just made the changes to the code, but compliler doesn't seem to process the source. It doesn't know what to do with newadvsplash function. What is the right version of compiler for this case? Or the problem is with libs?

Plugins

Bart.S - January 13, 2009 - 5:39am

You need some NSIS-Plugins to compile the code. (e.g. NewAdvSplash plugin).

Applications

User login

Follow & Connect With Us

What is a portable app?

Sponsored Links