FBReader Portable 0.12.10 Dev Test 3

OK, I fixed the installer languages and the appinfo but I can't make it crash. Had it running for the last hour or so without a problem. Anything in particular I can do to try and reproduce it?

It doesn't have to be relative. Just set it as normal and the launcher will update the drive letter if it changes. As long as your books are on the same drive as the program, there shouldn't be a problem.

Portable update is ready to go but there seems to be a problem with the app in that the only way to close it is to kill it in Task Manager. Not good. Can anyone else confirm?

Yes, it works properly now Thanks for the nudge.

I couldn't leave this app to rest, and finally found the .FBReader folder on my system. It is because on my OS I do not have the 'My Documents' folder on the Windows drive (C:) as a sub folder of %USERPROFILE% (or $PROFILE), but I've got it as a folder on my D: drive. Somehow FBreader doesn't use the value of %USERPROFILE% to determine where the .FBReader folder should be, but uses the parent of the 'My Documents' folder. I've tested this (just to make sure) by relocating my documents folder to a sub-folder down and yes, FBreader created the .FBreader folder in the parent folder.

By finding this folder and getting more familiar with FBReader Portable, I realize there is some stuff not right with the drive-letter updating. In FBReaderPortable.reg I came around the following registry key(please do not ask me how I got it created, for now I can not reproduce it):

[HKEY_CURRENT_USER\Software\FBReader\books\F:$092Documents$092Ebooks$092A_Plague_of_Demons.prc]
"BreakType"="3"
"Initialized"="true"

Where $092 is the value for '\'
So line 190 in FBReader(P)ortable.nsi:

${ReplaceInFile} '$SETTINGSDIRECTORY\${NAME}.reg' '$LASTDRIVE\' '$CURRENTDRIVE\'

could better be:

${ReplaceInFile(CS)} '$SETTINGSDIRECTORY\${NAME}.reg' '$LASTDRIVE' '$CURRENTDRIVE'

or

${ReplaceInFile(CS)} '$SETTINGSDIRECTORY\${NAME}.reg' '$LASTDRIVE\' '$CURRENTDRIVE\'
${ReplaceInFile(CS)} '$SETTINGSDIRECTORY\${NAME}.reg' '$LASTDRIVE$092' '$CURRENTDRIVE$092'

Aswell .FBreader\books.db should be updated to keep the MRU's working well after switching computer. Personally I do not have experience with updating SQLite format 3 drive-letters, maybe it's possible with the NewTextReplace plug-in, but I also know that SongBirdPortable has a good way of dealing with the issue.

Besides the issues, I personally think this app has potential to make it official, and it would be a good addition to the official portable apps list

edit: Final thing , You forgot a 'Goto End' just before 'LaunchAndExit:', so atm in a registry back-up case the launcher restarts FBReader.exe on exit.

Looking forward to testing this further, just installed for the very first time.

At first run, I got a box up -
"FBReader Portable | PortableApps.com"
"?"
"The path to FBReader Portable has changed since it was last run.

Last Directory: PATH
Current Directory: PortableApps\FBReaderPortable

Some features may not work. Would you like to continue?"

This may be per design, just wanted to mention it.

This app seems to run excellent. System: Win7 x64 ult., admin account but neiter PA.c nor FBRp run as admin.

With a few more testruns and the tests normally done on portable apps here, I'd say it seems pretty ready for release, and IMHO a bookreader has been missing from the apps list here for a long time. Great work.