You are here

Unicode plug-in test TAKE 3

79 posts / 0 new
Last post
Mark Sikkema
Offline
Last seen: 13 years 1 month ago
Developer
Joined: 2009-07-20 14:55
Unicode plug-in test TAKE 3

Due to some problems on specific version(s) of Wine, I've had to re-write registry::_RestorKey from scratch.
So here it is !

Explanation of the test:

  1. Gives you the option to use the debug messages(yes) or not (no).
  2. If yes, Regedit.exe will be executed to follow the happenings in the registry
  3. Then it restores a .reg file to HKEY_CURRENT_USER\Software\PA.c[Test]Key
  4. It will move this key to HKEY_CURRENT_USER\Software\PA.c[Test]Key-Backup
  5. It will save the last key to $EXEDIR
  6. The plugin deletes HKEY_CURRENT_USER\Software\PA.c[Test]Key-Backup
  7. Debug message, for you to check if anything is left behind(press NO) or it is all clean (press YES, and will continue to next plug-in)
  8. If you confirmed keys left behind, it will delete the keys using the native NSIS command DeleteRegKey
  9. Last debug message for you to check if the keys are still there or not !
  10. Finally it will Restore & Save a file called WinMerge2.reg and WinMerge1.reg is copied from the Source, you could diff them to verify if they are equal

In Wine the order of the values in WinMerge2.reg could be different from WinMerge1.reg, but they should contain the exact same data

All the result should be is :

The Plug-in test was successful

If not it will tell you which plug-in made the error + error codes,please report this info.

Please report what OS you've tested it on and if the test was successful or not !

Download PluginTest10.zip
(MD5:0ae199a4a8b971a12a52b0daec87766c)

Successful Tests done (PluginTest8,9&10):

Wine 1.0.1 , Ubuntu 9.10.                   By: Gringoloco
Wine 1.2-rc1, Ubuntu 10.04                  By: ChrisMorgan
Wine 1.2-rc1                                By: dboki89
Wine 1.1.30, Wine 1.1.43, Wine 1.1.44       By: dboki89
Vista SP2 32bit (Ultimate)                  By: dboki89 & JohnTHaller
Win 7 x64 (home edition)                    By: Soulmech & JohnTHaller
Windows XP sp 3                             By: Gringoloco, JohnTHaller & dboki89
Windows XP sp 2                             By: dboki89
Windows 2000                                By: JohnTHaller

Successful Tests done in previous tests (before the re-write):

Wine 1.1.42 , Kubuntu                       By: Simeon
Windows 2000                                By: JohnTHaller
Windows XP sp 2                             By: prapper
Windows XP sp 3                             By: Gringoloco, ChrisMorgan & Simeon
Vista Ultimate x64 SP2                      By: Benedikt93
Windows 7 Ultimate x64(fully patched)       By: JohnTHaller & SteveLamerton
Windows 7 Professional x64                  By: xuesheng

Mark Sikkema
Offline
Last seen: 13 years 1 month ago
Developer
Joined: 2009-07-20 14:55
dboki89,

Can you confirm that MaximaPortable is just not doing anything, like also not saving a *.reg file ?
Can you confirm that the registry plug-in just never works, or maybe just not when used in the Maxima launcher ?
Can you confirm that NewTextReplace plug-in for Unicode is working for you ?
And what about RealProgress plug-in, the one what shows the progress on the PortableApps.com InstallerU ?

About changing the source, I really don't see what I could change in the source to solve this.

All I can think of is to re-compile with a few different compilers and to link against the unicode pluginapi.lib or just use pluginapi.c .

Formerly Gringoloco
Windows XP Pro sp3 x32

dboki89
Offline
Last seen: 9 years 9 months ago
Joined: 2009-11-30 20:44
.

1)

Can you confirm that NewTextReplace plug-in for Unicode is working for you ?

The results are the same both for Ansi and Unicode:

Unicode plug-in test

registry should have     0 - 0 - 0 - 0
registryVC2008U           0 - 0 - 0 - 0
registryVC2008libU           0 - 0 - 0 - 0

NewTextReplace should have   10
NewTextReplaceU                     10
Completed

2) FYI, this test added some entries to the registry (I think it changed my language setting for 7-zip):

[HKEY_CURRENT_USER\Software\7-zip]
"Lang"="nl"

[HKEY_CURRENT_USER\Software\7-zip-Backup]
"Lang"="nl"

[HKEY_CURRENT_USER\Software\7-zip-Backup]
"Path"="C:\Program Files\7-Zip"

3) MaximaPortable is saving a *.reg file. It left 3 files, actually (though only one REG file):

MaximaPortable\Data\settings\.xmaximarc
MaximaPortable\Data\settings\MaximaPortableSettings.ini
MaximaPortable\Data\settings\wxMaxima.reg

4)

Can you confirm that the registry plug-in just never works, or maybe just not when used in the Maxima launcher ?

How? With what to compare it to? Most of the other apps work great, and none of them left HKCU keys, if that's what you meant... A number of apps running latest PAL are working clean.

Btw, I'm unable to provide further testing 'till tomorrow, I have a lot of (real-life) work for tonight. Post anyway what needs to be checked, if I haven't done it yet.

Cheers Smile

My posts are old and likely no longer relevant.

Mark Sikkema
Offline
Last seen: 13 years 1 month ago
Developer
Joined: 2009-07-20 14:55
Ok, this getting messy (I

Ok, this getting messy (I wish I did add the plug-in as is being used for the current Unicode NSIS Portable)

Anyway, the test succeeded successfully !

Maybe your entries got left behind due to PAL crashing ?

We will see, thanx anyway

[edit: the result shows a success, but the 7-zip entries shouldn't have been left behind Pardon ]

Formerly Gringoloco
Windows XP Pro sp3 x32

Mark Sikkema
Offline
Last seen: 13 years 1 month ago
Developer
Joined: 2009-07-20 14:55
Is there anybody around who

Is there anybody around who could give me a sensible answer on, if it would make a difference which compiler I am or should be using to compile ?

I just got VC++2008 sp1 (re)installed, should I just stick with it to try to fix this problem ?
I have got a frozen computer, so I could re-boot and install VC++6.0 sp6 to compile a few additional registry plug-ins, to include into a test package !

Formerly Gringoloco
Windows XP Pro sp3 x32

Steve Lamerton
Steve Lamerton's picture
Offline
Last seen: 11 years 1 month ago
Developer
Joined: 2005-12-10 15:22
Compiler

shouldn't make any difference, I would personally avoid VC++ 6.0 given its near complete lack of standards support.

Mark Sikkema
Offline
Last seen: 13 years 1 month ago
Developer
Joined: 2009-07-20 14:55
I was revering vc++6.0, as

I was revering vc++6.0, as this is what the original plug-in was compiled on.

Any ideas on https://portableapps.com/node/23419#comment-148379 ?

Would you have ago on re-compiling, I'm really not sure what I'm doing (wrong) !

Or maybe I should try to get help from the original author ?

Formerly Gringoloco
Windows XP Pro sp3 x32

Mark Sikkema
Offline
Last seen: 13 years 1 month ago
Developer
Joined: 2009-07-20 14:55
A test package....

I include 2 executables an Unicode and an Ansi(as a reference).
Each executable consists of 2 Registry plugins, one linked against pluginapi.lib and one which includes pluginapi.c !
All compiled with VC++2008 sp1

As well I included the NewTextReplace plugin, exactly the one we are using at the moment ! (just to be sure)

The result should be this(if not there is a problem):

Ansi plug-in test

registry should have      0 - 0 - 0 - 0
registryVC2008U           0 - 0 - 0 - 0
registryVC2008libU           0 - 0 - 0 - 0

NewTextReplace should have   10
NewTextReplaceU              10
Completed

Link to test package: http://www.mediafire.com/?uzintvymy1x
(MD5: 2bdef571d5319909375c8c23001b381c)

If just people want to test this with all kinds of OS, we can be sure that all problems are solved.
And leave a note if the test succeeded or not, including the OS you are using!

Formerly Gringoloco
Windows XP Pro sp3 x32

Steve Lamerton
Steve Lamerton's picture
Offline
Last seen: 11 years 1 month ago
Developer
Joined: 2005-12-10 15:22
Works

for me in Windows 7 Professional 64bit

Mark Sikkema
Offline
Last seen: 13 years 1 month ago
Developer
Joined: 2009-07-20 14:55
Thanx Steve Lamerton I'll add

Thanx Steve Lamerton

I'll add that to the list

Formerly Gringoloco
Windows XP Pro sp3 x32

Benedikt93
Offline
Last seen: 9 years 11 months ago
Joined: 2009-12-17 14:46
Works

on Vista Ultimate x64 SP2

"Der Klügere gibt nach, deshalb regieren Dumme die Welt."

John T. Haller
John T. Haller's picture
Offline
Last seen: 1 hour 38 min ago
AdminDeveloperModeratorTranslator
Joined: 2005-11-28 22:21
Windows 2000 Fails Both ANSI and Unicode

Windows 2000 fails with:

Ansi plug-in test
Delete file: X:\PluginTest\NewTextReplaceA.reg

registry should have     0 - 0 - 0 - 0
Could not load: C:\DOCUME~1\ADMINI~1\LOCALS~1\Temp\nsdA.tmp\registryVC2008A.dll
Could not load: C:\DOCUME~1\ADMINI~1\LOCALS~1\Temp\nsdA.tmp\registryVC2008A.dll
Could not load: C:\DOCUME~1\ADMINI~1\LOCALS~1\Temp\nsdA.tmp\registryVC2008A.dll
Could not load: C:\DOCUME~1\ADMINI~1\LOCALS~1\Temp\nsdA.tmp\registryVC2008A.dll
registryVC2008A           HKEY_CURRENT_USER\Software\7-zip - HKEY_CURRENT_USER\Software\7-zip-Backup - HKEY_CURRENT_USER\Software\7-zip - HKEY_CURRENT_USER\Software\7-zip-Backup
Could not load: C:\DOCUME~1\ADMINI~1\LOCALS~1\Temp\nsdA.tmp\registryVC2008A.dll
Could not load: C:\DOCUME~1\ADMINI~1\LOCALS~1\Temp\nsdA.tmp\registryVC2008libA.dll
Could not load: C:\DOCUME~1\ADMINI~1\LOCALS~1\Temp\nsdA.tmp\registryVC2008libA.dll
Could not load: C:\DOCUME~1\ADMINI~1\LOCALS~1\Temp\nsdA.tmp\registryVC2008libA.dll
Could not load: C:\DOCUME~1\ADMINI~1\LOCALS~1\Temp\nsdA.tmp\registryVC2008libA.dll
registryVC2008libA           HKEY_CURRENT_USER\Software\7-zip - HKEY_CURRENT_USER\Software\7-zip-Backup - HKEY_CURRENT_USER\Software\7-zip - HKEY_CURRENT_USER\Software\7-zip-Backup
Could not load: C:\DOCUME~1\ADMINI~1\LOCALS~1\Temp\nsdA.tmp\registryVC2008libA.dll

NewTextReplace should have   10
NewTextReplaceA                     10
Completed
Unicode plug-in test

registry should have     0 - 0 - 0 - 0
Could not load: C:\DOCUME~1\ADMINI~1\LOCALS~1\Temp\nsa6.tmp\registryVC2008U.dll
Could not load: C:\DOCUME~1\ADMINI~1\LOCALS~1\Temp\nsa6.tmp\registryVC2008U.dll
Could not load: C:\DOCUME~1\ADMINI~1\LOCALS~1\Temp\nsa6.tmp\registryVC2008U.dll
Could not load: C:\DOCUME~1\ADMINI~1\LOCALS~1\Temp\nsa6.tmp\registryVC2008U.dll
registryVC2008U           HKEY_CURRENT_USER\Software\7-zip - HKEY_CURRENT_USER\Software\7-zip-Backup - HKEY_CURRENT_USER\Software\7-zip - HKEY_CURRENT_USER\Software\7-zip-Backup
Could not load: C:\DOCUME~1\ADMINI~1\LOCALS~1\Temp\nsa6.tmp\registryVC2008U.dll
Could not load: C:\DOCUME~1\ADMINI~1\LOCALS~1\Temp\nsa6.tmp\registryVC2008libU.dll
Could not load: C:\DOCUME~1\ADMINI~1\LOCALS~1\Temp\nsa6.tmp\registryVC2008libU.dll
Could not load: C:\DOCUME~1\ADMINI~1\LOCALS~1\Temp\nsa6.tmp\registryVC2008libU.dll
Could not load: C:\DOCUME~1\ADMINI~1\LOCALS~1\Temp\nsa6.tmp\registryVC2008libU.dll
registryVC2008libU           HKEY_CURRENT_USER\Software\7-zip - HKEY_CURRENT_USER\Software\7-zip-Backup - HKEY_CURRENT_USER\Software\7-zip - HKEY_CURRENT_USER\Software\7-zip-Backup
Could not load: C:\DOCUME~1\ADMINI~1\LOCALS~1\Temp\nsa6.tmp\registryVC2008libU.dll

NewTextReplace should have   10
NewTextReplaceU                     10
Completed

I'm actually thinking this is to the runtimes not being there, I'll add them and see what we get. Could this be the issue on WinXP SP2 as well? Remember, I think most VC2008-compiled apps will require the VC2008 runtime which will NOT be on most Win2K and earlier XP machines.

Sometimes, the impossible can become possible, if you're awesome!

John T. Haller
John T. Haller's picture
Offline
Last seen: 1 hour 38 min ago
AdminDeveloperModeratorTranslator
Joined: 2005-11-28 22:21
Added Runtimes

Added the runtimes and that now yields the following:

Ansi plug-in test
Delete file: X:\PluginTest\NewTextReplaceA.reg

registry should have     0 - 0 - 0 - 0
registryVC2008A           -1 - -1 - -1 - -1
registryVC2008libA           -1 - -1 - -1 - -1

NewTextReplace should have   10
NewTextReplaceA                     10
Completed
Unicode plug-in test
Delete file: X:\PluginTest\NewTextReplaceU.reg

registry should have     0 - 0 - 0 - 0
registryVC2008U           -1 - -1 - -1 - -1
registryVC2008libU           -1 - -1 - -1 - -1

NewTextReplace should have   10
NewTextReplaceU                     10
Completed

Either way, we can't depend on the VC2008 runtimes being available on any system except Vista and Win7 I think, so let's using VC6 for compiling.

Sometimes, the impossible can become possible, if you're awesome!

Steve Lamerton
Steve Lamerton's picture
Offline
Last seen: 11 years 1 month ago
Developer
Joined: 2005-12-10 15:22
We

just need to link statically and it wont be a problem.

1) Open the Project Properties dialog
2) In "Configuration Properties -> C/C++ -> Code Generation", in the field "Runtime Library", choose "Multi-threaded (/MT)"

Mark Sikkema
Offline
Last seen: 13 years 1 month ago
Developer
Joined: 2009-07-20 14:55
I'm pretty sure it was set to

I'm pretty sure it was set to /MT, at least it is now I reopened it !

[edit: maybe it should be /MD ( Multi threaded DLL)]

Formerly Gringoloco
Windows XP Pro sp3 x32

Mark Sikkema
Offline
Last seen: 13 years 1 month ago
Developer
Joined: 2009-07-20 14:55
I think I got the hang of it

I think I got the hang of it !
What I was doing wrong (I think?), is that I was linking against MSVCRT.LIB !
But probably should have been LIBCMT.LIB, which is static ?
Just, this is making the plug-in filesizes quite big ! (57KB)
And I was getting the following warning:

LIBCMT.lib(cpu_disp.obj) : warning LNK4210: .CRT section exists; there may be unhandled static initializers or terminators

Which disappeared by using:
Linker->Input->Force Symbol References = __DllMainCRTStartup@12

Anyway, had to reboot cause my internet stopped working so have to re-install VC++2008 if I want to use it again.
For now I'll use VC++6.0sp6, and add the plug-ins to the test package.
I know it's old, but most NSIS plug-ins seemed to have been compiled with it !

Could you confirm if I'm doing things right or not ?
Thanx it advance

[edit: if necessary and if you have time to look at the source/compiler-settings, here is a link:
http://pcpfaa.bay.livefilestore.com/y1pitpPfzbaGJ2auucH11N4TRz1MxBX8USmM... ]
[edit2: FYI, originally it was linking against libcd.lib, but that's not valid for vc++2008, anymore]

Formerly Gringoloco
Windows XP Pro sp3 x32

Steve Lamerton
Steve Lamerton's picture
Offline
Last seen: 11 years 1 month ago
Developer
Joined: 2005-12-10 15:22
Um

wow, it is a bit of a mess isn't it! I can't even get it to compile as there is a redefinition error between the TCHAR defined in Unicode NSIS and the one defined in the Windows SDK. I would just stick to VC++6, I can't make much out of the settings myself.

Mark Sikkema
Offline
Last seen: 13 years 1 month ago
Developer
Joined: 2009-07-20 14:55
TCHAR defined in Unicode

TCHAR defined in Unicode NSIS

Do you mean the TCHAR defined in nsis_tchar.h ?

As well could you confirm that I did understand the above about libcmt.lib ?

Anyway, I will re-package a new test executable take 2 !

Formerly Gringoloco
Windows XP Pro sp3 x32

Steve Lamerton
Steve Lamerton's picture
Offline
Last seen: 11 years 1 month ago
Developer
Joined: 2005-12-10 15:22
Yes,

thats the one.

I messed about with it and got it to compile, I think the issue you have is the fact that under Project -> Properties -> Linker -> Advanced you have an Entry Point set but also told it that there is no entry point! If you remove both and then your specific link to libcmt I think it works.

Mark Sikkema
Offline
Last seen: 13 years 1 month ago
Developer
Joined: 2009-07-20 14:55
Could you send me a copy if

Could you send me a copy of your compiled plugin + compile-settings, so I include it into the test-package as well. (I do not have access to VC++2008 at the moment)
I just like enough optional plugins so I can be that sure that I find out what are all the differences in behavior and get the compile-settings/plug-ins which are bug-less !

Formerly Gringoloco
Windows XP Pro sp3 x32

Steve Lamerton
Steve Lamerton's picture
Offline
Last seen: 11 years 1 month ago
Developer
Joined: 2005-12-10 15:22
Sent

Smile

Steve Lamerton
Steve Lamerton's picture
Offline
Last seen: 11 years 1 month ago
Developer
Joined: 2005-12-10 15:22
This

one works fine for me too Smile

Mark Sikkema
Offline
Last seen: 13 years 1 month ago
Developer
Joined: 2009-07-20 14:55
Is that Windows 7

Is that Windows 7 Professional 64bit ?

[BTW: you forgot to compile for unicode, I've included it for the Ansi tester though]

Formerly Gringoloco
Windows XP Pro sp3 x32

John T. Haller
John T. Haller's picture
Offline
Last seen: 1 hour 38 min ago
AdminDeveloperModeratorTranslator
Joined: 2005-11-28 22:21
Take 2 Successful: Windows 7 Ultimate x64 (fully patched)

Take 2 Successful: Windows 7 Ultimate x64 (fully patched)

Sometimes, the impossible can become possible, if you're awesome!

Mark Sikkema
Offline
Last seen: 13 years 1 month ago
Developer
Joined: 2009-07-20 14:55
But what about Windows 2000 ?

But what about Windows 2000 ?

Formerly Gringoloco
Windows XP Pro sp3 x32

John T. Haller
John T. Haller's picture
Offline
Last seen: 1 hour 38 min ago
AdminDeveloperModeratorTranslator
Joined: 2005-11-28 22:21
TAKE 2 Windows 2000 Failure

Everything except newtexreplaceCurU and newtextreplaceVC6sp6U failed with error codes of -1. Same for ANSI.

Sometimes, the impossible can become possible, if you're awesome!

Mark Sikkema
Offline
Last seen: 13 years 1 month ago
Developer
Joined: 2009-07-20 14:55
Arghh, everything.

I've included all the sources I hope somebody can really help to fix this

He, but the plugin named RegistryVC60libCurA.dll (in the Ansi tester) is the original plug-in from NSIS wiki. So this can't be me to blame, I didn't touch that one !

Still should try to solve it though !

Formerly Gringoloco
Windows XP Pro sp3 x32

Mark Sikkema
Offline
Last seen: 13 years 1 month ago
Developer
Joined: 2009-07-20 14:55
Maybe the issue could be:

Maybe the issue could be:

  nsExec::Exec `"$WINDIR\system32\reg.exe" import "$EXEDIR\Source\test.reg"`

could you exchange it with:

    registry::_RestoreKey "$EXEDIR\Source\test.reg"
    Pop $4
    Sleep 100

And recompile & try again (I just done and works for me on Windows XP)
[edit: Make it Sleep 200, as when I'm using 100 I still do get the odd error]

Formerly Gringoloco
Windows XP Pro sp3 x32

John T. Haller
John T. Haller's picture
Offline
Last seen: 1 hour 38 min ago
AdminDeveloperModeratorTranslator
Joined: 2005-11-28 22:21
Correct

That is indeed the issue. Windows 2000 doesn't have reg.exe. That's why my scripts do an IfFileExists on it before executing. I recompiled the ANSI version and everything succeeded.

Sometimes, the impossible can become possible, if you're awesome!

Mark Sikkema
Offline
Last seen: 13 years 1 month ago
Developer
Joined: 2009-07-20 14:55
What about recompiling

What about recompiling Unicode, that's the most important !

Anyway, I will update the package now !

Formerly Gringoloco
Windows XP Pro sp3 x32

John T. Haller
John T. Haller's picture
Offline
Last seen: 1 hour 38 min ago
AdminDeveloperModeratorTranslator
Joined: 2005-11-28 22:21
Unicode Also Works

Unicode also works with all successful using the latest Unicode NSIS Portable build.

Sometimes, the impossible can become possible, if you're awesome!

Mark Sikkema
Offline
Last seen: 13 years 1 month ago
Developer
Joined: 2009-07-20 14:55
So I was to blame ! Anyway,

So I was to blame ! Wink

Anyway, it's good we are doing this tests, so I & we can feel secure that these plug-ins are working as they should !

Formerly Gringoloco
Windows XP Pro sp3 x32

Chris Morgan
Chris Morgan's picture
Offline
Last seen: 9 years 4 months ago
Joined: 2007-04-15 21:08
Wine too

I suspect that may fix it for Wine. Imports didn't work in Wine with the Launcher.

Just tell me when you've got all this sorted out what I need to change in the Launcher source code and I'll fix it.

I am a Christian and a developer and moderator here.

“A soft answer turns away wrath, but a harsh word stirs up anger.” – Proverbs 15:1

Mark Sikkema
Offline
Last seen: 13 years 1 month ago
Developer
Joined: 2009-07-20 14:55
So what I understood (in

So what I understood (in IRC)the plugin test isn't successfull for you ?
Probably instead of checking if reg.exe exists, we could check the result of nsExec::Exec .Like the old-style launchers are doing.

If you are having unsuccessful results of the test executables, could you try adding this:

	StrCpy $R9 ''
	nsExec::Exec `"$WINDIR\system32\reg.exe" import "$EXEDIR\Source\test.reg"`
	Pop $R9
	sleep 100
        ${IfNot} $R9 == 0
		DetailPrint "Windows 2000 or Wine"
		${plugin}::_RestoreKey $EXEDIR\Source\test.reg
		Pop $R9
		Sleep 200
	${EndIf}

Anyway, I'm a bit puzzled as I seem to get random results in the test-package when using the 'registry::_restore' command, and no difference when I increase the 'sleep' value!
Just very random, some times one plugin is unsuccesful, sometimes more, sometimes others and sometimes it's succesful ?

[edit: I seem to need a 'sleep' value of min. 500 after restoring the key to be succesfull. Mind you, in a launcher the key gets restored after all the backingup and deleting]

Formerly Gringoloco
Windows XP Pro sp3 x32

John T. Haller
John T. Haller's picture
Offline
Last seen: 1 hour 38 min ago
AdminDeveloperModeratorTranslator
Joined: 2005-11-28 22:21
Do Both

Check if it exists and then check that it ran properly. It is possible that on some PCs a user may not have permission to run it.

Sometimes, the impossible can become possible, if you're awesome!

Benedikt93
Offline
Last seen: 9 years 11 months ago
Joined: 2009-12-17 14:46
Vista Ultimate x64 SP2

works just fine again

"Der Klügere gibt nach, deshalb regieren Dumme die Welt."

Mark Sikkema
Offline
Last seen: 13 years 1 month ago
Developer
Joined: 2009-07-20 14:55
Thanx, Benedikt93

Thanx, Benedikt93

Formerly Gringoloco
Windows XP Pro sp3 x32

prapper
Offline
Last seen: 3 years 9 months ago
Developer
Joined: 2008-01-24 17:01
XP SP2

All successful.

Mark Sikkema
Offline
Last seen: 13 years 1 month ago
Developer
Joined: 2009-07-20 14:55
XP sp2 ?

Thanx prapper,

If you do not mind, I will not add this one to the list(above) just now.

As this is the windows version what was all the fuzz about !

Formerly Gringoloco
Windows XP Pro sp3 x32

prapper
Offline
Last seen: 3 years 9 months ago
Developer
Joined: 2008-01-24 17:01
OK

No problem, I must have misunderstood Smile

Mark Sikkema
Offline
Last seen: 13 years 1 month ago
Developer
Joined: 2009-07-20 14:55
No worries prapper you didn't

No worries prapper you didn't misunderstand anything.

It's just that the people reporting problems with the registry plugin, where all on XPsp2, so I'd like more people to test with this OS !

Formerly Gringoloco
Windows XP Pro sp3 x32

dboki89
Offline
Last seen: 9 years 9 months ago
Joined: 2009-11-30 20:44
.

Just keeping XP SP2 bit together...

I tested both with admin privileges and without them. All tests (ANSI & Unicode x admin & no-admin) yielded in:

All Plug-in tests where successful

But, what's up with these plugin-tests and Netherlands language? This time, this was left behind:

[HKEY_CURRENT_USER\Software\PA.cTestKey]
"Lang"="nl"

[HKEY_CURRENT_USER\Software\PA.cTestKey-Backup]
"Lang"="nl"

Can you, prapper, kindly check on your system whether these keys were left?

My posts are old and likely no longer relevant.

prapper
Offline
Last seen: 3 years 9 months ago
Developer
Joined: 2008-01-24 17:01
No

It didn't leave those keys. On admin here (if it makes a difference).

Mark Sikkema
Offline
Last seen: 13 years 1 month ago
Developer
Joined: 2009-07-20 14:55
The strange thing is that all

The strange thing is that all the child-keys (apparently) aren't left behind. If you see the .reg file what gets written to your registry, moved and then deleted,you will realize there is a lot more than just this 'language' value !
Pardon
Ps:The dutch lang-value is nothing to worry about, I just used a 7-zip .reg file as it's a reasonable size for testing !

[edit: I am fairly sure that your problem has nothing to do with the registry plug-in what so ever as in the test script there are the lines:

DeleteRegKey HKCU `Software\PA.cTestKey`
DeleteRegKey HKCU `Software\PA.cTestKey-Backup`

Native NSIS code, what really should have cleaned it all up, even if the plug-in is failing.]

Formerly Gringoloco
Windows XP Pro sp3 x32

Mark Sikkema
Offline
Last seen: 13 years 1 month ago
Developer
Joined: 2009-07-20 14:55
In addition to our

In addition to our conversation in IRC yesterday....

I can reproduce these keys/values to show up in the sandboxie registry hive (somehow?).
However when I run Registry Editor in this same sandbox, these keys are not showing up and neither NSIS is recognizing them.

Anyway I made a new test-package, with additional debugging messageboxes, as well it now executes regedit.exe for you, so when run in a sandbox the Registry Editor is sandboxed as well.

Just follow the instruction in the debug messages, and I hope you'll find out there are no keys left behind, or if there are to finally understand why or when this exactly happens?

Please to test this properly do run this UNsandboxed in your Windows XPsp2 as well!

PluginTest4.zip

BTW: For you to understand what this test exactly does:
1. It first restores a .reg file to HKEY_CURRENT_USER\Software\PA.cTestKey
2. Then it moves this key to HKEY_CURRENT_USER\Software\PA.cTestKey-Backup
3. It will save the last key to $EXEDIR
4. Debug message, for you to check if HKEY_CURRENT_USER\Software\PA.cTestKey-Backup exists(it should at this point), or if HKEY_CURRENT_USER\Software\PA.cTestKey does not exist(should not exist at this point)
5. The plugin deletes HKEY_CURRENT_USER\Software\PA.cTestKey-Backup
6. Debug message, for you to check if anything is left behind(press NO) or it is all clean (press YES, and will continue to next plug-in)
7. I you confirmed keys left behind, it will delete the keys using the native NSIS command DeleteRegKey
8. Last debug message for you to check if the keys are still there or not !
9. It will repeat this same test for all of the 5 included plugins

The test routine is the same as used before, all tough I included debug messages, excluded the textreplace tests and I changed the routine to restore the key as I mentioned in ${registry::RestoreKey} ? (using ExecWait)

Formerly Gringoloco
Windows XP Pro sp3 x32

Chris Morgan
Chris Morgan's picture
Offline
Last seen: 9 years 4 months ago
Joined: 2007-04-15 21:08
Works in XP SP3

I just got a chance to test it in XP SP3, A and U versions work perfectly with all plug-in versions.

Were you wanting to update your main post to put in this version of the plug-in test?

I am a Christian and a developer and moderator here.

“A soft answer turns away wrath, but a harsh word stirs up anger.” – Proverbs 15:1

Mark Sikkema
Offline
Last seen: 13 years 1 month ago
Developer
Joined: 2009-07-20 14:55
Really this version was for dboki89...

But thanx for testing anyway, about updating the test in the main post, maybe I should cause we still need people to test it in Wine ! For the rest I think we can say that all tests are fine, so the plug-in we currently use is fine too !

Formerly Gringoloco
Windows XP Pro sp3 x32

Chris Morgan
Chris Morgan's picture
Offline
Last seen: 9 years 4 months ago
Joined: 2007-04-15 21:08
Wine: fine

On Wine, the testA.exe version was going fine and had just printed "registryVC6sp6libA test is successful" when it showed the crash message box... but continued happily (I've seen that happen with one or two other things yes.

Execute: Regedit.exe
Ansi plug-in test

Windows 2000 or Wine
Execute: "regedit.exe" /s "P:\PluginTest4\Source\test.reg"
RegistryVC60libCurA test is successful
Windows 2000 or Wine
Execute: "regedit.exe" /s "P:\PluginTest4\Source\test.reg"
registryVC2008A test is successful
Windows 2000 or Wine
Execute: "regedit.exe" /s "P:\PluginTest4\Source\test.reg"
registryVC2008libA test is successful
Windows 2000 or Wine
Execute: "regedit.exe" /s "P:\PluginTest4\Source\test.reg"
registryVC6sp6libA test is successful
Windows 2000 or Wine
Execute: "regedit.exe" /s "P:\PluginTest4\Source\test.reg"
registryVC6sp6A test is successful

All Plug-in tests where successful
Completed

testU.exe likewise showed the crash dialogue just after the "registryVC2008U test is successful" line, but likewise continued happily.

Execute: Regedit.exe
Unicode plug-in test

Windows 2000 or Wine
Execute: "regedit.exe" /s "P:\PluginTest4\Source\test.reg"
RegistryVC60libCurU test is successful
Windows 2000 or Wine
Execute: "regedit.exe" /s "P:\PluginTest4\Source\test.reg"
registryVC2008U test is successful
Windows 2000 or Wine
Execute: "regedit.exe" /s "P:\PluginTest4\Source\test.reg"
registryVC2008libU test is successful
Windows 2000 or Wine
Execute: "regedit.exe" /s "P:\PluginTest4\Source\test.reg"
registryVC6sp6libU test is successful
Windows 2000 or Wine
Execute: "regedit.exe" /s "P:\PluginTest4\Source\test.reg"
registryVC6sp6U test is successful

All Plug-in tests where successful
Completed

Wine 1.1.43 (PPA), Ubuntu 9.10.

I am a Christian and a developer and moderator here.

“A soft answer turns away wrath, but a harsh word stirs up anger.” – Proverbs 15:1

xuesheng
Offline
Last seen: 9 months 2 weeks ago
Joined: 2008-03-21 15:34
Windows 7 Professional x64

testA.exe and testU.exe (from PluginTest3.zip) both report "All Plug-in tests where successful"

Simeon
Simeon's picture
Offline
Last seen: 10 years 2 weeks ago
DeveloperTranslator
Joined: 2006-09-25 15:15
Works

on XP Sp3. All tests successful.

EDIT:
Did a test on Kubuntu 09.10 with Wine (latest version 1.0.1). Wasn't completely successful:

Ansi plug-in test

Windows 2000
RegistryVC60libCurA error codes -1 - -1 - -1 - -1 - -1
Windows 2000
registryVC2008A error codes -1 - -1 - -1 - -1 - -1
Windows 2000
registryVC2008libA error codes -1 - -1 - -1 - -1 - -1
Windows 2000
registryVC6sp6libA error codes -1 - -1 - -1 - -1 - -1
Windows 2000
registryVC6sp6A error codes -1 - -1 - -1 - -1 - -1
Windows 2000
registrySteveA error codes -1 - -1 - -1 - -1 - -1
newtextreplaceCurA test is successful
newtextreplaceVC6sp6A test is successful

Some Plug-in tests where unsuccessful !
See the details for more info !
Completed


Unicode plug-in test

Windows 2000
RegistryVC60libCurU error codes -1 - -1 - -1 - -1 - 0
Windows 2000
registryVC2008U error codes -1 - -1 - -1 - -1 - 0
Windows 2000
registryVC2008libU error codes -1 - -1 - -1 - -1 - 0
Windows 2000
registryVC6sp6libU error codes -1 - -1 - -1 - -1 - 0
Windows 2000
registryVC6sp6U error codes -1 - -1 - -1 - -1 - 0
newtextreplaceCurU test is successful
newtextreplaceVC6sp6U test is successful

Some Plug-in tests where unsuccessful !
See the details for more info !
Completed

"What about Love?" - "Overrated. Biochemically no different than eating large quantities of chocolate." - Al Pacino in The Devils Advocate

Mark Sikkema
Offline
Last seen: 13 years 1 month ago
Developer
Joined: 2009-07-20 14:55
Wine

Thanx for testing Simeon...
But I really should have updated the main topic!

Can you please see if test pack 4 works in wine ?
https://portableapps.com/node/23419#comment-148617

${registry::restorekey} has been replaced with ExecWait regedit...

Formerly Gringoloco
Windows XP Pro sp3 x32

Chris Morgan
Chris Morgan's picture
Offline
Last seen: 9 years 4 months ago
Joined: 2007-04-15 21:08
Worked for me

As I reported above they all worked for me (ignoring the crash message box).

I am a Christian and a developer and moderator here.

“A soft answer turns away wrath, but a harsh word stirs up anger.” – Proverbs 15:1

Simeon
Simeon's picture
Offline
Last seen: 10 years 2 weeks ago
DeveloperTranslator
Joined: 2006-09-25 15:15
ok

New test:

PluginTest4
===========
Execute: Regedit.exe
Ansi plug-in test
=================

Windows 2000 or Wine
Execute: "regedit.exe" /s "E:\Test\PluginTest4\Source\test.reg"
RegistryVC60libCurA error codes -1 - -1 - -1 - -1 - 
Windows 2000 or Wine
Execute: "regedit.exe" /s "E:\Test\PluginTest4\Source\test.reg"
registryVC2008A error codes -1 - -1 - -1 - -1 - 
Windows 2000 or Wine
Execute: "regedit.exe" /s "E:\Test\PluginTest4\Source\test.reg"
registryVC2008libA error codes -1 - -1 - -1 - -1 - 
Windows 2000 or Wine
Execute: "regedit.exe" /s "E:\Test\PluginTest4\Source\test.reg"
registryVC6sp6libA error codes -1 - -1 - -1 - -1 - 
Windows 2000 or Wine
Execute: "regedit.exe" /s "E:\Test\PluginTest4\Source\test.reg"
registryVC6sp6A error codes -1 - -1 - -1 - -1 - 

Some Plug-in tests where unsuccessful !
See the details for more info !
Completed

Execute: Regedit.exe
Unicode plug-in test
====================

Windows 2000 or Wine
Execute: "regedit.exe" /s "E:\Test\PluginTest4\Source\test.reg"
RegistryVC60libCurU error codes -1 - -1 - -1 - -1 - 
Windows 2000 or Wine
Execute: "regedit.exe" /s "E:\Test\PluginTest4\Source\test.reg"
registryVC2008U error codes -1 - -1 - -1 - -1 - 
Windows 2000 or Wine
Execute: "regedit.exe" /s "E:\Test\PluginTest4\Source\test.reg"
registryVC2008libU error codes -1 - -1 - -1 - -1 - 
Windows 2000 or Wine
Execute: "regedit.exe" /s "E:\Test\PluginTest4\Source\test.reg"
registryVC6sp6libU error codes -1 - -1 - -1 - -1 - 
Windows 2000 or Wine
Execute: "regedit.exe" /s "E:\Test\PluginTest4\Source\test.reg"
registryVC6sp6U error codes -1 - -1 - -1 - -1 - 

Some Plug-in tests where unsuccessful !
See the details for more info !
Completed

PluginTest5
===========
Ansi plug-in test
=================

Execute: "regedit.exe" /s "E:\Test\PluginTest5\Source\test.reg"
registryVC2008A error codes -1 - -1 - -1 - -1 - 0
Execute: "regedit.exe" /s "E:\Test\PluginTest5\Source\test.reg"
registryVC2008libA error codes -1 - -1 - -1 - -1 - 0
Execute: "regedit.exe" /s "E:\Test\PluginTest5\Source\test.reg"
RegistryVC60libCurA error codes -1 - -1 - -1 - -1 - 0
Execute: "regedit.exe" /s "E:\Test\PluginTest5\Source\test.reg"
registryVC6sp6A error codes -1 - -1 - -1 - -1 - 0
Execute: "regedit.exe" /s "E:\Test\PluginTest5\Source\test.reg"
registryVC6sp6libA error codes -1 - -1 - -1 - -1 - 0
newtextreplaceCurA test is successful
NewTextReplaceVC6sp6A test is successful
NewTextReplace test is successful

Some Plug-in tests where unsuccessful !
See the details for more info !
Completed

Unicode plug-in test
====================

Execute: "regedit.exe" /s "E:\Test\PluginTest5\Source\test.reg"
registryVC2008libU error codes -1 - -1 - -1 - -1 - 0
Execute: "regedit.exe" /s "E:\Test\PluginTest5\Source\test.reg"
registryVC2008U error codes -1 - -1 - -1 - -1 - 0
Execute: "regedit.exe" /s "E:\Test\PluginTest5\Source\test.reg"
RegistryVC60libCurU error codes -1 - -1 - -1 - -1 - 0
Execute: "regedit.exe" /s "E:\Test\PluginTest5\Source\test.reg"
registryVC6sp6libU error codes -1 - -1 - -1 - -1 - 0
Execute: "regedit.exe" /s "E:\Test\PluginTest5\Source\test.reg"
registryVC6sp6U error codes -1 - -1 - -1 - -1 - 0
newtextreplaceCurU test is successful
NewTextReplaceVC6sp6U test is successful

Some Plug-in tests where unsuccessful !
See the details for more info !
Completed

"What about Love?" - "Overrated. Biochemically no different than eating large quantities of chocolate." - Al Pacino in The Devils Advocate

Mark Sikkema
Offline
Last seen: 13 years 1 month ago
Developer
Joined: 2009-07-20 14:55
All isn't that bad as it looks...

All though, I thought I fixed this with the change of ${registry::RestoreKey} into ExecWait (did work for ChrisMorgan)!

Can you confirm that all what's wrong is that the .reg file doesn't get loaded to the registry ?

If so, it would be a great help if you could do a little investigation into it, like throwing in some extra messageboxes, or try to make the following changes to lines 30 & 31 :

SearchPath $9 "regedit.exe"
ExecWait `"$9" /s "$EXEDIR\Source\test.reg"` $R9

Or..

SearchPath $9 "regedit.exe"
ExecDos::exec `"$9" /s "$EXEDIR\Source\test.reg"` `` ``
Pop $R9

Or.. as a last resort..

${plugin}::_RestoreKey "$EXEDIR\Source\test.reg"
Pop $R9
MessageBox MB_OK "Lets make sure _Restorkey has all the time to do it's job, please check regedit for keys!"

With the last option please keep in mind that RegistryVC60libCurA.dll is just the one downloaded from NSIS Wiki (as I'm writing this I realize the binary code is still even different from the one used in NSIS Portable)
So to be totally sure stick the one from NSIS Portable into the Plugin\A folder before you recompile (no need to rename it, it should just pick it up as it is at compile time)
I am assuming you did not have problems before on this version of Wine using PortableApps !

I hope you can help me a bit on this one, Thanx

Formerly Gringoloco
Windows XP Pro sp3 x32

Mark Sikkema
Offline
Last seen: 13 years 1 month ago
Developer
Joined: 2009-07-20 14:55
Just another guess....

Could it be that in your version of Wine

Kubuntu 09.10 with Wine (latest version 1.0.1)

regedit.exe doesn't support 'Registry Editor Version 5.00' (UTF16-LE) files ?

Formerly Gringoloco
Windows XP Pro sp3 x32

Chris Morgan
Chris Morgan's picture
Offline
Last seen: 9 years 4 months ago
Joined: 2007-04-15 21:08
1.1.43

My test was with the latest version in the Ubuntu Wine PPA, 1.1.43. The Wine registry files start with WINE REGISTRY Version 2 which doesn't help clear anything up. I've seen examples on the web of "Registry Editor Version 5.00" files, but those wouldn't tend to end up being saved by the user for applying as UTF-16LE but rather as UTF-8 or ANSI.

You could test it out direct in Wine's regedit.exe. That would probably help clear it up about whether it works or not.

I am a Christian and a developer and moderator here.

“A soft answer turns away wrath, but a harsh word stirs up anger.” – Proverbs 15:1

Mark Sikkema
Offline
Last seen: 13 years 1 month ago
Developer
Joined: 2009-07-20 14:55
I do not have any possibility

I do not have any possibility to test in Wine, nor do I have any experience with using Wine!
So I hope Simeon can help on this...

FYI: Other then 'RestoreKey', the registry plug-in does use it's own C code to 'SaveKey', 'REGEDIT4' for ansi / 'Windows Registry Editor Version 5.00' for UTF-16LE. So 'WINE REGISTRY Version 2' doesn't really apply for this.
I did tried converting a .reg file to UTF-8, but Windows didn't really like that !

Formerly Gringoloco
Windows XP Pro sp3 x32

Simeon
Simeon's picture
Offline
Last seen: 10 years 2 weeks ago
DeveloperTranslator
Joined: 2006-09-25 15:15
finally

I found the time to go and run your 6th zip on my new Kubuntu install. Everything worked ok according to the output, but it did prompt me with an error (Programm had to close due to a severe error) but it kept running. It happened after it said: Testing UTF-16LE.reg file!
I updated my machine so now I have another wine version (1.1.42). Maybe the errors are only on the older wine version...

"What about Love?" - "Overrated. Biochemically no different than eating large quantities of chocolate." - Al Pacino in The Devils Advocate

Mark Sikkema
Offline
Last seen: 13 years 1 month ago
Developer
Joined: 2009-07-20 14:55
I wish we could have tested

I wish we could have tested this with your older version of Wine. But I think we can say that it probably was up to the UTF-16LE format of the .reg file.
According to this, regedit.exe in Wine can only handle the unicode file format since v.1.1.5 (for export at least).

If the unicode registry file format is really the issue, I do not think there is really a solution for this, as I consider it not to be an option to go back to an ansi registry file format !

About the crash message(which never actually really crashed), ChrisMorgan experienced the same. He considered this to be a Wine bug !

[edit: Thanx thought, for testing(again)]

Formerly Gringoloco
Windows XP Pro sp3 x32

Simeon
Simeon's picture
Offline
Last seen: 10 years 2 weeks ago
DeveloperTranslator
Joined: 2006-09-25 15:15
ok

Sorry about that. I updated my box without thinking about it.
Maybe do a Wine version check? Or just hope people updated their wine Wink

"What about Love?" - "Overrated. Biochemically no different than eating large quantities of chocolate." - Al Pacino in The Devils Advocate

Mark Sikkema
Offline
Last seen: 13 years 1 month ago
Developer
Joined: 2009-07-20 14:55
I wonder how many people are

I wonder how many people are still using version 1.0.1, it seems to be the latest one which is called 'Stable'
http://www.winehq.org/

[edit: eventually, but only if really necessary, I could re-write the plug-in so it has it's own code to restore/import the registry file. Instead of using regedit.exe]

Formerly Gringoloco
Windows XP Pro sp3 x32

Chris Morgan
Chris Morgan's picture
Offline
Last seen: 9 years 4 months ago
Joined: 2007-04-15 21:08
Wine storage method

I was mentioning "WINE REGISTRY Version 2" as the top line in the Wine hives (which are just .reg files).

Unicode support missing before 1.1 was what I suspected. You decide how you want to do it all. The current Ubuntu LTS release uses 1.1, so from that front I think it's OK. And it's not a matter of losing portability, just a matter of not loading settings; so long as it reports failure, it won't then try to save the registry key and lose all your settings (is it reporting failure on the RestoreKey call?)

I am a Christian and a developer and moderator here.

“A soft answer turns away wrath, but a harsh word stirs up anger.” – Proverbs 15:1

Mark Sikkema
Offline
Last seen: 13 years 1 month ago
Developer
Joined: 2009-07-20 14:55
It's not giving a failure

It's not giving a failure reply (looking at Simeons tests).
And probably it could be a matter of portability, whenever a default registry file is needed. Like when it's situated in DefaultData or when the launcher makes up one at first start.

I will have ago at writing a script for restoring the key (and have a look at the 'dot' problem).

But still I do not have any idea how big this Wine v1.0.1 is, or even if the file format is really the issue (probably is though, but got to be sure)?

Formerly Gringoloco
Windows XP Pro sp3 x32

Simeon
Simeon's picture
Offline
Last seen: 10 years 2 weeks ago
DeveloperTranslator
Joined: 2006-09-25 15:15
ignore

the dot problem. It was an error on my part and has nothing to do with either the registry plugin nor the launcher.

"What about Love?" - "Overrated. Biochemically no different than eating large quantities of chocolate." - Al Pacino in The Devils Advocate

Mark Sikkema
Offline
Last seen: 13 years 1 month ago
Developer
Joined: 2009-07-20 14:55
Status update !

In the past few days, I done a re-write of ${registry::RestoreKey}. So it includes it's own code to import unicode format registry files, instead of just launching regedit.exe (What the original plug-in was doing).

I got ChrisMorgan to test it in his Wine version 1.1.44, successful.
And myself I just tested it successfully in Wine 1.0.1 (Ubuntu 9.10), in a VirtualBox.

This will do away with all the current issues for Wine, no more crash-messages and unicode registry file format support for more Wine versions, if not all.

In the next few days I will polish-up the code (some better return value handling and support for deleting keys and values).

So I will be able to release the new test-package soon !

Formerly Gringoloco
Windows XP Pro sp3 x32

Mark Sikkema
Offline
Last seen: 13 years 1 month ago
Developer
Joined: 2009-07-20 14:55
The new plug-in (test) has

The new plug-in (test) has been released !

I really hope I didn't do this to early. I basically had it ready last night, but then stumbled upon some issues with the escape sequences, like: \\, \", \r & \n !
Even Windows regedit.exe seems to be buggy for the last two (\r \n). Anyway it should be fixed now !

BTW: I won't be around for 2 days !

[Edit: so it was too early, I didn't include support for value-names with escape sequences. Just the values it self support this for now!
Will fix this in 2 days, together with any other bug what could appear !
Mind you, the only App what I recall needing the escape sequences, is PDF-XChangeViewerPortable.exe! And Windows can't even handle them propperly]

Formerly Gringoloco
Windows XP Pro sp3 x32

prapper
Offline
Last seen: 3 years 9 months ago
Developer
Joined: 2008-01-24 17:01
PluginTest7 successful

WIN XP SP2

Files are identical in WinMerge

Unicode plug-in test

Testing UTF-16LE registry file !
registryU test is successful

Testing ANSI .reg file !
registryU test is successful

The Plug-in test was successful
The new ${Registry::RestoreKey} was used to restore key.

To fully do this test you, could diff the two following files
'WinMerge1.reg' has just been copied over from 'Source\TestUnicode.reg'
'WinMerge2.reg' has first been restored and then saved by the plug-in
Completed
Mark Sikkema
Offline
Last seen: 13 years 1 month ago
Developer
Joined: 2009-07-20 14:55
Thanx prapper !

BTW, can you confirm PDF-XChangeViewerPortable.exe not being able to restore the following value propperly:

[HKEY_LOCAL_MACHINE\SOFTWARE\Tracker Software\PDFViewer\FileAssociations]
"FullBeforeInstall"="HKCR\r\n{\r\n}\r\nHKCU\r\n{\r\n  NoRemove Software\r\n  {\r\n    NoRemove Microsoft\r\n    {\r\n      NoRemove Windows\r\n      {\r\n        NoRemove CurrentVersion\r\n        {\r\n          NoRemove Explorer\r\n          {\r\n            NoRemove FileExts\r\n            {\r\n              NoRemove .pdf\r\n              {\r\n                val Progid = s ''\r\n                val Application = s ''\r\n              }\r\n            }\r\n          }\r\n        }\r\n      }\r\n    }\r\n  }\r\n}\r\n"

Formerly Gringoloco
Windows XP Pro sp3 x32

Mark Sikkema
Offline
Last seen: 13 years 1 month ago
Developer
Joined: 2009-07-20 14:55
Updated! Includes the new

Updated!
Includes the new plug-in with some fixes since last update!
And includes some registry files with all possible options/edits I could think of, to do a full proper test !

I've tested this in Wine1.0.1 Ubuntu 9.10, and XPsp3
And ChrisMorgan in Wine 1.1.43 (PPA) Ubuntu 9.10

Formerly Gringoloco
Windows XP Pro sp3 x32

dboki89
Offline
Last seen: 9 years 9 months ago
Joined: 2009-11-30 20:44
.

Plugin 8 works perfectly on XP SP2 and XP SP3. Will check Vista later today, don't have the time to do so now.

The MD5 checksum is wrong, since I downloaded 3 times, and every download resulted with MD5 of:

c6b716a191a3348278cc9be340f13171

Statistically, it's impossible that I D/Led it 3 times as a 100% same corrupted file... Smile And also, the test ran OK... You might wanna update that Smile

Oh, I like that nice touch, the test automatically opening the Registry Smile

Btw, the result:

Unicode plug-in test

Testing UTF-16LE registry file !
registryU test is successful

Testing ANSI .reg file !
registryU test is successful

The Plug-in test was successful
The new ${Registry::RestoreKey} was used to restore key.

To fully do this test you, could diff the two following files
'WinMerge1.reg' has just been copied over from 'Source\TestUnicode.reg'
'WinMerge2.reg' has first been restored and then saved by the plug-in
Completed

EDIT: oh, and the WinMerge*.reg files are the same, with MD5: 1ae1ebda3277170bc972610e2a4e77c5

My posts are old and likely no longer relevant.

Mark Sikkema
Offline
Last seen: 13 years 1 month ago
Developer
Joined: 2009-07-20 14:55
Thanx dboki89 ! Waiting for

Thanx dboki89 !

Waiting for Vista...

[edit: ...oh, thanx for pointing out the MD5 being wrong, must have missed that. But is fixed now]

Formerly Gringoloco
Windows XP Pro sp3 x32

dboki89
Offline
Last seen: 9 years 9 months ago
Joined: 2009-11-30 20:44
You're welcome :)

Update (you're going to love me now xD);

Now tested on Windows Vista SP2 32bit (Ultimate), Wine 1.1.30, Wine 1.1.43, Wine 1.1.44...

Important!
Tested on Wine 1.2 Release Candidate 1! However, since I personally built it, I'll try building it again on another distro to verify.

All results are successful. In Wine, as you mentioned, the values in WinMerge*.reg files are scattered around... Naturally I didn't search for each and every value to determine if it's OK. I just diagnosed by checking:

-> Size: 118.376 bytes (in all files)
-> Characters: 861 (in all files)
-> RegKeys (just their names): same (in all files)
and as one final precaution,
-> Encoding: Unicode with BOM (in all files)

I can't figure out why it works for me and doesn't work for JTH. I noticed I had to hit F5 to refresh, since Vista was pretty slow about updating the tree-view in regedit, but the keys were removed without a problem...

My posts are old and likely no longer relevant.

John T. Haller
John T. Haller's picture
Offline
Last seen: 1 hour 38 min ago
AdminDeveloperModeratorTranslator
Joined: 2005-11-28 22:21
Windows 7 x64 Successful

The test ran successfully in Windows 7 x64 Ultimate. And the files are identical.

Sometimes, the impossible can become possible, if you're awesome!

John T. Haller
John T. Haller's picture
Offline
Last seen: 1 hour 38 min ago
AdminDeveloperModeratorTranslator
Joined: 2005-11-28 22:21
Vista SP1&SP2 Failed

Vista SP1&SP2 failed. Both the UTF-16LE and ANSI .reg files yielded all -1s.

Sometimes, the impossible can become possible, if you're awesome!

Mark Sikkema
Offline
Last seen: 13 years 1 month ago
Developer
Joined: 2009-07-20 14:55
I re-compiled

I re-compiled including:

RequestExecutionLevel user

Hope that will sort it out...

Formerly Gringoloco
Windows XP Pro sp3 x32

Soulmech
Offline
Last seen: 12 years 4 months ago
Joined: 2010-03-03 10:52
Test was successful on Win 7

Test was successful on Win 7 x64 (home edition)

SWAG

Chris Morgan
Chris Morgan's picture
Offline
Last seen: 9 years 4 months ago
Joined: 2007-04-15 21:08
1.2-rc1

It was actually 1.2-rc1 I tested it in for Wine, on Ubuntu 10.04. I'm all up to date.

I am a Christian and a developer and moderator here.

“A soft answer turns away wrath, but a harsh word stirs up anger.” – Proverbs 15:1

John T. Haller
John T. Haller's picture
Offline
Last seen: 1 hour 38 min ago
AdminDeveloperModeratorTranslator
Joined: 2005-11-28 22:21
Test10 with new code, all works

I checked out TEST10 with the new registry code and all works. Win7x64 Ultimate 64bit, Vista SP2 32bit, WinXP, Win2K and Wine on Ubuntu (standard version from repository).

Sometimes, the impossible can become possible, if you're awesome!

Mark Sikkema
Offline
Last seen: 13 years 1 month ago
Developer
Joined: 2009-07-20 14:55
Isn't it great !

Isn't it great ! Smile

Formerly Gringoloco
Windows XP Pro sp3 x32

Log in or register to post comments