Zim Desktop Wiki for Windows 0.54 Dev Test 1

It may not be a "publisher submission" but the Zim download page (http://zim-wiki.org/downloads.html) has a link to Brendan Kidwell's Windows installer for Zim (http://www.glump.net/software/zim). In fact that is the only link supplied for the Windows version of Zim.

1. Users can create/use notebooks outside that folder.
2. The custom application list.

The following custom code should fix #2:

${SegmentFile}

${SegmentPre}
	FindFirst $0 $1 $DataDirectory\.local\share\zim\application\*.desktop
	${DoUntil} $1 == ""
		${ReplaceInFile} $DataDirectory\.local\share\zim\application\$1 $LastDrive\ $CurrentDrive\
		${ReplaceInFile} $DataDirectory\.local\share\zim\application\$1 $LastDrive/ $CurrentDrive/
		FindNext $0 $1
	${Loop}
	FindClose $0
!macroend

Also, you don't need an EULA for GPL.

The GPL should be removed. It is not an EULA.

GNU General Public License, version 2 5. You are not required to accept this License, since you have not signed it. However, nothing else grants you permission to modify or distribute the Program or its derivative works. These actions are prohibited by law if you do not accept this License. Therefore, by modifying or distributing the Program (or any work based on the Program), you indicate your acceptance of this License to do so, and all its terms and conditions for copying, distributing or modifying the Program or works based on it.

You need to accept the GPL, but the end users do not. Thus it is not an End User License Agreement.

There's a relatively steep learning curve for getting the hang of portablizing software using our tools, but it's worth it in the end. Hope we're not scaring you off. Now, on to comments:

A number of these issues can be avoided in the future, (if you stick around and build more apps :)) by using the PortableApps.com Application Template (direct download)

File App\readme.txt is missing
I created this file by textifiying ./help.html .

The contents of this particular readme should be the following, as it is a standard "warning" file:

The files in this directory are necessary for the portable application to function.  There is normally no need to directly access or alter any of the files within these directories.

File Other\Source\AppNamePortable.ini is missing
I don't understand this error. Creating an empty file literally called "AppNamePortable.ini" makes it go away, but what is the purpose of this file?

The purpose of AppNamePortable.ini is to allow users to customize how the application is run. The contents of this file should be as follows:

AdditionalParameters=
DisableSplashScreen=false
RunLocally=false

# The above options are explained in the included readme.txt
# This INI file is an example only and is not used unless it is placed as described in the included readme.txt

File Other\Source\License.txt is missing
Downloaded GPL text from Zim source and called it License.txt.

This particular license is going to be rename LauncherLicense.txt, but hasn't yet made it into the validator. It is, as indicated, the license for the launcher, rather than the base application (Zim). It should be a copy of the GPL 2, so that's fine as it is.

File Other\Source\Readme.txt is missing
Created a Readme pointing to the upstream source tree for all of Zim including the Portable launcher/installer source.

The base application's source code is available from the portable app's
homepage listed in the help.html file.

Details of most other things are available there as well.

LICENSE
=======

This package and its launcher are released under the GPL. The launcher is the
PortableApps.com Launcher, available with full source and documentation from
https://portableapps.com/development. We request that developers using the
PortableApps.com Launcher please leave this directory intact and unchanged.

USER CONFIGURATION
==================

(For this section, AppNamePortable is the executable base file name, normally
the App ID of the package.)

Some configuration in the PortableApps.com Launcher can be overridden by the
user in an INI file next to AppNamePortable.exe called AppNamePortable.ini.  If
you are happy with the default options, it is not necessary, though.  There is
an example INI included with this package to get you started.  To use it, copy
PortableApps.comLauncher.ini from this directory to AppNamePortable.ini next to
AppNamePortable.exe. The options in the INI file are as follows::

   AdditionalParameters=
   DisableSplashScreen=false
   RunLocally=false

(There is no need for an INI header in this file; if you have one, though, it
won't damage anything.)

The AdditionalParameters entry allows you to pass additional command-line
parameters to the application.

The DisableSplashScreen entry allows you to run the launcher without the splash
screen showing up.  The default is false.

The RunLocally entry allows you to run the portable application from a read-
only medium. This is known as Live mode. It copies what it needs to to a
temporary directory on the host computer, runs the application, and then
deletes it afterwards, leaving nothing behind. This can be useful for running
the application from a CD or if you work on a computer that may have spyware or
viruses and you'd like to keep your device set to read-only. As a consequence
of this technique, any changes you make during the Live mode session aren't
saved back to your device.  The default is false.

There may be other values also permitted in the user configuration file by the
portable application; refer to help.html for any details of them.

Needs drive letter changing support (I can work on it)
I copied the script from kAlug's message in this thread on 2011-09-29 17:51. I put the code into my Custom.nsh, and I got this result when building the launcher: http://pastebin.com/WFgucPg3 "Error in macro Custom.nsh_Pre on macroline 4". I need someone to help me fix this; I feel like I'm in undocumented territory. In the mean time, I renamed the file to Custom.nsh_disabled .

The values in ReplaceInFile should all be quoted. see here for a working Custom.nsh: http://pastebin.com/SNYF0a67

Hope that helps!
If the DefaultData is empty, it can be removed from the package entirely.

Oh, and when you update the portable build like this, please note it in two ways:

1. By making a list of release notes on this page, indicating the build is now Development Test x (x being the number of builds you've put up here for testing, so in this case, the next Dev Test would be 3. I think.
2. More importantly, making your DisplayVersion value in appinfo.ini equal to 0.53 Development Test x (same as above, so Development Test 3 next time.)

[EDIT NOV 6] Clarified where to list release notes.

@mwayne:

Okay, I found the file at `F:\PortableApps\ZimDesktopWikiPortable\APP\APPINFO\LAUNCHER\ZIMDESKTOPWIKIPORTABLE.INI` and it contained the following:

[Launch]
ProgramExecutable=ZimDesktopWiki\zim.exe

[Environment]
XDG_CONFIG_HOME=%PAL:DataDir%\Config
HOME=%PAL:DataDir%


I went ahead and made the suggested changes (additions) and it worked like a charm. I'll return if I find any plugins that have issues.

@mwayne: I posted a summary of this discussion (with attribution of course) to the ZimWiki bug report and Brendan will be implementing your suggested changes to the [Environment] section of the INI file in the next release. Yay!