You are here

Disk Cleaner Portable 1.7.1645 Development Test 2

22 posts / 0 new
Last post
prapper
Offline
Last seen: 3 years 4 months ago
Developer
Joined: 2008-01-24 17:01
Disk Cleaner Portable 1.7.1645 Development Test 2

Application: Disk Cleaner
Category: Utilities
License: GNU GPL
Language: English
Description: Disk Cleaner quickly and easily removes temporary files like those in the system temporary folder, the Internet Explorer cache and cookies folders, the Recycle Bin and more.

Download Disk Cleaner Portable 1.7.1645 Development Test 2 [1MB download / 1MB installed]
(MD5: 4aa842ddaedcc123a944e2917b20efb2)

Release Notes:

1.7.1645 Development Test 2 (2010-11-01):

  • Using the back button now creates an entry in the registry (!) so I activated registry handling in the launcher. I'm not sure whether it needs to be saved to be honest, as I *think* the info (last used preset) is duplicated in settings\dcsettings.ini, but I'm saving it to be on the safe side. The key is HKEY_CURRENT_USER\Software\dclean and, if the previous dev test created it, you'll have to delete it manually.

1.7.1645 Development Test 1 (2010-10-31):

  • Disk Cleaner has been updated to 1.7 (config file issue fixed).
  • Now successfully using -p switch.
  • Removed admin requirement from launcher.
  • App\dclean\plugins preserved on upgrade.
  • Uses PAL 2.1 Pre (rev. e47661cf96ca).

1.6.1355 Development Test 4 (2010-08-01):

  • Reverted back to custom launcher.
    ("RunAsAdmin=force" doesn't work whereas "RequestExecutionLevel admin" does).

1.6.1355 Development Test 3 (2010-07-31):

  • Converted to PAL 2.0.

1.6.1355 Development Test 2 (2010-06-07):

  • Disk Cleaner Portable now requires admin on Vista/7.

1.6.1355 Development Test 1 (2010-06-07): Initial release

Tested with:
7 Home Premium (User/Admin)
XP Home SP2 (User/Admin)
XP Home SP3 (User/Admin)

Acknowledgements:
Thanks to Patrick for hosting.

horusofoz
horusofoz's picture
Offline
Last seen: 9 months 2 weeks ago
Joined: 2008-04-03 22:45
Error on close

This installed over the previous version without incident. After application started I selected to run as admin. The app restarted as such. Ran without issue. However when closing the app I got this error message.

Windows 7 Professional x86 with admin rights.

PortableApps.com Advocate

prapper
Offline
Last seen: 3 years 4 months ago
Developer
Joined: 2008-01-24 17:01
OK, I see what's happening.

The app will restart itself under normal circumstances if you go back and rescan after cleaning. CheckRunning/FindProc deals with this fine. If you select 'run as admin' from the GUI (Vista/7 only), the app restarts under a different account (admin) so FindProc fails, the launcher cleans up (removing the config file) and exits leaving Disk Cleaner high and dry!

I'm not sure that there's anything that can be done about this (somebody correct me if I'm wrong) except requesting admin from the outset, so that's what I've done in DT2. I've also upped the sleep time in CheckRunning to 2 secs, just in case (more for the first scenario if there's been a lot of stuff added since the last scan).

Nothing has been left behind after running DT1 but, unfortunately, DT2 now requires admin on Vista/7 to avoid this situation.

On a related note, the app supports the -p command line switch (which forces it to write the INI to it's own directory rather than %APPDATA%\Disk Cleaner) which would solve the problem but, if you rescan, it restarts again without it and creates the folder in %APPDATA% so I don't really see what use it is (so I'm not using it). I didn't test this with 'run as admin' though (as it's already been ruled out).

prapper
Offline
Last seen: 3 years 4 months ago
Developer
Joined: 2008-01-24 17:01
Updated to 1.6 Development Test 2

See release notes for changes.

prapper
Offline
Last seen: 3 years 4 months ago
Developer
Joined: 2008-01-24 17:01
Re: comments

rjmmoerlandFirst and foremost: what can I (the author) do to get the current Disk Cleaner accepted as portable? When '-p' is specified on the command line (which stands for portable), Disk Cleaner saves its settings to the application folder. Otherwise, it saves them to the users Application Data folder (non-portable, but Vista/7 compliant, therefore).

Some random comments:

- Yes, the icon is ugly. I'm no graphics artist. I tried again with the rewrite but it's still, well, ugly Eye-wink Any graphics artist out there may contribute a better one Smiling
- No, I have never heard about any trouble regarding the recycle bin. Works for me every time but any feedback on the issue is welcome.
- The XP and Vista/7 installers were split again, since many plug-ins available for XP don't run or are useless on Vista/7. Therefore, XP users are possibly better off with the old installer. The Vista/7 application should work just fine on XP though.

The -p switch is good but I think I found an issue with it when the app is restarted with the back button (although it's nothing that can't be got around). See my comment above.

I never knew what people were complaining about with the icon. What's the matter with it? Smile

Re: the Recycle Bin. When I first ran version 1.6.1353 on XP the BitBucket\DriveLetter regkeys (which weren't previously present) were created and my Recycle Bin subsequently seemed confused about whether it was in use or not. I can't remember exactly how I fixed it but I think I just removed the keys again and rebooted. Those keys are now present on this machine (XP) with an entry for all previously attached local disks. When I tested 1.6.1355 on 7 I had no trouble.

So there is currently only one Disk Cleaner installer for XP and Vista/7, which does make things easier.

I've just updated this package to the latest PortableApps.com Format™ specification including the new PortableApps.com Launcher but I think whether it makes the app directory or not depends on how many people test it, like it & report back positively about it. I'm not the official word on that though.

rjmmoerland
Offline
Last seen: 13 years 7 months ago
Joined: 2010-07-30 13:08
Hey prapper, thanks for

Hey prapper, thanks for pointing me to the new thread.

The -p switch is good but I think I found an issue with it when the app is restarted with the back button (although it's nothing that can't be got around). See my comment above.

Yes you did. It's actually quite silly that I've never seen it. I hope to have fixed this in the current development version (1.8, not available yet). If it works, I'll probably port it back to 1.7 (and I might port it back to 1.6).

Weird story on the Recycle bin though, I have never encountered such behavior before. All Disk Cleaner does is cycle through all fixed drives available and query the size of the trash on each drive (with SHQueryRecycleBin, for who's interested). No freaky stuff, but all nicely handled by windows itself.

So there is currently only one Disk Cleaner installer for XP and Vista/7, which does make things easier.

Exactly, my support for Win2k and lower has ended with the rewrite. I'll keep XP compatibility as long as possible if it's not too much trouble.

My goal isn't to have Disk Cleaner in the app directory per se, but it is to have it function as portable as possible and make the few users that use it happy with it.

Thanks for your effort! And if I can help with anything on the source code side of Disk Cleaner, let me know.

Robert

EDIT: I tested Dev3 on my machine (7 Ultimate x86) and I got an error message, "Unknown option 'UAC'": http://img594.imageshack.us/img594/1824/dcerror.png

I guess the option UAC is passed to the Disk Cleaner exe itself?

prapper
Offline
Last seen: 3 years 4 months ago
Developer
Joined: 2008-01-24 17:01
Oh dear :-(

Yes, it looks that way doesn't it. That was my fault, I confess I didn't have a chance to test on 7 before uploading.

I have just uploaded DT4 which has gone back to using the old-fashioned NSIS launcher, which *is* tested and working on 7, so let me know how you get on with it.

Thanks for looking at the -p switch, I'll keep an eye open for the new version but you can always drop me a note here if you want a quick response.

Thanks for your input on this Robert Smile

rjmmoerland
Offline
Last seen: 13 years 7 months ago
Joined: 2010-07-30 13:08
1.7 version updated

Hi prapper,

I've just released a new version of Disk Cleaner 1.7. I consider this version stable, I've been working on 1.8 for some time already. The foremost bug fixed in this update is loosing portable mode when the back button or run as admin button are pressed. It's available from sourceforge: http://sourceforge.net/projects/dclean/files/dclean/1.7.1616/dcsetup_1.7...

I hope this will get the above issues fixed Smile

Cheers

prapper
Offline
Last seen: 3 years 4 months ago
Developer
Joined: 2008-01-24 17:01
Thanks for 1.7

Thanks for 1.7. The -p is working great, I can't get that appdata folder to appear at all Smile

I have had a bit of oddness with the back button though. If I'm running dc off a HDD there's absolutely no problem but as soon as I put it onto a (slower) flash drive I start to get these sort of errors:

14:36:43: can't remove file 'H:\dclean\dcsettings.ini' (error 5: access is denied.)
14:36:43: Failed to update user configuration file.
14:47:02: can't open file 'H:\dclean\dcsettings.ini' (error 5: access is denied.)
14:47:02: can't open user configuration file 'H:\dclean\dcsettings.ini'.

Even if it doesn't generate the error message I think there's still sometimes a problem as I occasionally lose any preferences I've set when I use the back button. This is all without a launcher and only on a slower drive.

rjmmoerland
Offline
Last seen: 13 years 7 months ago
Joined: 2010-07-30 13:08
Weird!

Hi,

Weird behaviour, I'm going to have to look into that. First guess would be some kind of write protection, but I assume that's not it?

rjmmoerland
Offline
Last seen: 13 years 7 months ago
Joined: 2010-07-30 13:08
Think I nailed it.

Error was due to some behavior I didn't expect in the user interface library I use. I think the latest version should fix this. I can't reproduce the error anymore. Available from the web site but here's a shortcut:
http://www.xs4all.nl/~mp2004/a_install/dcsetup_1.7.1621.exe

Robert

prapper
Offline
Last seen: 3 years 4 months ago
Developer
Joined: 2008-01-24 17:01
Sorry to say

Sorry to say that I'm still getting the error. I can't really add to the above report except to say that when I test *with* the PA launcher I also get error 2 & error 32 in addition to error 5. It all seems a bit random so I'm not sure whether they were just coincidence (and it's still happening standalone).

I can't see that there are any permissions issues, I tried it with a couple of FAT32 flash drives and I still can't reproduce it on the internal HDD. ???

rjmmoerland
Offline
Last seen: 13 years 7 months ago
Joined: 2010-07-30 13:08
Thanks for the info. Am

Thanks for the info. Am working on it..

rjmmoerland
Offline
Last seen: 13 years 7 months ago
Joined: 2010-07-30 13:08
Released a new version

I released a new version, could you please try again with 1.7.1629? It's available from here: http://www.xs4all.nl/~mp2004/a_install/dcsetup_1.7.1629.exe

Cheers,
Robert

prapper
Offline
Last seen: 3 years 4 months ago
Developer
Joined: 2008-01-24 17:01
outstanding issues

Although it's taken me longer than usual to get round to this, I tested 1.7.1645 and all outstanding issues appear to be fixed. Thanks Robert.

Chris Morgan
Chris Morgan's picture
Offline
Last seen: 9 years 3 days ago
Joined: 2007-04-15 21:08
RunAsAdmin=compile-force

Seeing how you had issues with the UAC plugin, and also because scriptdaemon has had some (to do with how it deals with environment variables), I've put in another option for RunAsAdmin, compile-force. This is less friendly than force as it won't provide an explanatory message box about it, but if it will fix issues like these, it's worth having. It would be good if you could try it and see if it works properly (get the tip zip, compile the Generator then run it). Thanks in advance Smile

I am a Christian and a developer and moderator here.

“A soft answer turns away wrath, but a harsh word stirs up anger.” – Proverbs 15:1

prapper
Offline
Last seen: 3 years 4 months ago
Developer
Joined: 2008-01-24 17:01
admin

Due to the issues with the base app being resolved, admin isn't required here anymore. I still tested it though: 'compile-force' works as expected (but 'force' still doesn't). Thanks Chris.

Chris Morgan
Chris Morgan's picture
Offline
Last seen: 9 years 3 days ago
Joined: 2007-04-15 21:08
Thanks

Well, that may be the only case where something was wrong... but still, probably worth while having that option. Perhaps some time in the future I should look at that version of Disk Cleaner and try to figure out what was happening with it - it may point to some other issue in PAL. I don't know.

Glad you've got it sorted, anyway Smile

I am a Christian and a developer and moderator here.

“A soft answer turns away wrath, but a harsh word stirs up anger.” – Proverbs 15:1

prapper
Offline
Last seen: 3 years 4 months ago
Developer
Joined: 2008-01-24 17:01
Updated to 1.7.1645 Development Test 1

See release notes for changes.

prapper
Offline
Last seen: 3 years 4 months ago
Developer
Joined: 2008-01-24 17:01
Updated to 1.7.1645 Development Test 2

See release notes for changes.

rjmmoerland
Offline
Last seen: 13 years 7 months ago
Joined: 2010-07-30 13:08
Registry Key

Hi prapper,

Is it your experience that Disk Cleaner itself writes to the registry? If so, I need to fix that fast. My intention is to keep Disk Cleaner from using the registry in all cases, even when not in portable mode!

Cheers,
Robert

PS. Thanks for the trouble, of course

prapper
Offline
Last seen: 3 years 4 months ago
Developer
Joined: 2008-01-24 17:01
Hi Robert

Hi Robert,

Yes, it writes that key as soon as you hit the back button.

No trouble!

Log in or register to post comments