[Fixed] PortableApps.com Launcher 2.1 Can't Handle Additional Starts

ChrisMorganyou should not abort the program after the Init hook.

How should I handle an invalid password, then? Just create a goto that skips the rest of the code in the affected function?

ChrisMorgan Your Pre code belongs in Init, as does much of the PrePrimary code.

I'll move my Pre code to Init, but I'm not so sure about the PrePrimary. Isn't Init called each time the launcher opens (i.e. if the user runs IronPortable.exe again)? The user should only need to enter the master password once, hence my selection of PrePrimary for that code.

ChrisMorganthe language file includes strings it shouldn't, CallANSIPlugin.nsh isn't needed with PAL 2.1, PluginsA isn't needed, and what is the Languages directory doing there at all?

All taken care of. Is this ok for the language file?

ChrisMorganCustom.nsh could also be cleaned up somewhat (ImportPasswords and ExportPasswords don't need to be in separate functions, for example, only getting called once, and can be inlined.)

I'm not sure how I would cleanly merge ImportPasswords and ExportPasswords, since the functions' cores are fairly different. Do you just want me to create one big conditional:

;setup code common to ImportPasswords and ExportPasswords goes here
${If} Import == "true"
;ImportPasswords code here
${Else}
;ExportPasswords code here
${EndIf}


Looking back, that's a good-sized amount of cleanup. Do you think it's worth a revision for Iron? (Please keep in mind that we just posted 12.0.750, and that SRWare usually posts a revision or two of their own)

Thanks for the suggestions!

I can also confirm it for Opera and FoxitReader. I assigned the FoxitPortable.exe as the default app for PDFs and OperaPortable.exe as default browser.

The following scenario describes opening PDFs with FoxitPortable.exe as assigned app. The behavior is the same when opening links with OperaPortable.exe.

If I open the first document, the corresponding app is opened showing the document. Open another document and everything works again - another windows is opened to display it. But then the ini-file is broken. After opening the second document the status changes to "starting" stays forever. So when trying to open the third document I get the "Another instance is currently loading ...".

For Opera, I manually replace OperaPortable.exe with the one from OperaPortable 11.00. Works fine with newer version but not a real solution and requires manual manipulation.

I didn't exercise enough caution during "starting". It should skip writing that value if it's a secondary launch. I had observed the potential problem with the "stopping", but I think I had been depending on "running" being set - forgetting that it's not set if $WaitForProgram == false and $SecondaryLaunch == true implies that. Still, though, when the primary instance is closed, it should clear up the "starting" value, so it should just be third and subsequent starts which don't work until they're all killed and then it should start working again. Is it not doing this?

I found a comparatively minor related bug with it, too - secondary launches would leave $PLUGINSDIR\runtimedata.ini behind. Fixing that for 2.1.1 as well.

Perhaps for 2.2 I should add some more to the starting/stopping error messages: "If you aren't starting $AppNamePortable and you keep getting this message, delete $DataDirectory\PortableApps.comLauncherRuntimeData-$BaseName.ini."

Thanks to all those involved.

Surprised that few users seem to have encountered this (judging by search of forum) but delighted that it's been attended to and sorted.

This issue is unrelated to the one posted above. It's also unrelated to PortableApps.com. A distributed copy of Illustrator Portable is warez (illegal) and nothing to do with our site (it also probably has other nasty stuff in it). We only build and support legal software.