You are here

[Fixed] Language switching in fre:ac Portable 1.0.20a

25 posts / 0 new
Last post
tapsklaps
Offline
Last seen: 5 years 9 months ago
Developer
Joined: 2010-10-17 08:11
[Fixed] Language switching in fre:ac Portable 1.0.20a

The language switching doesn't work correctly in the PortableApps.com Platform. Though I have changed the language in the app, this won't saved permanently.

Gord Caswell
Gord Caswell's picture
Offline
Last seen: 1 day 11 hours ago
DeveloperModerator
Joined: 2008-07-24 18:46
Confirmed

I can confirm this.

John, this is dealt with in the PAL build I sent you, feel free to pull whatever you need from it.

John T. Haller
John T. Haller's picture
Online
Last seen: 43 min 5 sec ago
AdminDeveloperModeratorTranslator
Joined: 2005-11-28 22:21
Your Build

The build of fre:ac I posted was your build. I recompiled it, as always. Unless you used a non-stable PAL?

Sometimes, the impossible can become possible, if you're awesome!

Gord Caswell
Gord Caswell's picture
Offline
Last seen: 1 day 11 hours ago
DeveloperModerator
Joined: 2008-07-24 18:46
Tomorrow

In that case, I'll look into it tomorrow.

tapsklaps
Offline
Last seen: 5 years 9 months ago
Developer
Joined: 2010-10-17 08:11
Solution for the standalone version

Because the language problem also occurs in the standalone version, I've now found a solution for this case. The code in section [LanguageFile] of the file freacPortable.ini must have the following content:

[LanguageFile]
Type=ConfigRead
File=%PAL:DataDir%\config.xml
Entry='  <value name="Language">'
TrimRight=</value>
CaseSensitive=true
Gord Caswell
Gord Caswell's picture
Offline
Last seen: 1 day 11 hours ago
DeveloperModerator
Joined: 2008-07-24 18:46
Done

This is taken care of in the revision I sent John.

John T. Haller
John T. Haller's picture
Online
Last seen: 43 min 5 sec ago
AdminDeveloperModeratorTranslator
Joined: 2005-11-28 22:21
Fixed in 1.0.20a

This issue is resolved in fre:ac Portable 1.0.20a.

Sometimes, the impossible can become possible, if you're awesome!

tapsklaps
Offline
Last seen: 5 years 9 months ago
Developer
Joined: 2010-10-17 08:11
No changes in the file freacPortable.ini

I have searched in the file freacPortable.ini but I can't find any changes. Can you explain me the reason for the fact, that this revision now works fine?

John T. Haller
John T. Haller's picture
Online
Last seen: 43 min 5 sec ago
AdminDeveloperModeratorTranslator
Joined: 2005-11-28 22:21
Does it work?

I didn't make the fix, Gord did. Does it work now? If so, who cares Smile

Sometimes, the impossible can become possible, if you're awesome!

Gord Caswell
Gord Caswell's picture
Offline
Last seen: 1 day 11 hours ago
DeveloperModerator
Joined: 2008-07-24 18:46
Tested with multiple

I tested the language switching with multiple languages prior to pushing it, so yes, please file a bug report if it doesn't work. If I remember, I'll post the changes for you tomorrow.

tapsklaps
Offline
Last seen: 5 years 9 months ago
Developer
Joined: 2010-10-17 08:11
kind of changes

For my personal understanding it would be interested for me to know, what specific changes was performed, so that now the language switching works fine.

John T. Haller
John T. Haller's picture
Online
Last seen: 43 min 5 sec ago
AdminDeveloperModeratorTranslator
Joined: 2005-11-28 22:21
Teasing

FWIW, I was teasing and expecting Gord to answer. Is it working properly now?

Sometimes, the impossible can become possible, if you're awesome!

tapsklaps
Offline
Last seen: 5 years 9 months ago
Developer
Joined: 2010-10-17 08:11
Fundamental

Surely it would be beneficial for everyone here if the developers not keep secret its knowledge. Only then can the development of portable programs faster expedited.

John T. Haller
John T. Haller's picture
Online
Last seen: 43 min 5 sec ago
AdminDeveloperModeratorTranslator
Joined: 2005-11-28 22:21
Is it working?

Again, is it working properly for you?

Sometimes, the impossible can become possible, if you're awesome!

tapsklaps
Offline
Last seen: 5 years 9 months ago
Developer
Joined: 2010-10-17 08:11
already confirmed

This question I have already confirmed in 2 of my previous messages. The app works fine now.

Gord Caswell
Gord Caswell's picture
Offline
Last seen: 1 day 11 hours ago
DeveloperModerator
Joined: 2008-07-24 18:46
No secrets

We aren't keeping secrets about how we're doing anything. Every app we have has source/ methodologies clearly available. To make it easy for you to find the specifics in this particular case, I offer that I have the relevant changset available in my fre:ac portable mercurial repository here. If you look at it, you'll see that there are changes compared to the previous release to ensure language switching works properly at all times.

tapsklaps
Offline
Last seen: 5 years 9 months ago
Developer
Joined: 2010-10-17 08:11
simpler method

Why so complicated? How about if you just tell me the main changes directly? Unfortunately I doesn't have the previous release of fre:ac Portable. Therefore it's impossible for me, that I find out this changes.

John T. Haller
John T. Haller's picture
Online
Last seen: 43 min 5 sec ago
AdminDeveloperModeratorTranslator
Joined: 2005-11-28 22:21
Changes

There are two types of descriptions. One is for users, and that is given in the announcement (language switching is fixed). The second is for developers and you can do it yourself by comparing the previous and current releases or by looking at diffs in the repository. I think you now have both, so I'm confused as to what more you need. Language switching is fixed and you can look at the diffs if you're interested from a development standpoint.

Sometimes, the impossible can become possible, if you're awesome!

Gord Caswell
Gord Caswell's picture
Offline
Last seen: 1 day 11 hours ago
DeveloperModerator
Joined: 2008-07-24 18:46
It IS simple

Did you look at the page I linked to? On that page, the changes are shown between the two versions. I'm not going to walk you through every detail, when you've been provided with a method to see for yourself. You don't need anything installed to see the changes, just use a web browser.

tapsklaps
Offline
Last seen: 5 years 9 months ago
Developer
Joined: 2010-10-17 08:11
mercurial repository

Now I have looked at your linked page. Apparently represent the green marked lines the changes, that have been added. Accordingly the red marked lines were removed. I hope to interpret this correctly.

John T. Haller
John T. Haller's picture
Online
Last seen: 43 min 5 sec ago
AdminDeveloperModeratorTranslator
Joined: 2005-11-28 22:21
Correct

That way you can see what was removed/added/changed in every file.

Sometimes, the impossible can become possible, if you're awesome!

tapsklaps
Offline
Last seen: 5 years 9 months ago
Developer
Joined: 2010-10-17 08:11
Analysis of your changes

Now I have analyzed your changes in the file freacPortable.ini regarding the language switching.

  1. Setting a language other than English

    By means of the section [FileWrite2] was now in the config.xml file (contained in the Data folder) the correct value "freac_%PAL:Language Custom%.xml</value>" instead of the previous incorrect value "%PAL:LanguageCustom%</value>" specified. Thus it is now possible to find the appropriate language file (contained in the folder %PAL:AppDir% \freac\lang).

  2. Setting the default language of English

    By means of the section [FieleWrite4] was now in the config.xml file replaced the incorrect expression "freac_internal.xml" through the correct expression "internal".

I hope that my statements are true and I ask for correction if not. At this point thank you again for providing your mercurial repository.

Gord Caswell
Gord Caswell's picture
Offline
Last seen: 1 day 11 hours ago
DeveloperModerator
Joined: 2008-07-24 18:46
That's correct.

That's correct.

Robert Kausch
Offline
Last seen: 3 years 9 months ago
Joined: 2008-09-24 11:34
Thanks for fixing this!

Thanks for fixing this! I just stumbled across this thread, 'cause I had that problem still on my to do list.

There were actually two problems playing a role in this:

1. The one explained and fixed here. The PortableApps.com script wrote just the ISO language code to the config, whereas fre:ac expected the actual name of the language file to use.

2. If no valid language was set, fre:ac would start up in English. However, the config dialog would select the first entry from the list of available languages. That's why fre:ac was switching to Arabic when closing the config dialog. Users reported that behaviour here a few years ago*, but we didn't find the reason for it back then.

I fixed problem #2 about two weeks ago, so the patch will be in fre:ac 1.0.21. The fix for #1 should rule out #2 as well in most cases though.

* see https://portableapps.com/node/23524 and https://portableapps.com/node/24152

Gord Caswell
Gord Caswell's picture
Offline
Last seen: 1 day 11 hours ago
DeveloperModerator
Joined: 2008-07-24 18:46
Thanks!

Thanks for the update, Robert!

Log in or register to post comments